Re: [patch] Documentation/SubmittingPatches: Reported-by tags and permission
On Fri, 14 Feb 2014 12:30:01 +0300 Dan Carpenter dan.carpen...@oracle.com wrote: -If this patch fixes a problem reported by somebody else, consider adding a -Reported-by: tag to credit the reporter for their contribution. Please -note that this tag should not be added without the reporter's permission, -especially if the problem was not reported in a public forum. That said, -if we diligently credit our bug reporters, they will, hopefully, be -inspired to help us again in the future. +The Reported-by tag is to give credit to people who find bugs and report them. +Please note that if the bug was reported in private, then ask for permission +first before using the Reported-by tag. As the guy who wrote the original text, I think this is an improvement...but can we get a version that retains the motivation for crediting bug reporters in the first place? Thanks, jon ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [patch] Documentation/SubmittingPatches: Reported-by tags and permission
On Tue, Oct 28, 2014 at 09:04:51AM -0400, Jonathan Corbet wrote: On Fri, 14 Feb 2014 12:30:01 +0300 Dan Carpenter dan.carpen...@oracle.com wrote: -If this patch fixes a problem reported by somebody else, consider adding a -Reported-by: tag to credit the reporter for their contribution. Please -note that this tag should not be added without the reporter's permission, -especially if the problem was not reported in a public forum. That said, -if we diligently credit our bug reporters, they will, hopefully, be -inspired to help us again in the future. +The Reported-by tag is to give credit to people who find bugs and report them. +Please note that if the bug was reported in private, then ask for permission +first before using the Reported-by tag. As the guy who wrote the original text, I think this is an improvement...but can we get a version that retains the motivation for crediting bug reporters in the first place? At the risk of upsetting the apple cart, I'd prefer we downplay anything that walks down the path of gamification (by focusing on credit). As best anyone has ever explained it to me, the Acked-by, Reviewed-by, etc are there to impart information regarding a specific commit. In the event that a commit is fingered in a bisect, you have a much better list of names to Cc, instead of just the maintainer from MAINTAINERS and the author from the top of the offending file. The author has often moved on, and the maintainer may not have been around for the bugfix. I know Greg has spoken out against gamification before, and I also understand the desire to encourage bug reporters. Perhaps I should just suggest the following: The Reported-by tag helps us maintain contact info for people with intimate knowledge of a commit or a bug fix. Please seek the reporter's permission before adding the tag to the commit. That said, if we diligently credit our bug reporters, they will, hopefully, be inspired to help us again in the future. It's most likely ok here since it's rather hard to manufacture a list of bugs in order to inflate ones count of Reported-by's. Unlike S-o-b, Ack's, etc. thx, Jason. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [patch] Documentation/SubmittingPatches: Reported-by tags and permission
On Tue, 28 Oct 2014 12:58:27 -0400 Jason Cooper ja...@lakedaemon.net wrote: At the risk of upsetting the apple cart, I'd prefer we downplay anything that walks down the path of gamification (by focusing on credit). As best anyone has ever explained it to me, the Acked-by, Reviewed-by, etc are there to impart information regarding a specific commit. In the event that a commit is fingered in a bisect, you have a much better list of names to Cc, instead of just the maintainer from MAINTAINERS and the author from the top of the offending file. The author has often moved on, and the maintainer may not have been around for the bugfix. As I understand it, having been in the room when these tags were developed and encouraged, was that credit was a big part of the initial motivation. We need more testers and bug reporters; this was a way to give them credit for the valuable work that they do. I still think that's important, for whatever that's worth. I know Greg has spoken out against gamification before, and I also understand the desire to encourage bug reporters. Perhaps I should just suggest the following: The Reported-by tag helps us maintain contact info for people with intimate knowledge of a commit or a bug fix. Please seek the reporter's permission before adding the tag to the commit. That said, if we diligently credit our bug reporters, they will, hopefully, be inspired to help us again in the future. That addresses my concern, but loses the point of the initial patch: publicly reporting a bug can be seen as implicit permission to credit the reporter. Thanks, jon ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[patch] Documentation/SubmittingPatches: Reported-by tags and permission
The reported-by text says you have to ask for permission, but that's only if the bug was reported in private. These days the standard is to always give reported-by credit or it's considered a bit rude. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 26b1e31d5a13..f72ce7803b71 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -432,12 +432,9 @@ have been included in the discussion 14) Using Reported-by:, Tested-by:, Reviewed-by: and Suggested-by: -If this patch fixes a problem reported by somebody else, consider adding a -Reported-by: tag to credit the reporter for their contribution. Please -note that this tag should not be added without the reporter's permission, -especially if the problem was not reported in a public forum. That said, -if we diligently credit our bug reporters, they will, hopefully, be -inspired to help us again in the future. +The Reported-by tag is to give credit to people who find bugs and report them. +Please note that if the bug was reported in private, then ask for permission +first before using the Reported-by tag. A Tested-by: tag indicates that the patch has been successfully tested (in some environment) by the person named. This tag informs maintainers that ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [patch] Documentation/SubmittingPatches: Reported-by tags and permission
On 02/14/2014 01:30 AM, Dan Carpenter wrote: The reported-by text says you have to ask for permission, but that's only if the bug was reported in private. These days the standard is to always give reported-by credit or it's considered a bit rude. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Randy Dunlap rdun...@infradead.org Thanks. diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 26b1e31d5a13..f72ce7803b71 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -432,12 +432,9 @@ have been included in the discussion 14) Using Reported-by:, Tested-by:, Reviewed-by: and Suggested-by: -If this patch fixes a problem reported by somebody else, consider adding a -Reported-by: tag to credit the reporter for their contribution. Please -note that this tag should not be added without the reporter's permission, -especially if the problem was not reported in a public forum. That said, -if we diligently credit our bug reporters, they will, hopefully, be -inspired to help us again in the future. +The Reported-by tag is to give credit to people who find bugs and report them. +Please note that if the bug was reported in private, then ask for permission +first before using the Reported-by tag. A Tested-by: tag indicates that the patch has been successfully tested (in some environment) by the person named. This tag informs maintainers that -- -- ~Randy ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
