Re: [PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)
On Thu, Oct 10, 2019 at 02:54:59PM +, Matt Sickler wrote:
> > static struct mtd_partition p2kr0_spi1_parts[] = {
> >- { .name = "SLOT_4", .size = 7798784,.offset = 0,
> > },
> >- { .name = "SLOT_5", .size = 7798784,.offset =
> >MTDPART_OFS_NXTBLK},
> >- { .name = "SLOT_6", .size = 7798784,.offset =
> >MTDPART_OFS_NXTBLK},
> >- { .name = "SLOT_7", .size = 7798784,.offset =
> >MTDPART_OFS_NXTBLK},
> >- { .name = "CS1_EXTRA", .size = MTDPART_SIZ_FULL, .offset =
> >MTDPART_OFS_NXTBLK},
> >+ { .name = "SLOT_4", .size = 7798784, .offset = 0,},
> >+ { .name = "SLOT_5", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> >+ { .name = "SLOT_6", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> >+ { .name = "SLOT_7", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> >+ { .name = "CS1_EXTRA", .size = MTDPART_SIZ_FULL, .offset =
> >MTDPART_OFS_NXTBLK},
> > };
> >
> > static struct flash_platform_data p2kr0_spi0_pdata = {
>
> Is the line length limit a hard rule or can exceptions be made? I
> really feel that these data tables are more easily read when they're
> formatted like tables...
Exceptions can be made. It's probably not worth it though because
you have to be really aggressive about shooting down patches. Ask
yourself if there aren't more important battles to fight when human
lifespans are so short? I already rejected one change for you. To me
the new table looks okay, though.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)
>-Original Message-
>From: devel On Behalf Of
>Chandra Annamaneni
>Sent: Wednesday, October 09, 2019 10:09 PM
>To: gre...@linuxfoundation.org
>Cc: de...@driverdev.osuosl.org; gneuk...@gmail.com; chandra...@gmail.com;
>fabian.krue...@fau.de; linux-
>ker...@vger.kernel.org; si...@nikanor.nu; dan.carpen...@oracle.com
>Subject: [PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)
>
>Resoved: "WARNING: line over 80 characters" from checkpatch.pl
>
>Signed-off-by: Chandra Annamaneni
>---
> drivers/staging/kpc2000/kpc2000_spi.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
>diff --git a/drivers/staging/kpc2000/kpc2000_spi.c
>b/drivers/staging/kpc2000/kpc2000_spi.c
>index 3be33c4..ef78b6d 100644
>--- a/drivers/staging/kpc2000/kpc2000_spi.c
>+++ b/drivers/staging/kpc2000/kpc2000_spi.c
>@@ -30,19 +30,19 @@
> #include "kpc.h"
>
> static struct mtd_partition p2kr0_spi0_parts[] = {
>- { .name = "SLOT_0", .size = 7798784,.offset = 0,
> },
>- { .name = "SLOT_1", .size = 7798784,.offset =
>MTDPART_OFS_NXTBLK},
>- { .name = "SLOT_2", .size = 7798784,.offset =
>MTDPART_OFS_NXTBLK},
>- { .name = "SLOT_3", .size = 7798784,.offset =
>MTDPART_OFS_NXTBLK},
>- { .name = "CS0_EXTRA", .size = MTDPART_SIZ_FULL, .offset =
>MTDPART_OFS_NXTBLK},
>+ { .name = "SLOT_0", .size = 7798784, .offset = 0,},
>+ { .name = "SLOT_1", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "SLOT_2", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "SLOT_3", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "CS0_EXTRA", .size = MTDPART_SIZ_FULL, .offset =
>MTDPART_OFS_NXTBLK},
> };
>
> static struct mtd_partition p2kr0_spi1_parts[] = {
>- { .name = "SLOT_4", .size = 7798784,.offset = 0,
> },
>- { .name = "SLOT_5", .size = 7798784,.offset =
>MTDPART_OFS_NXTBLK},
>- { .name = "SLOT_6", .size = 7798784,.offset =
>MTDPART_OFS_NXTBLK},
>- { .name = "SLOT_7", .size = 7798784,.offset =
>MTDPART_OFS_NXTBLK},
>- { .name = "CS1_EXTRA", .size = MTDPART_SIZ_FULL, .offset =
>MTDPART_OFS_NXTBLK},
>+ { .name = "SLOT_4", .size = 7798784, .offset = 0,},
>+ { .name = "SLOT_5", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "SLOT_6", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "SLOT_7", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
>+ { .name = "CS1_EXTRA", .size = MTDPART_SIZ_FULL, .offset =
>MTDPART_OFS_NXTBLK},
> };
>
> static struct flash_platform_data p2kr0_spi0_pdata = {
Is the line length limit a hard rule or can exceptions be made? I really feel
that these data tables are more easily read when they're formatted like
tables...
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)
On Wed, Oct 09, 2019 at 08:08:57PM -0700, Chandra Annamaneni wrote:
> Resoved: "WARNING: line over 80 characters" from checkpatch.pl
>
> Signed-off-by: Chandra Annamaneni
> ---
> drivers/staging/kpc2000/kpc2000_spi.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/kpc2000/kpc2000_spi.c
> b/drivers/staging/kpc2000/kpc2000_spi.c
> index 3be33c4..ef78b6d 100644
> --- a/drivers/staging/kpc2000/kpc2000_spi.c
> +++ b/drivers/staging/kpc2000/kpc2000_spi.c
> @@ -30,19 +30,19 @@
> #include "kpc.h"
>
> static struct mtd_partition p2kr0_spi0_parts[] = {
> - { .name = "SLOT_0", .size = 7798784,.offset = 0,
> },
> - { .name = "SLOT_1", .size = 7798784,.offset =
> MTDPART_OFS_NXTBLK},
> - { .name = "SLOT_2", .size = 7798784,.offset =
> MTDPART_OFS_NXTBLK},
> - { .name = "SLOT_3", .size = 7798784,.offset =
> MTDPART_OFS_NXTBLK},
> - { .name = "CS0_EXTRA", .size = MTDPART_SIZ_FULL, .offset =
> MTDPART_OFS_NXTBLK},
> + { .name = "SLOT_0", .size = 7798784, .offset = 0,},
> + { .name = "SLOT_1", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> + { .name = "SLOT_2", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> + { .name = "SLOT_3", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> + { .name = "CS0_EXTRA", .size = MTDPART_SIZ_FULL, .offset =
> MTDPART_OFS_NXTBLK},
> };
>
> static struct mtd_partition p2kr0_spi1_parts[] = {
> - { .name = "SLOT_4", .size = 7798784,.offset = 0,
> },
> - { .name = "SLOT_5", .size = 7798784,.offset =
> MTDPART_OFS_NXTBLK},
> - { .name = "SLOT_6", .size = 7798784,.offset =
> MTDPART_OFS_NXTBLK},
> - { .name = "SLOT_7", .size = 7798784,.offset =
> MTDPART_OFS_NXTBLK},
> - { .name = "CS1_EXTRA", .size = MTDPART_SIZ_FULL, .offset =
> MTDPART_OFS_NXTBLK},
> + { .name = "SLOT_4", .size = 7798784, .offset = 0,},
> + { .name = "SLOT_5", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> + { .name = "SLOT_6", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> + { .name = "SLOT_7", .size = 7798784, .offset = MTDPART_OFS_NXTBLK},
> + { .name = "CS1_EXTRA", .size = MTDPART_SIZ_FULL, .offset =
> MTDPART_OFS_NXTBLK},
> };
>
> static struct flash_platform_data p2kr0_spi0_pdata = {
> --
> 2.7.4
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You sent multiple patches, yet no indication of which ones should be
applied in which order. Greg could just guess, but if you are
receiving this email, he guessed wrong and the patches didn't apply.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for a description of how
to do this so that Greg has a chance to apply these correctly.
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what is needed in order to
properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what a proper Subject: line should
look like.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
