Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch
On Thu, 20 Sep 2018 17:06:59 + Haiyang Zhang wrote: > +static inline void rsc_add_data > + (struct netvsc_channel *nvchan, > + const struct ndis_pkt_8021q_info *vlan, > + const struct ndis_tcp_ip_checksum_info *csum_info, > + void *data, u32 len) > +{ Could this be changed to look more like a function and skip the inline. The compiler will end up inlining it anyway. static void rsc_add_data(struct netvsc_channel *nvchan, ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, September 20, 2018 4:48 PM > To: Haiyang Zhang > Cc: Haiyang Zhang ; da...@davemloft.net; > net...@vger.kernel.org; o...@aepfle.de; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; vkuznets > Subject: Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the > vSwitch > > On Thu, 20 Sep 2018 17:06:59 + > Haiyang Zhang wrote: > > > +static inline void rsc_add_data > > + (struct netvsc_channel *nvchan, > > +const struct ndis_pkt_8021q_info *vlan, > > +const struct ndis_tcp_ip_checksum_info *csum_info, > > +void *data, u32 len) > > +{ > > Could this be changed to look more like a function and skip the inline. > The compiler will end up inlining it anyway. > > static void rsc_add_data(struct netvsc_channel *nvchan, How about this? static inline void rsc_add_data(struct netvsc_channel *nvchan, ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch
On Thu, 20 Sep 2018 20:56:46 + Haiyang Zhang wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Thursday, September 20, 2018 4:48 PM > > To: Haiyang Zhang > > Cc: Haiyang Zhang ; da...@davemloft.net; > > net...@vger.kernel.org; o...@aepfle.de; linux-ker...@vger.kernel.org; > > de...@linuxdriverproject.org; vkuznets > > Subject: Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the > > vSwitch > > > > On Thu, 20 Sep 2018 17:06:59 + > > Haiyang Zhang wrote: > > > > > +static inline void rsc_add_data > > > + (struct netvsc_channel *nvchan, > > > + const struct ndis_pkt_8021q_info *vlan, > > > + const struct ndis_tcp_ip_checksum_info *csum_info, > > > + void *data, u32 len) > > > +{ > > > > Could this be changed to look more like a function and skip the inline. > > The compiler will end up inlining it anyway. > > > > static void rsc_add_data(struct netvsc_channel *nvchan, > > How about this? > static inline > void rsc_add_data(struct netvsc_channel *nvchan, > Sure that matches other code in that file ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel