RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

2016-10-19 Thread Sell, Timothy C 
> -Original Message-
> From: Kershner, David A
> Sent: Wednesday, October 19, 2016 8:04 PM
> To: Cathal Mullaney <chuckleberryf...@gmail.com>

> Subject: RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor
> locking code to be statically deterministic.
> 
> > -Original Message-
> > From: Cathal Mullaney [mailto:chuckleberryf...@gmail.com]
> > Subject: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor 
> > locking
> > code to be statically deterministic.
> >
> > This patch makes locking in visorchannel_signalempty statically
> > deterministic.
> > As a result this patch fixes the sparse warning:
> > Context imbalance in 'visorchannel_signalempty' - different lock
> > contexts for basic block.
> >
> > The logic of the locking code doesn't change but the layout of the
> > original code is "frowned upon"
> > according to mails on sparse context checking.
> > Refactoring removes the warning and makes the code more readable.
> >
> > Signed-off-by: Cathal Mullaney <chuckleberryf...@gmail.com>
> 
> Tested-by: David Kershner <david.kersh...@unisys.com>
> 
> > ---
> > V2: Removed unnecessary variable initialization, as suggested by Tim Sell
> > <timothy.s...@unisys.com>.
> >
> >  drivers/staging/unisys/visorbus/visorchannel.c | 30 --
> --
> > --

Thanks for the quick turnaround, folks.
v2 looks great to me.

- Tim Sell
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

2016-10-19 Thread Kershner, David A 
> -Original Message-
> From: Cathal Mullaney [mailto:chuckleberryf...@gmail.com]
> Subject: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking
> code to be statically deterministic.
> 
> This patch makes locking in visorchannel_signalempty statically
> deterministic.
> As a result this patch fixes the sparse warning:
> Context imbalance in 'visorchannel_signalempty' - different lock
> contexts for basic block.
> 
> The logic of the locking code doesn't change but the layout of the
> original code is "frowned upon"
> according to mails on sparse context checking.
> Refactoring removes the warning and makes the code more readable.
> 
> Signed-off-by: Cathal Mullaney 

Tested-by: David Kershner 

> ---
> V2: Removed unnecessary variable initialization, as suggested by Tim Sell
> .
> 
>  drivers/staging/unisys/visorbus/visorchannel.c | 30 
> --

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel