Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar
No signed-off line. Just merge both patches since they do the same thing and go to the same maintainers. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar
On Mon, Jan 13, 2014 at 09:02:33AM +, Joe Borġ wrote: > Apologies for missing that. > > Feel free to add signed-off-by Joe Borg to the > commit message. > Unless it's a bugfix for a security issue then we don't fix other people's patches. You have to resend. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar
On Mon, Jan 13, 2014 at 08:14:46PM +, Joe Borg wrote: > Signed-off-by Joe Borg You need a changelog comment here, please. And is that your "real" email address and name? greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar
On Mon, Jan 13, 2014 at 09:23:11PM +, Joe Borġ wrote: > Ok, will do the change log. > > Yes, it's my real name and email... I know the email address is embarrassing, > but genuine :). > > > > Regards, > Joseph David Borġ There's nothing wrong with using "Joe Borġ" as your signed-off-by: line, as that's your real name :) thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar
On Mon, Jan 13, 2014 at 09:47:59PM +, Joe Borg wrote: > Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo *bar' in > the parameters of function munge_data(). Please wrap your changelog comments at 72 colums, like git asks you to when you type them in. > Signed-off-by Joe Borg No "ġ"? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar
On Mon, Jan 13, 2014 at 11:19:15PM +, Joe Borg wrote: > Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo > *bar' in the parameters of function munge_data(). Ok, real minor nits here, but I'd like you to make them for future patches as it makes my life easier, and I don't like to edit patches by hand, as I don't scale very well. Your subject should be: [PATCH] staging: comedi: das1800: fix for * bar to be foo *bar you need to add the driver subsystem, and specific area and driver. And no kernel drivers are ALL CAPS, so that should never be used. I've taken this patch as-is, but in the future please try to do this. Oh, one more thing: > Signed-off-by Joe Borg You forgot a ':' here :) thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
