Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

[Ian Abbott]

On 16/03/2018 10:48, Pratik Jain wrote:

Fixed coding style issue.

Signed-off-by: Pratik Jain 
---
  drivers/staging/comedi/drivers/ni_atmio.c | 9 +
  1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_atmio.c 
b/drivers/staging/comedi/drivers/ni_atmio.c
index b9e9ab548c4b..2b7bfe0dd7f3 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -224,10 +224,11 @@ static int ni_isapnp_find_board(struct pnp_dev **dev)
int i;
  
  	for (i = 0; i < ARRAY_SIZE(ni_boards); i++) {

-   isapnp_dev = pnp_find_dev(NULL,
- ISAPNP_VENDOR('N', 'I', 'C'),
- ISAPNP_FUNCTION(ni_boards[i].
- isapnp_id), NULL);
+   isapnp_dev =
+   pnp_find_dev(NULL,
+ISAPNP_VENDOR('N', 'I', 'C'),
+ISAPNP_FUNCTION(ni_boards[i].isapnp_id),
+NULL);
  
  		if (!isapnp_dev || !isapnp_dev->card)

continue;



Looks good, thanks!

Reviewed-by: Ian Abbott 

--
-=( Ian Abbott @ MEV Ltd.E-mail:  )=-
-=(  Web: http://www.mev.co.uk/  )=-
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

[Dan Carpenter]

On Fri, Mar 16, 2018 at 03:59:31PM +0530, Pratik Jain wrote:
> Yes that can be done. But isn't 80 column limit more of a
> historical convention?
> 

No.  It's not.  We're not super strict about it but it's still a rule we
apply unless it hurts readability.

regards,
dan carpenter


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

[Pratik Jain]

Yes that can be done. But isn't 80 column limit more of a
historical convention?

On Fri, Mar 16, 2018 at 10:17:28AM +, Ian Abbott wrote:
> On 15/03/2018 18:59, Pratik Jain wrote:
> > Fixed coding style issue.
> > 
> > Signed-off-by: Pratik Jain 
> > ---
> >   drivers/staging/comedi/drivers/ni_atmio.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/comedi/drivers/ni_atmio.c 
> > b/drivers/staging/comedi/drivers/ni_atmio.c
> > index b9e9ab548c4b..4e27a2959b64 100644
> > --- a/drivers/staging/comedi/drivers/ni_atmio.c
> > +++ b/drivers/staging/comedi/drivers/ni_atmio.c
> > @@ -226,8 +226,8 @@ static int ni_isapnp_find_board(struct pnp_dev **dev)
> > for (i = 0; i < ARRAY_SIZE(ni_boards); i++) {
> > isapnp_dev = pnp_find_dev(NULL,
> >   ISAPNP_VENDOR('N', 'I', 'C'),
> > - ISAPNP_FUNCTION(ni_boards[i].
> > - isapnp_id), NULL);
> > + 
> > ISAPNP_FUNCTION(ni_boards[i].isapnp_id),
> > + NULL);
> > if (!isapnp_dev || !isapnp_dev->card)
> > continue;
> > 
> 
> I suggest splitting the expression just after the '=' to avoid going over 80
> columns.
> 
> -- 
> -=( Ian Abbott @ MEV Ltd.E-mail:  )=-
> -=(  Web: http://www.mev.co.uk/  )=-
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

[Dan Carpenter]

On Fri, Mar 16, 2018 at 01:19:12AM +0530, Pratik Jain wrote:
> Resending the email because it was sent only to Greg.
> 
> Context:
> In my previous patch, I had removed an extra newline
> at the end of the code.
> 
> My Reply:
> It was unintentional, but does it violate any coding or
> other standard?
> 

No, but don't do random unrelated changes.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

[Pratik Jain]

Resending the email because it was sent only to Greg.

Context:
In my previous patch, I had removed an extra newline
at the end of the code.

My Reply:
It was unintentional, but does it violate any coding or
other standard?




___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

[Greg KH]

On Thu, Mar 15, 2018 at 11:00:40PM +0530, Pratik Jain wrote:
> Fixed coding style issue.
> 
> Signed-off-by: Pratik Jain 
> ---
>  drivers/staging/comedi/drivers/ni_atmio.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c 
> b/drivers/staging/comedi/drivers/ni_atmio.c
> index b9e9ab548c4b..e82fbe987dd8 100644
> --- a/drivers/staging/comedi/drivers/ni_atmio.c
> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
> @@ -226,8 +226,8 @@ static int ni_isapnp_find_board(struct pnp_dev **dev)
>   for (i = 0; i < ARRAY_SIZE(ni_boards); i++) {
>   isapnp_dev = pnp_find_dev(NULL,
> ISAPNP_VENDOR('N', 'I', 'C'),
> -   ISAPNP_FUNCTION(ni_boards[i].
> -   isapnp_id), NULL);
> +   
> ISAPNP_FUNCTION(ni_boards[i].isapnp_id),
> +   NULL);
>  
>   if (!isapnp_dev || !isapnp_dev->card)
>   continue;
> @@ -356,4 +356,3 @@ module_comedi_driver(ni_atmio_driver);
>  MODULE_AUTHOR("Comedi http://www.comedi.org;);
>  MODULE_DESCRIPTION("Comedi low-level driver");
>  MODULE_LICENSE("GPL");
> -

Why did you also delete this last line?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel