Re: [PATCH] Staging: comedi: replace printk() calls with dev_dbg() in pcmmio.c

[Greg KH]

On Fri, Dec 27, 2013 at 06:07:21PM -0600, Chase Southwood wrote:
 From: Chase Southwood csou...@illinois.edu
 
 Changed several printk() calls to dev_dbg() or dev_err() in pcmmio.c to fix 
 checkpatch.pl warnings.  Patched from 3.13-rc5.

Please line-wrap your changelog entries.

Also, this is already fixed up in my tree, please always work against
linux-next, what is in Linus's tree is pretty old for staging stuff.

Care to redo this against linux-next and resend it?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: comedi: replace printk() calls with dev_dbg() in pcmmio.c

[Dan Carpenter]

On Sat, Dec 28, 2013 at 03:13:52AM -0600, Chase Southwood wrote:
 From: Chase Southwood chase.southw...@yahoo.com

We get this from your email.  It's not needed unless you are forwarding
a patch from someone else.

 
 This is a patch for pcmmio.c that changes several printk() calls to dev_dbg() 
 or dev_err() to fix checkpatch.pl warnings.  Patched from 3.13-rc5.

Line wrap the description at 72 characters.

Don't put Patched from 3.13-rc5. in the patch description because we
don't want it to be a part of the permanent change description.  Also
you should be doing these against linux-next anyway.

 
 Signed-off-by: Chase Southwood chase.southw...@yahoo.com
 ---
  drivers/staging/comedi/drivers/pcmmio.c | 23 +--
  1 file changed, 13 insertions(+), 10 deletions(-)
 
 diff --git a/drivers/staging/comedi/drivers/pcmmio.c 
 b/drivers/staging/comedi/drivers/pcmmio.c
 index 14cee3a..8a567c9 100644
 --- a/drivers/staging/comedi/drivers/pcmmio.c
 +++ b/drivers/staging/comedi/drivers/pcmmio.c
 @@ -252,7 +252,8 @@ static int pcmmio_dio_insn_bits(struct comedi_device *dev,
  
  #ifdef DAMMIT_ITS_BROKEN
   /* DEBUG */
 - printk(KERN_DEBUG write mask: %08x  data: %08x\n, data[0], data[1]);
 + dev_dbg(dev-class_dev, write mask: %08x  data: %08x\n,
 + data[0], data[1]);

Just delete everything to do with DAMMIT_ITS_BROKEN.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel