Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()
On May 29, 2017, at 10:28 AM, Greg Kroah-Hartman wrote: > On Fri, May 26, 2017 at 11:40:33PM -0400, Oleg Drokin wrote: >> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct >> lov_user_md pointer from user- or kernel-space. This changes the >> behavior of copy_from_user() on SPARC and may result in a misaligned >> access exception which in turn oopses the kernel. In fact the >> relevant argument to lov_getstripe() is never called with a >> kernel-space pointer and so changing the address limits is unnecessary >> and so we remove the calls to save, set, and restore the address >> limits. >> >> Signed-off-by: John L. Hammond >> Reviewed-on: http://review.whamcloud.com/6150 >> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221 >> Reviewed-by: Andreas Dilger >> Reviewed-by: Li Wei >> Signed-off-by: Oleg Drokin >> --- >> drivers/staging/lustre/lustre/lov/lov_pack.c | 9 - >> 1 file changed, 9 deletions(-) > > So is this the patch that you want applied to the staging tree(s) as > well? If so, please let me know, otherwise I have no clue… Yes, this is it. Thanks! ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()
On Fri, May 26, 2017 at 11:40:33PM -0400, Oleg Drokin wrote: > lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct > lov_user_md pointer from user- or kernel-space. This changes the > behavior of copy_from_user() on SPARC and may result in a misaligned > access exception which in turn oopses the kernel. In fact the > relevant argument to lov_getstripe() is never called with a > kernel-space pointer and so changing the address limits is unnecessary > and so we remove the calls to save, set, and restore the address > limits. > > Signed-off-by: John L. Hammond > Reviewed-on: http://review.whamcloud.com/6150 > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221 > Reviewed-by: Andreas Dilger > Reviewed-by: Li Wei > Signed-off-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/lov/lov_pack.c | 9 - > 1 file changed, 9 deletions(-) So is this the patch that you want applied to the staging tree(s) as well? If so, please let me know, otherwise I have no clue... Come on, you know better than this... greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
