Re: [PATCH 3/3] Drivers: hv: utils: Support TimeSync version 4.0 protocol samples.

2016-09-14 Thread Olaf Hering 
On Tue, Sep 13, Alex Ng (LIS) wrote:

> > On Thu, Sep 08, k...@exchange.microsoft.com wrote:
> > Perhaps a better approach would be to list the known existing hosts and use
> > the new protocol for upcoming, unknown hosts via 'default:'.
> This is a good idea. I will create another patch that addresses this.

I think this variant would cover upcoming hosts for an old kernel:

switch (vmbus_proto_version) {
case VERSION_WS2008:
util_fw_version = UTIL_WS2K8_FW_VERSION;
sd_srv_version = SD_VERSION_1;
ts_srv_version = TS_VERSION_1;
hb_srv_version = HB_VERSION_1;
break;
case VERSION_WIN7:
case VERSION_WIN8:
case VERSION_WIN8_1:
util_fw_version = UTIL_FW_VERSION;
sd_srv_version = SD_VERSION;
ts_srv_version = TS_VERSION_3;
hb_srv_version = HB_VERSION;
break;
case VERSION_WIN10:
default:
util_fw_version = UTIL_FW_VERSION;
sd_srv_version = SD_VERSION;
ts_srv_version = TS_VERSION;
hb_srv_version = HB_VERSION;
break;
}

Olaf


signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH 3/3] Drivers: hv: utils: Support TimeSync version 4.0 protocol samples.

2016-09-13 Thread Alex Ng (LIS) 
> On Thu, Sep 08, k...@exchange.microsoft.com wrote:
> 
> > -   default:
> > +   case(VERSION_WIN10):
> > util_fw_version = UTIL_FW_VERSION;
> > sd_srv_version = SD_VERSION;
> > ts_srv_version = TS_VERSION;
> > hb_srv_version = HB_VERSION;
> > +   break;
> > +   default:
> > +   util_fw_version = UTIL_FW_VERSION;
> > +   sd_srv_version = SD_VERSION;
> > +   ts_srv_version = TS_VERSION_3;
> > +   hb_srv_version = HB_VERSION;
> 
> Is this correct? An old kernel on a newer host would use the old protocol. I
> assume that new host will also know about the old protocol?

This is correct. An old kernel uses the old protocol even with the new host.
New hosts understand the old protocol.

> Perhaps a better approach would be to list the known existing hosts and use
> the new protocol for upcoming, unknown hosts via 'default:'.

This is a good idea. I will create another patch that addresses this.

> 
> Olaf
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/3] Drivers: hv: utils: Support TimeSync version 4.0 protocol samples.

2016-09-13 Thread Olaf Hering 
On Thu, Sep 08, k...@exchange.microsoft.com wrote:

> - default:
> + case(VERSION_WIN10):
>   util_fw_version = UTIL_FW_VERSION;
>   sd_srv_version = SD_VERSION;
>   ts_srv_version = TS_VERSION;
>   hb_srv_version = HB_VERSION;
> + break;
> + default:
> + util_fw_version = UTIL_FW_VERSION;
> + sd_srv_version = SD_VERSION;
> + ts_srv_version = TS_VERSION_3;
> + hb_srv_version = HB_VERSION;

Is this correct? An old kernel on a newer host would use the old
protocol. I assume that new host will also know about the old protocol?
Perhaps a better approach would be to list the known existing hosts and
use the new protocol for upcoming, unknown hosts via 'default:'.

Olaf


signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel