Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters
Ian and Hartley, Thanks so much, I greatly appreciate the review. I'll fix the changelog for patch 4 and send once more (as I assume that's easier for Greg). Also, I should know better about the cover letter as well...I was once told not to send them for strictly cleanup patchsets (as Greg can't do anything with them and cleanups should be obvious) but I've gotten in the habit of not doing a cover letter for any patchsets. I will send cover letters (and be more careful about my other mistakes) in the future. Thanks, Chase On Tue, Apr 29, 2014 at 3:33 PM, Hartley Sweeten hartl...@visionengravers.com wrote: On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote: This driver no longer reads the eeprom to find the board specific data, all the necessary data is in the boardinfo. Use the boardinfo directly instead of passing through devpriv-s_EeParameters. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- 2: Incorrect patch title fixed. Ian and Hartley, The auto_attach() function is starting to look much better now. My next patchset will be geared towards only allocating subdevices which are actually used. Other than Ian's comment on patch 4/6 everything looks good to me. For the series: Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com BTW, for a patch series you should include a cover letter (PATCH 00/xx). Regards, Hartley ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters
On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote: Thanks so much, I greatly appreciate the review. I'll fix the changelog for patch 4 and send once more (as I assume that's easier for Greg). Also, I should know better about the cover letter as well...I was once told not to send them for strictly cleanup patchsets (as Greg can't do anything with them and cleanups should be obvious) but I've gotten in the habit of not doing a cover letter for any patchsets. I will send cover letters (and be more careful about my other mistakes) in the future. Chase, Good job on the cleanup you have done so far. The cover letter does not get committed as part of the patch set. But when you are submitting a series it give a convenient place to add the sign off tag for a series. Also, if you would have done a cover letter for this series you would have probably spotted the subject line issues in patches 5 and 6. Keep up the good work! Hartley ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters
Hartley, Yes, you raise very good points. In any case, I have added cover letters to my submitting checklist so hopefully everything will be a lot easier for everyone next go round. Thanks, Chase On Wed, Apr 30, 2014 at 11:58 AM, Hartley Sweeten hartl...@visionengravers.com wrote: On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote: Thanks so much, I greatly appreciate the review. I'll fix the changelog for patch 4 and send once more (as I assume that's easier for Greg). Also, I should know better about the cover letter as well...I was once told not to send them for strictly cleanup patchsets (as Greg can't do anything with them and cleanups should be obvious) but I've gotten in the habit of not doing a cover letter for any patchsets. I will send cover letters (and be more careful about my other mistakes) in the future. Chase, Good job on the cleanup you have done so far. The cover letter does not get committed as part of the patch set. But when you are submitting a series it give a convenient place to add the sign off tag for a series. Also, if you would have done a cover letter for this series you would have probably spotted the subject line issues in patches 5 and 6. Keep up the good work! Hartley ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters
On 2014-04-29 09:38, Chase Southwood wrote: This driver no longer reads the eeprom to find the board specific data, all the necessary data is in the boardinfo. Use the boardinfo directly instead of passing through devpriv-s_EeParameters. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- 2: Incorrect patch title fixed. Ian and Hartley, The auto_attach() function is starting to look much better now. My next patchset will be geared towards only allocating subdevices which are actually used. Great! All looking good except the description of PATCH 4/6 v2. Revie -- -=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv-s_EeParameters
On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote: This driver no longer reads the eeprom to find the board specific data, all the necessary data is in the boardinfo. Use the boardinfo directly instead of passing through devpriv-s_EeParameters. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk Cc: H Hartley Sweeten hswee...@visionengravers.com --- 2: Incorrect patch title fixed. Ian and Hartley, The auto_attach() function is starting to look much better now. My next patchset will be geared towards only allocating subdevices which are actually used. Other than Ian's comment on patch 4/6 everything looks good to me. For the series: Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com BTW, for a patch series you should include a cover letter (PATCH 00/xx). Regards, Hartley ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
