Re: [PATCH 8/8] staging: fsl-mc: Convert documentation to rst format

[Greg KH]

On Tue, Jan 16, 2018 at 03:40:18PM +, Ruxandra Ioana Ciocoi Radulescu wrote:
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Tuesday, January 16, 2018 5:14 PM
> > To: Bogdan Purcareata <bogdan.purcare...@nxp.com>
> > Cc: Laurentiu Tudor <laurentiu.tu...@nxp.com>; Ruxandra Ioana Ciocoi
> > Radulescu <ruxandra.radule...@nxp.com>; de...@driverdev.osuosl.org;
> > r...@kernel.org; stuyo...@gmail.com; a...@arndb.de;
> > marc.zyng...@arm.com; Roy Pledge <roy.ple...@nxp.com>; Ioana Ciornei
> > <ioana.cior...@nxp.com>; linux-ker...@vger.kernel.org; Horia Geantă
> > <horia.gea...@nxp.com>; Nipun Gupta <nipun.gu...@nxp.com>;
> > t...@linutronix.de; linux-arm-ker...@lists.infradead.org;
> > ja...@lakedaemon.net
> > Subject: Re: [PATCH 8/8] staging: fsl-mc: Convert documentation to rst
> > format
> > 
> > On Tue, Jan 16, 2018 at 03:19:10PM +0200, Bogdan Purcareata wrote:
> > > From: Ioana Radulescu <ruxandra.radule...@nxp.com>
> > >
> > > Update the doc file to comply with the rst format.
> > >
> > > It's not integrated into the documentation build structure yet,
> > > since it's still located in drivers/staging.
> > >
> > > Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
> > > Reviewed-by: Laurentiu Tudor <laurentiu.tu...@nxp.com>
> > > ---
> > >  drivers/staging/fsl-mc/README.txt   | 387 
> > > --
> > >  drivers/staging/fsl-mc/overview.rst | 404
> > 
> > >  2 files changed, 404 insertions(+), 387 deletions(-)
> > >  delete mode 100644 drivers/staging/fsl-mc/README.txt
> > >  create mode 100644 drivers/staging/fsl-mc/overview.rst
> > 
> > Please generate patches with the -M option to git format-patch, so we
> > can see the file move, not just get removed and added as a brand new
> > one.
> 
> Sure, I can do this.
> 
> Even with -M, the diff is rather large since the indenting changes for most
> of the lines in the file. Would it be better to make two patches, with
> the first changing just line indenting and the second one, where the file is
> moved, only updating rst specific markups?

Nah, just use -M and we can take it from there.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH 8/8] staging: fsl-mc: Convert documentation to rst format

[Ruxandra Ioana Ciocoi Radulescu]

> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, January 16, 2018 5:14 PM
> To: Bogdan Purcareata <bogdan.purcare...@nxp.com>
> Cc: Laurentiu Tudor <laurentiu.tu...@nxp.com>; Ruxandra Ioana Ciocoi
> Radulescu <ruxandra.radule...@nxp.com>; de...@driverdev.osuosl.org;
> r...@kernel.org; stuyo...@gmail.com; a...@arndb.de;
> marc.zyng...@arm.com; Roy Pledge <roy.ple...@nxp.com>; Ioana Ciornei
> <ioana.cior...@nxp.com>; linux-ker...@vger.kernel.org; Horia Geantă
> <horia.gea...@nxp.com>; Nipun Gupta <nipun.gu...@nxp.com>;
> t...@linutronix.de; linux-arm-ker...@lists.infradead.org;
> ja...@lakedaemon.net
> Subject: Re: [PATCH 8/8] staging: fsl-mc: Convert documentation to rst
> format
> 
> On Tue, Jan 16, 2018 at 03:19:10PM +0200, Bogdan Purcareata wrote:
> > From: Ioana Radulescu <ruxandra.radule...@nxp.com>
> >
> > Update the doc file to comply with the rst format.
> >
> > It's not integrated into the documentation build structure yet,
> > since it's still located in drivers/staging.
> >
> > Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
> > Reviewed-by: Laurentiu Tudor <laurentiu.tu...@nxp.com>
> > ---
> >  drivers/staging/fsl-mc/README.txt   | 387 
> > --
> >  drivers/staging/fsl-mc/overview.rst | 404
> 
> >  2 files changed, 404 insertions(+), 387 deletions(-)
> >  delete mode 100644 drivers/staging/fsl-mc/README.txt
> >  create mode 100644 drivers/staging/fsl-mc/overview.rst
> 
> Please generate patches with the -M option to git format-patch, so we
> can see the file move, not just get removed and added as a brand new
> one.

Sure, I can do this.

Even with -M, the diff is rather large since the indenting changes for most
of the lines in the file. Would it be better to make two patches, with
the first changing just line indenting and the second one, where the file is
moved, only updating rst specific markups?

Thanks,
Ioana
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 8/8] staging: fsl-mc: Convert documentation to rst format

[Greg KH]

On Tue, Jan 16, 2018 at 03:19:10PM +0200, Bogdan Purcareata wrote:
> From: Ioana Radulescu 
> 
> Update the doc file to comply with the rst format.
> 
> It's not integrated into the documentation build structure yet,
> since it's still located in drivers/staging.
> 
> Signed-off-by: Ioana Radulescu 
> Reviewed-by: Laurentiu Tudor 
> ---
>  drivers/staging/fsl-mc/README.txt   | 387 --
>  drivers/staging/fsl-mc/overview.rst | 404 
> 
>  2 files changed, 404 insertions(+), 387 deletions(-)
>  delete mode 100644 drivers/staging/fsl-mc/README.txt
>  create mode 100644 drivers/staging/fsl-mc/overview.rst

Please generate patches with the -M option to git format-patch, so we
can see the file move, not just get removed and added as a brand new
one.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel