Re: [PATCH 8/8] staging: rtl8192e: rename macro arguments to avoid camel case - style

2019-02-13 Thread Himadri Pandya 



On 13/02/19 2:36 PM, Greg KH wrote:

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top


Apologies for top-posting and thank you for the references to understand 
why it should be avoided.


- Himadri


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 8/8] staging: rtl8192e: rename macro arguments to avoid camel case - style

2019-02-13 Thread Greg KH 
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Wed, Feb 13, 2019 at 01:21:41AM +0530, Himadri Pandya wrote:
> I guess this patch has not been reviewed yet. Please let me know if it needs
> revision.

Please rebase and resend, odds are I could not take it because of other
patches in your series not being applied.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 8/8] staging: rtl8192e: rename macro arguments to avoid camel case - style

2019-02-12 Thread Himadri Pandya 
I guess this patch has not been reviewed yet. Please let me know if it 
needs revision.


Thank you.

- Himadri

On 10/02/19 2:13 PM, Himadri Pandya wrote:

Rename following macro arguments to fix checkpatch warning: Avoid
Camelcase and make the arguments more readable, understandable.
__pIeeeDev -> __ieee_dev
__pTa -> __address

Signed-off-by: Himadri Pandya 
---
  drivers/staging/rtl8192e/dot11d.h | 30 +++---
  1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/rtl8192e/dot11d.h 
b/drivers/staging/rtl8192e/dot11d.h
index cbf6337193d6..0637de1cca47 100644
--- a/drivers/staging/rtl8192e/dot11d.h
+++ b/drivers/staging/rtl8192e/dot11d.h
@@ -58,28 +58,28 @@ static inline void copy_mac_addr(unsigned char *des, 
unsigned char *src)
memcpy(des, src, 6);
  }
  
-#define GET_DOT11D_INFO(__pIeeeDev)			\

-((struct rt_dot11d_info *)((__pIeeeDev)->dot11d_info))
+#define GET_DOT11D_INFO(__ieee_dev)\
+((struct rt_dot11d_info *)((__ieee_dev)->dot11d_info))
  
-#define IS_DOT11D_ENABLE(__pIeeeDev)			\

-(GET_DOT11D_INFO(__pIeeeDev)->enabled)
-#define IS_COUNTRY_IE_VALID(__pIeeeDev)\
-   (GET_DOT11D_INFO(__pIeeeDev)->country_len > 0)
+#define IS_DOT11D_ENABLE(__ieee_dev)   \
+(GET_DOT11D_INFO(__ieee_dev)->enabled)
+#define IS_COUNTRY_IE_VALID(__ieee_dev)\
+   (GET_DOT11D_INFO(__ieee_dev)->country_len > 0)
  
-#define IS_EQUAL_CIE_SRC(__pIeeeDev, __pTa)		\

+#define IS_EQUAL_CIE_SRC(__ieee_dev, __address)\
 ether_addr_equal_unaligned( \
-   GET_DOT11D_INFO(__pIeeeDev)->country_src_addr, __pTa)
-#define UPDATE_CIE_SRC(__pIeeeDev, __pTa)  \
-   copy_mac_addr(GET_DOT11D_INFO(__pIeeeDev)->country_src_addr, __pTa)
+   GET_DOT11D_INFO(__ieee_dev)->country_src_addr, __address)
+#define UPDATE_CIE_SRC(__ieee_dev, __address)  \
+   copy_mac_addr(GET_DOT11D_INFO(__ieee_dev)->country_src_addr, __address)
  
-#define GET_CIE_WATCHDOG(__pIeeeDev)\

-(GET_DOT11D_INFO(__pIeeeDev)->country_watchdog)
-static inline void RESET_CIE_WATCHDOG(struct rtllib_device *__pIeeeDev)
+#define GET_CIE_WATCHDOG(__ieee_dev)   \
+(GET_DOT11D_INFO(__ieee_dev)->country_watchdog)
+static inline void RESET_CIE_WATCHDOG(struct rtllib_device *__ieee_dev)
  {
-   GET_CIE_WATCHDOG(__pIeeeDev) = 0;
+   GET_CIE_WATCHDOG(__ieee_dev) = 0;
  }
  
-#define UPDATE_CIE_WATCHDOG(__pIeeeDev) (++GET_CIE_WATCHDOG(__pIeeeDev))

+#define UPDATE_CIE_WATCHDOG(__ieee_dev) (++GET_CIE_WATCHDOG(__ieee_dev))
  
  void dot11d_init(struct rtllib_device *dev);

  void dot11d_channel_map(u8 channel_plan, struct rtllib_device *ieee);

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel