Re: [PATCH RFC v2 3/8] component: add support for component match array
Hi Russell,
On Tue, Jun 24, 2014 at 9:29 PM, Russell King
wrote:
[...]
> +/*
> + * Add a component to be matched.
> + *
> + * The match array is first created or extended if necessary.
> + */
> +void component_match_add(struct device *dev, struct component_match
> **matchptr,
> + int (*compare)(struct device *, void *), void *compare_data)
> +{
> + struct component_match *match = *matchptr;
> +
> + if (IS_ERR(match))
> + return;
> +
> + if (!match || match->num == match->alloc) {
> + size_t new_size = match ? match->alloc + 16 : 15;
> +
> + match = component_match_realloc(dev, match, new_size);
> +
> + *matchptr = match;
> +
> + if (IS_ERR(match))
> + return;
> + }
> +
> + match->compare[match->num].fn = compare;
> + match->compare[match->num].data = compare_data;
> + match->num++;
> +}
component_match_add should be exported.
regards
Philipp
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH RFC v2 3/8] component: add support for component match array
On Thu, Jun 26, 2014 at 02:34:17PM +0200, Philipp Zabel wrote:
> Hi Russell,
>
> On Tue, Jun 24, 2014 at 9:29 PM, Russell King
> wrote:
> [...]
> > +/*
> > + * Add a component to be matched.
> > + *
> > + * The match array is first created or extended if necessary.
> > + */
> > +void component_match_add(struct device *dev, struct component_match
> > **matchptr,
> > + int (*compare)(struct device *, void *), void *compare_data)
> > +{
> > + struct component_match *match = *matchptr;
> > +
> > + if (IS_ERR(match))
> > + return;
> > +
> > + if (!match || match->num == match->alloc) {
> > + size_t new_size = match ? match->alloc + 16 : 15;
> > +
> > + match = component_match_realloc(dev, match, new_size);
> > +
> > + *matchptr = match;
> > +
> > + if (IS_ERR(match))
> > + return;
> > + }
> > +
> > + match->compare[match->num].fn = compare;
> > + match->compare[match->num].data = compare_data;
> > + match->num++;
> > +}
>
> component_match_add should be exported.
Fixed, thanks.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH RFC v2 3/8] component: add support for component match array
On Thu, Jun 26, 2014 at 03:46:01PM +0100, Russell King - ARM Linux wrote:
> On Thu, Jun 26, 2014 at 02:34:17PM +0200, Philipp Zabel wrote:
> > Hi Russell,
> >
> > On Tue, Jun 24, 2014 at 9:29 PM, Russell King
> > wrote:
> > [...]
> > > +/*
> > > + * Add a component to be matched.
> > > + *
> > > + * The match array is first created or extended if necessary.
> > > + */
> > > +void component_match_add(struct device *dev, struct component_match
> > > **matchptr,
> > > + int (*compare)(struct device *, void *), void *compare_data)
> > > +{
> > > + struct component_match *match = *matchptr;
> > > +
> > > + if (IS_ERR(match))
> > > + return;
> > > +
> > > + if (!match || match->num == match->alloc) {
> > > + size_t new_size = match ? match->alloc + 16 : 15;
> > > +
> > > + match = component_match_realloc(dev, match, new_size);
> > > +
> > > + *matchptr = match;
> > > +
> > > + if (IS_ERR(match))
> > > + return;
> > > + }
> > > +
> > > + match->compare[match->num].fn = compare;
> > > + match->compare[match->num].data = compare_data;
> > > + match->num++;
> > > +}
> >
> > component_match_add should be exported.
>
> Fixed, thanks.
As there's no further comments, and Inki Dae has not responded, I'm
going to send these out without the RFC tag in the hope that people
will provide acks. This allows us to move forward with this despite
the Exynos DRM blockage.
The ultimate plan is for patches 1 to 3 inclusive to be merged into
Greg's driver tree, 1 to 3 and 5 into Greg's staging tree, and 1 to
3 and 4 for David Airlie's DRM tree - patches 1 to 3 are needed for
both patches 4 and 5.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH RFC v2 3/8] component: add support for component match array
2014-07-01 23:22 GMT+09:00 Russell King - ARM Linux :
> On Thu, Jun 26, 2014 at 03:46:01PM +0100, Russell King - ARM Linux wrote:
>> On Thu, Jun 26, 2014 at 02:34:17PM +0200, Philipp Zabel wrote:
>> > Hi Russell,
>> >
>> > On Tue, Jun 24, 2014 at 9:29 PM, Russell King
>> > wrote:
>> > [...]
>> > > +/*
>> > > + * Add a component to be matched.
>> > > + *
>> > > + * The match array is first created or extended if necessary.
>> > > + */
>> > > +void component_match_add(struct device *dev, struct component_match
>> > > **matchptr,
>> > > + int (*compare)(struct device *, void *), void *compare_data)
>> > > +{
>> > > + struct component_match *match = *matchptr;
>> > > +
>> > > + if (IS_ERR(match))
>> > > + return;
>> > > +
>> > > + if (!match || match->num == match->alloc) {
>> > > + size_t new_size = match ? match->alloc + 16 : 15;
>> > > +
>> > > + match = component_match_realloc(dev, match, new_size);
>> > > +
>> > > + *matchptr = match;
>> > > +
>> > > + if (IS_ERR(match))
>> > > + return;
>> > > + }
>> > > +
>> > > + match->compare[match->num].fn = compare;
>> > > + match->compare[match->num].data = compare_data;
>> > > + match->num++;
>> > > +}
>> >
>> > component_match_add should be exported.
>>
>> Fixed, thanks.
>
> As there's no further comments, and Inki Dae has not responded, I'm
It's has been just a week. I will check and look into your patch
series. I think Exynos drm should also be considered for the use of
component match array.
Thanks,
Inki Dae
> going to send these out without the RFC tag in the hope that people
> will provide acks. This allows us to move forward with this despite
> the Exynos DRM blockage.
>
> The ultimate plan is for patches 1 to 3 inclusive to be merged into
> Greg's driver tree, 1 to 3 and 5 into Greg's staging tree, and 1 to
> 3 and 4 for David Airlie's DRM tree - patches 1 to 3 are needed for
> both patches 4 and 5.
>
> --
> FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
> improving, and getting towards what was expected from it.
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH RFC v2 3/8] component: add support for component match array
On Thu, Jul 03, 2014 at 12:26:39AM +0900, Inki Dae wrote: > It's has been just a week. I will check and look into your patch > series. I think Exynos drm should also be considered for the use of > component match array. Actually, this series has been around for much longer than just a week. Your new usage introduced in the recent merge window is what has resulted in you becoming aware of this series. It was developed before April through discussions, and then shared with those people. Then, April 27th, it was posted publically to all the recipients except yourself (because Exynos hadn't visibly been converted). At that time, two reviewed-by tags were given. It was also sent out last week, with yourself added to the recepient list because there is now a dependency with some of your work. However, what I'm asking for is *not* the entire series to be merged at this point - that would break Exynos DRM. I'm asking for the first three to be merged initially by Greg, which gets the new interface in place without breaking existing users. We can then convert existing users at a slower rate, and remove the old interface once everyone has caught up. So, I'd ask that you give priority to looking at the first three patches and deciding whether you find them acceptable as a replacement interface, rather than trying to review the entire set of six core patches (1,2,3,6,7,8). What I'm trying to avoid here is for all these patches to be delayed past the next merge window, and pushed into the next cycle. That's likely to end up in the same scenario as exists with Exynos DRM today, only with other new users of the existing interface - and then have to repeat this whole "try to get the new users to review this set of changes" cycle again. We're half way through -rc3 right now. -final occurs anytime between -rc6 and -rc9, which could be just three and a half weeks away. I have other changes which I need to get out onto the list(s) which depend on this too (for DRM) which I'm hoping to also make this coming merge window, but I can't start that process until I know where I stand with these. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH RFC v2 3/8] component: add support for component match array
On Thu, Jul 03, 2014 at 12:26:39AM +0900, Inki Dae wrote:
> 2014-07-01 23:22 GMT+09:00 Russell King - ARM Linux :
> > On Thu, Jun 26, 2014 at 03:46:01PM +0100, Russell King - ARM Linux wrote:
> >> On Thu, Jun 26, 2014 at 02:34:17PM +0200, Philipp Zabel wrote:
> >> > Hi Russell,
> >> >
> >> > On Tue, Jun 24, 2014 at 9:29 PM, Russell King
> >> > wrote:
> >> > [...]
> >> > > +/*
> >> > > + * Add a component to be matched.
> >> > > + *
> >> > > + * The match array is first created or extended if necessary.
> >> > > + */
> >> > > +void component_match_add(struct device *dev, struct component_match
> >> > > **matchptr,
> >> > > + int (*compare)(struct device *, void *), void *compare_data)
> >> > > +{
> >> > > + struct component_match *match = *matchptr;
> >> > > +
> >> > > + if (IS_ERR(match))
> >> > > + return;
> >> > > +
> >> > > + if (!match || match->num == match->alloc) {
> >> > > + size_t new_size = match ? match->alloc + 16 : 15;
> >> > > +
> >> > > + match = component_match_realloc(dev, match, new_size);
> >> > > +
> >> > > + *matchptr = match;
> >> > > +
> >> > > + if (IS_ERR(match))
> >> > > + return;
> >> > > + }
> >> > > +
> >> > > + match->compare[match->num].fn = compare;
> >> > > + match->compare[match->num].data = compare_data;
> >> > > + match->num++;
> >> > > +}
> >> >
> >> > component_match_add should be exported.
> >>
> >> Fixed, thanks.
> >
> > As there's no further comments, and Inki Dae has not responded, I'm
>
> It's has been just a week. I will check and look into your patch
> series. I think Exynos drm should also be considered for the use of
> component match array.
It has now been almost two months. What's happening on this?
Please note that I'm planning to push the rest of the component updates
during the next merge window, which will result in unconverted drivers
breaking.
Thanks.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH RFC v2 3/8] component: add support for component match array
On 2014년 08월 31일 06:33, Russell King - ARM Linux wrote:
> On Thu, Jul 03, 2014 at 12:26:39AM +0900, Inki Dae wrote:
>> 2014-07-01 23:22 GMT+09:00 Russell King - ARM Linux :
>>> On Thu, Jun 26, 2014 at 03:46:01PM +0100, Russell King - ARM Linux wrote:
On Thu, Jun 26, 2014 at 02:34:17PM +0200, Philipp Zabel wrote:
> Hi Russell,
>
> On Tue, Jun 24, 2014 at 9:29 PM, Russell King
> wrote:
> [...]
>> +/*
>> + * Add a component to be matched.
>> + *
>> + * The match array is first created or extended if necessary.
>> + */
>> +void component_match_add(struct device *dev, struct component_match
>> **matchptr,
>> + int (*compare)(struct device *, void *), void *compare_data)
>> +{
>> + struct component_match *match = *matchptr;
>> +
>> + if (IS_ERR(match))
>> + return;
>> +
>> + if (!match || match->num == match->alloc) {
>> + size_t new_size = match ? match->alloc + 16 : 15;
>> +
>> + match = component_match_realloc(dev, match, new_size);
>> +
>> + *matchptr = match;
>> +
>> + if (IS_ERR(match))
>> + return;
>> + }
>> +
>> + match->compare[match->num].fn = compare;
>> + match->compare[match->num].data = compare_data;
>> + match->num++;
>> +}
>
> component_match_add should be exported.
Fixed, thanks.
>>>
>>> As there's no further comments, and Inki Dae has not responded, I'm
>>
>> It's has been just a week. I will check and look into your patch
>> series. I think Exynos drm should also be considered for the use of
>> component match array.
>
> It has now been almost two months. What's happening on this?
>
> Please note that I'm planning to push the rest of the component updates
> during the next merge window, which will result in unconverted drivers
> breaking.
>
Sorry for this. I was busy with other works. I will update and post it
until this week.
Thanks,
Inki Dae
> Thanks.
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
