Re: [PATCH v2] Staging: speakup: Insert blank lines after declarations in speakup_soft.c
On Mon, 11 Aug 2014, Greg KH wrote: On Sun, Aug 10, 2014 at 10:56:38PM +1000, Artemiy Volkov wrote: On Sat, 9 Aug 2014, Greg KH wrote: On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote: This patch fixes the checkpatch.pl 'Missing a blank line after declarations' warning in speakup_soft.c. Signed-off-by: Artemiy Volkov --- drivers/staging/speakup/speakup_soft.c | 3 +++ 1 file changed, 3 insertions(+) Can you refresh this against Linus's latest tree (or linux-next), it has a bunch of fuzz in it as it is. Hi, I'm sorry but I'm having a hard time understanding this -- since no changes have been made to this part of the tree (drivers/staging/speakup/) since Jul 17, the patch which I tried to generate against today's linux-next following your recommendation is identical to the sent v2. What might I be doing wrong here? I don't know, it didn't apply properly, which is odd. How about making it against Linus's tree right now, as it has all of my changes in it now, so we are synced up. After cloning Linus's tree and am-ing v2 on top of it, the result stands the same -- clean application... Could you have possibly already applied it, maybe? If not, I have little idea what to do from here, might as well drop the whole thing... Thanks, Artemiy ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] Staging: speakup: Insert blank lines after declarations in speakup_soft.c
On Sun, Aug 10, 2014 at 10:56:38PM +1000, Artemiy Volkov wrote: > > > On Sat, 9 Aug 2014, Greg KH wrote: > > >On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote: > >>This patch fixes the checkpatch.pl 'Missing a blank line after > >>declarations' warning in speakup_soft.c. > >> > >>Signed-off-by: Artemiy Volkov > >>--- > >> drivers/staging/speakup/speakup_soft.c | 3 +++ > >> 1 file changed, 3 insertions(+) > > > >Can you refresh this against Linus's latest tree (or linux-next), it has > >a bunch of fuzz in it as it is. > > Hi, > > I'm sorry but I'm having a hard time understanding this -- since no changes > have been made to this part of the tree (drivers/staging/speakup/) > since Jul 17, the patch which I tried to generate against today's linux-next > following your recommendation is identical to the sent v2. What might I be > doing wrong here? I don't know, it didn't apply properly, which is odd. How about making it against Linus's tree right now, as it has all of my changes in it now, so we are synced up. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] Staging: speakup: Insert blank lines after declarations in speakup_soft.c
On Sat, 9 Aug 2014, Greg KH wrote: On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote: This patch fixes the checkpatch.pl 'Missing a blank line after declarations' warning in speakup_soft.c. Signed-off-by: Artemiy Volkov --- drivers/staging/speakup/speakup_soft.c | 3 +++ 1 file changed, 3 insertions(+) Can you refresh this against Linus's latest tree (or linux-next), it has a bunch of fuzz in it as it is. Hi, I'm sorry but I'm having a hard time understanding this -- since no changes have been made to this part of the tree (drivers/staging/speakup/) since Jul 17, the patch which I tried to generate against today's linux-next following your recommendation is identical to the sent v2. What might I be doing wrong here? thanks, greg k-h Regards, Artemiy ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] Staging: speakup: Insert blank lines after declarations in speakup_soft.c
On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote: > This patch fixes the checkpatch.pl 'Missing a blank line after declarations' > warning in speakup_soft.c. > > Signed-off-by: Artemiy Volkov > --- > drivers/staging/speakup/speakup_soft.c | 3 +++ > 1 file changed, 3 insertions(+) Can you refresh this against Linus's latest tree (or linux-next), it has a bunch of fuzz in it as it is. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
