Re: [PATCH v2 1/2] dt-bindings: iio: adc: add adi,ad7780.yaml binding
On Fri, 14 Jun 2019 13:43:02 -0600 Rob Herring wrote: > On Fri, 24 May 2019 22:26:30 -0300, Renato Lui Geh wrote: > > This patch adds a YAML binding for the Analog Devices AD7780/1 and > > AD7170/1 analog-to-digital converters. > > > > Signed-off-by: Renato Lui Geh > > --- > > Changes in v2: > > - vref-supply to avdd-supply > > - remove avdd-supply from required list > > - include adc block in an spi block > > > > .../bindings/iio/adc/adi,ad7780.txt | 48 -- > > .../bindings/iio/adc/adi,ad7780.yaml | 87 +++ > > 2 files changed, 87 insertions(+), 48 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt > > create mode 100644 > > Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml > > > > Reviewed-by: Rob Herring Thanks. As I'd not yet pushed out as togreg (rather than testing) I've rebased to add your RB. Thanks, Jonathan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 1/2] dt-bindings: iio: adc: add adi, ad7780.yaml binding
On Fri, 24 May 2019 22:26:30 -0300, Renato Lui Geh wrote: This patch adds a YAML binding for the Analog Devices AD7780/1 and AD7170/1 analog-to-digital converters. Signed-off-by: Renato Lui Geh --- Changes in v2: - vref-supply to avdd-supply - remove avdd-supply from required list - include adc block in an spi block .../bindings/iio/adc/adi,ad7780.txt | 48 -- .../bindings/iio/adc/adi,ad7780.yaml | 87 +++ 2 files changed, 87 insertions(+), 48 deletions(-) delete mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml Reviewed-by: Rob Herring ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 1/2] dt-bindings: iio: adc: add adi,ad7780.yaml binding
On Thu, 6 Jun 2019 16:52:14 +0100 Jonathan Cameron wrote: > On Thu, 6 Jun 2019 11:13:52 + > "Ardelean, Alexandru" wrote: > > > On Wed, 2019-06-05 at 17:35 -0300, Renato Lui Geh wrote: > > > [External] > > > > > > > > > On 05/26, Jonathan Cameron wrote: > > > > On Fri, 24 May 2019 22:26:30 -0300 > > > > Renato Lui Geh wrote: > > > > > > > > > This patch adds a YAML binding for the Analog Devices AD7780/1 and > > > > > AD7170/1 analog-to-digital converters. > > > > > > > > > > Signed-off-by: Renato Lui Geh > > > > Looks good to me, but I'm still finding my feet with these so will > > > > leave it for a few days for others to have time to comment. > > > > > > > > Michael, looking for a quick reply from you to say if you are happy > > > > being explicitly listed as maintainer for this one, or if you'd > > > > rather land it on someone else. Same applies for patch 2. > > > > > > > > Renato, if I seem to have forgotten this in a week or so, feel > > > > free to give me a poke. I've been known to loose patches entirely! > > > > > > Hi Jonathan, > > > > > > Just here to give you a poke. :) > > > > > > By the way, in these cases, which would be easier for you? To send you > > > an email like I'm doing right now on last week's thread; or to resend > > > the entire patch(set)? > > > > > > > I think in this case, maybe let's wait a bit longer. > > Jonathan has not been active recently. > > > > I think a [RESEND] would be a good idea when he gets back/active and misses > > your patchset. > > > Sorry, was away last weekend and haven't caught up since. > > I should be fine to pick this up this weekend. > > A ping like this is fine rather than a resend. I've applied this the togreg branch of iio.git and pushed out as testing. Note I'm not planning a pull request for a week or so, so welcome any additional comments anyone has when they are able to make them. Thanks, Jonathan > > Thanks, > > Jonathan > > > Thanks > > Alex > > > > > Thanks, > > > Renato > > > > Thanks, > > > > > > > > Jonathan > > > > > --- > > > > > Changes in v2: > > > > > - vref-supply to avdd-supply > > > > > - remove avdd-supply from required list > > > > > - include adc block in an spi block > > > > > > > > > > .../bindings/iio/adc/adi,ad7780.txt | 48 -- > > > > > .../bindings/iio/adc/adi,ad7780.yaml | 87 > > > > > +++ > > > > > 2 files changed, 87 insertions(+), 48 deletions(-) > > > > > delete mode 100644 > > > > > Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt > > > > > create mode 100644 > > > > > Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt > > > > > b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt > > > > > deleted file mode 100644 > > > > > index 440e52555349.. > > > > > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt > > > > > +++ /dev/null > > > > > @@ -1,48 +0,0 @@ > > > > > -* Analog Devices AD7170/AD7171/AD7780/AD7781 > > > > > - > > > > > -Data sheets: > > > > > - > > > > > -- AD7170: > > > > > -* > > > > > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7170.pdf > > > > > -- AD7171: > > > > > -* > > > > > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7171.pdf > > > > > -- AD7780: > > > > > -* > > > > > https://www.analog.com/media/en/technical-documentation/data-sheets/ad7780.pdf > > > > > -- AD7781: > > > > > -* > > > > > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7781.pdf > > > > > - > > > > > -Required properties: > > > > > - > > > > > -- compatible: should be one of > > > > > -* "adi,ad7170" > > > > > -* "adi,ad7171" > > > > > -* "adi,ad7780" > > > > > -* "adi,ad7781" > > > > > -- reg: spi chip select number for the device > > > > > -- vref-supply: the regulator supply for the ADC reference voltage > > > > > - > > > > > -Optional properties: > > > > > - > > > > > -- powerdown-gpios: must be the device tree identifier of the PDRST > > > > > pin. If > > > > > -specified, it will be asserted during driver probe. > > > > > As the > > > > > -line is active high, it should be marked > > > > > GPIO_ACTIVE_HIGH. > > > > > -- adi,gain-gpios: must be the device tree identifier of the GAIN > > > > > pin. Only for > > > > > -the ad778x chips. If specified, it will be asserted > > > > > during > > > > > -driver probe. As the line is active low, it should > > > > > be marked > > > > > -GPIO_ACTIVE_LOW. > > > > > -- adi,filter-gpios: must be the device tree identifier of the FILTER > > > > > pin. Only > > > > > -for the ad778x chips. If specified, it will be > > > > > asserted > > > > > -during driver probe. As the line is active low, it > > > > > s
Re: [PATCH v2 1/2] dt-bindings: iio: adc: add adi,ad7780.yaml binding
On Thu, 6 Jun 2019 11:13:52 +
"Ardelean, Alexandru" wrote:
> On Wed, 2019-06-05 at 17:35 -0300, Renato Lui Geh wrote:
> > [External]
> >
> >
> > On 05/26, Jonathan Cameron wrote:
> > > On Fri, 24 May 2019 22:26:30 -0300
> > > Renato Lui Geh wrote:
> > >
> > > > This patch adds a YAML binding for the Analog Devices AD7780/1 and
> > > > AD7170/1 analog-to-digital converters.
> > > >
> > > > Signed-off-by: Renato Lui Geh
> > > Looks good to me, but I'm still finding my feet with these so will
> > > leave it for a few days for others to have time to comment.
> > >
> > > Michael, looking for a quick reply from you to say if you are happy
> > > being explicitly listed as maintainer for this one, or if you'd
> > > rather land it on someone else. Same applies for patch 2.
> > >
> > > Renato, if I seem to have forgotten this in a week or so, feel
> > > free to give me a poke. I've been known to loose patches entirely!
> >
> > Hi Jonathan,
> >
> > Just here to give you a poke. :)
> >
> > By the way, in these cases, which would be easier for you? To send you
> > an email like I'm doing right now on last week's thread; or to resend
> > the entire patch(set)?
> >
>
> I think in this case, maybe let's wait a bit longer.
> Jonathan has not been active recently.
>
> I think a [RESEND] would be a good idea when he gets back/active and misses
> your patchset.
>
Sorry, was away last weekend and haven't caught up since.
I should be fine to pick this up this weekend.
A ping like this is fine rather than a resend.
Thanks,
Jonathan
> Thanks
> Alex
>
> > Thanks,
> > Renato
> > > Thanks,
> > >
> > > Jonathan
> > > > ---
> > > > Changes in v2:
> > > > - vref-supply to avdd-supply
> > > > - remove avdd-supply from required list
> > > > - include adc block in an spi block
> > > >
> > > > .../bindings/iio/adc/adi,ad7780.txt | 48 --
> > > > .../bindings/iio/adc/adi,ad7780.yaml | 87 +++
> > > > 2 files changed, 87 insertions(+), 48 deletions(-)
> > > > delete mode 100644
> > > > Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> > > > create mode 100644
> > > > Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> > > > b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> > > > deleted file mode 100644
> > > > index 440e52555349..
> > > > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> > > > +++ /dev/null
> > > > @@ -1,48 +0,0 @@
> > > > -* Analog Devices AD7170/AD7171/AD7780/AD7781
> > > > -
> > > > -Data sheets:
> > > > -
> > > > -- AD7170:
> > > > -*
> > > > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7170.pdf
> > > > -- AD7171:
> > > > -*
> > > > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7171.pdf
> > > > -- AD7780:
> > > > -*
> > > > https://www.analog.com/media/en/technical-documentation/data-sheets/ad7780.pdf
> > > > -- AD7781:
> > > > -*
> > > > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7781.pdf
> > > > -
> > > > -Required properties:
> > > > -
> > > > -- compatible: should be one of
> > > > -* "adi,ad7170"
> > > > -* "adi,ad7171"
> > > > -* "adi,ad7780"
> > > > -* "adi,ad7781"
> > > > -- reg: spi chip select number for the device
> > > > -- vref-supply: the regulator supply for the ADC reference voltage
> > > > -
> > > > -Optional properties:
> > > > -
> > > > -- powerdown-gpios: must be the device tree identifier of the PDRST
> > > > pin. If
> > > > -specified, it will be asserted during driver probe. As
> > > > the
> > > > -line is active high, it should be marked
> > > > GPIO_ACTIVE_HIGH.
> > > > -- adi,gain-gpios: must be the device tree identifier of the GAIN
> > > > pin. Only for
> > > > -the ad778x chips. If specified, it will be asserted
> > > > during
> > > > -driver probe. As the line is active low, it should be
> > > > marked
> > > > -GPIO_ACTIVE_LOW.
> > > > -- adi,filter-gpios: must be the device tree identifier of the FILTER
> > > > pin. Only
> > > > -for the ad778x chips. If specified, it will be asserted
> > > > -during driver probe. As the line is active low, it
> > > > should be
> > > > -marked GPIO_ACTIVE_LOW.
> > > > -
> > > > -Example:
> > > > -
> > > > -adc@0 {
> > > > -compatible = "adi,ad7780";
> > > > -reg = <0>;
> > > > -vref-supply = <&vdd_supply>
> > > > -
> > > > -powerdown-gpios = <&gpio 12 GPIO_ACTIVE_HIGH>;
> > > > -adi,gain-gpios = <&gpio 5 GPIO_ACTIVE_LOW>;
> > > > -adi,filter-gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
> > > > -};
> > > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
> > > > b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
> > > >
Re: [PATCH v2 1/2] dt-bindings: iio: adc: add adi,ad7780.yaml binding
On Wed, 2019-06-05 at 17:35 -0300, Renato Lui Geh wrote:
> [External]
>
>
> On 05/26, Jonathan Cameron wrote:
> > On Fri, 24 May 2019 22:26:30 -0300
> > Renato Lui Geh wrote:
> >
> > > This patch adds a YAML binding for the Analog Devices AD7780/1 and
> > > AD7170/1 analog-to-digital converters.
> > >
> > > Signed-off-by: Renato Lui Geh
> > Looks good to me, but I'm still finding my feet with these so will
> > leave it for a few days for others to have time to comment.
> >
> > Michael, looking for a quick reply from you to say if you are happy
> > being explicitly listed as maintainer for this one, or if you'd
> > rather land it on someone else. Same applies for patch 2.
> >
> > Renato, if I seem to have forgotten this in a week or so, feel
> > free to give me a poke. I've been known to loose patches entirely!
>
> Hi Jonathan,
>
> Just here to give you a poke. :)
>
> By the way, in these cases, which would be easier for you? To send you
> an email like I'm doing right now on last week's thread; or to resend
> the entire patch(set)?
>
I think in this case, maybe let's wait a bit longer.
Jonathan has not been active recently.
I think a [RESEND] would be a good idea when he gets back/active and misses
your patchset.
Thanks
Alex
> Thanks,
> Renato
> > Thanks,
> >
> > Jonathan
> > > ---
> > > Changes in v2:
> > > - vref-supply to avdd-supply
> > > - remove avdd-supply from required list
> > > - include adc block in an spi block
> > >
> > > .../bindings/iio/adc/adi,ad7780.txt | 48 --
> > > .../bindings/iio/adc/adi,ad7780.yaml | 87 +++
> > > 2 files changed, 87 insertions(+), 48 deletions(-)
> > > delete mode 100644
> > > Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> > > create mode 100644
> > > Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> > > b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> > > deleted file mode 100644
> > > index 440e52555349..
> > > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> > > +++ /dev/null
> > > @@ -1,48 +0,0 @@
> > > -* Analog Devices AD7170/AD7171/AD7780/AD7781
> > > -
> > > -Data sheets:
> > > -
> > > -- AD7170:
> > > -*
> > > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7170.pdf
> > > -- AD7171:
> > > -*
> > > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7171.pdf
> > > -- AD7780:
> > > -*
> > > https://www.analog.com/media/en/technical-documentation/data-sheets/ad7780.pdf
> > > -- AD7781:
> > > -*
> > > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7781.pdf
> > > -
> > > -Required properties:
> > > -
> > > -- compatible: should be one of
> > > -* "adi,ad7170"
> > > -* "adi,ad7171"
> > > -* "adi,ad7780"
> > > -* "adi,ad7781"
> > > -- reg: spi chip select number for the device
> > > -- vref-supply: the regulator supply for the ADC reference voltage
> > > -
> > > -Optional properties:
> > > -
> > > -- powerdown-gpios: must be the device tree identifier of the PDRST pin.
> > > If
> > > -specified, it will be asserted during driver probe. As
> > > the
> > > -line is active high, it should be marked
> > > GPIO_ACTIVE_HIGH.
> > > -- adi,gain-gpios: must be the device tree identifier of the GAIN pin.
> > > Only for
> > > -the ad778x chips. If specified, it will be asserted
> > > during
> > > -driver probe. As the line is active low, it should be
> > > marked
> > > -GPIO_ACTIVE_LOW.
> > > -- adi,filter-gpios: must be the device tree identifier of the FILTER
> > > pin. Only
> > > -for the ad778x chips. If specified, it will be asserted
> > > -during driver probe. As the line is active low, it
> > > should be
> > > -marked GPIO_ACTIVE_LOW.
> > > -
> > > -Example:
> > > -
> > > -adc@0 {
> > > -compatible = "adi,ad7780";
> > > -reg = <0>;
> > > -vref-supply = <&vdd_supply>
> > > -
> > > -powerdown-gpios = <&gpio 12 GPIO_ACTIVE_HIGH>;
> > > -adi,gain-gpios = <&gpio 5 GPIO_ACTIVE_LOW>;
> > > -adi,filter-gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
> > > -};
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
> > > b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
> > > new file mode 100644
> > > index ..d1109416963c
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
> > > @@ -0,0 +1,87 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7780.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Analog Devices AD7170/AD7171/AD7780/AD7781 analog to digital
> > > converters
> > > +
> > > +maintainers:
> > > +
Re: [PATCH v2 1/2] dt-bindings: iio: adc: add adi, ad7780.yaml binding
On 05/26, Jonathan Cameron wrote:
On Fri, 24 May 2019 22:26:30 -0300
Renato Lui Geh wrote:
This patch adds a YAML binding for the Analog Devices AD7780/1 and
AD7170/1 analog-to-digital converters.
Signed-off-by: Renato Lui Geh
Looks good to me, but I'm still finding my feet with these so will
leave it for a few days for others to have time to comment.
Michael, looking for a quick reply from you to say if you are happy
being explicitly listed as maintainer for this one, or if you'd
rather land it on someone else. Same applies for patch 2.
Renato, if I seem to have forgotten this in a week or so, feel
free to give me a poke. I've been known to loose patches entirely!
Hi Jonathan,
Just here to give you a poke. :)
By the way, in these cases, which would be easier for you? To send you
an email like I'm doing right now on last week's thread; or to resend
the entire patch(set)?
Thanks,
Renato
Thanks,
Jonathan
---
Changes in v2:
- vref-supply to avdd-supply
- remove avdd-supply from required list
- include adc block in an spi block
.../bindings/iio/adc/adi,ad7780.txt | 48 --
.../bindings/iio/adc/adi,ad7780.yaml | 87 +++
2 files changed, 87 insertions(+), 48 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
deleted file mode 100644
index 440e52555349..
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
+++ /dev/null
@@ -1,48 +0,0 @@
-* Analog Devices AD7170/AD7171/AD7780/AD7781
-
-Data sheets:
-
-- AD7170:
- *
https://www.analog.com/media/en/technical-documentation/data-sheets/AD7170.pdf
-- AD7171:
- *
https://www.analog.com/media/en/technical-documentation/data-sheets/AD7171.pdf
-- AD7780:
- *
https://www.analog.com/media/en/technical-documentation/data-sheets/ad7780.pdf
-- AD7781:
- *
https://www.analog.com/media/en/technical-documentation/data-sheets/AD7781.pdf
-
-Required properties:
-
-- compatible: should be one of
- * "adi,ad7170"
- * "adi,ad7171"
- * "adi,ad7780"
- * "adi,ad7781"
-- reg: spi chip select number for the device
-- vref-supply: the regulator supply for the ADC reference voltage
-
-Optional properties:
-
-- powerdown-gpios: must be the device tree identifier of the PDRST pin. If
- specified, it will be asserted during driver probe. As the
- line is active high, it should be marked GPIO_ACTIVE_HIGH.
-- adi,gain-gpios: must be the device tree identifier of the GAIN pin. Only
for
- the ad778x chips. If specified, it will be asserted during
- driver probe. As the line is active low, it should be marked
- GPIO_ACTIVE_LOW.
-- adi,filter-gpios: must be the device tree identifier of the FILTER pin. Only
- for the ad778x chips. If specified, it will be asserted
- during driver probe. As the line is active low, it should be
- marked GPIO_ACTIVE_LOW.
-
-Example:
-
-adc@0 {
- compatible = "adi,ad7780";
- reg = <0>;
- vref-supply = <&vdd_supply>
-
- powerdown-gpios = <&gpio 12 GPIO_ACTIVE_HIGH>;
- adi,gain-gpios = <&gpio 5 GPIO_ACTIVE_LOW>;
- adi,filter-gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
-};
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
new file mode 100644
index ..d1109416963c
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
@@ -0,0 +1,87 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/adi,ad7780.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD7170/AD7171/AD7780/AD7781 analog to digital converters
+
+maintainers:
+ - Michael Hennerich
+
+description: |
+ The ad7780 is a sigma-delta analog to digital converter. This driver provides
+ reading voltage values and status bits from both the ad778x and ad717x
series.
+ Its interface also allows writing on the FILTER and GAIN GPIO pins on the
+ ad778x.
+
+ Specifications on the converters can be found at:
+AD7170:
+
https://www.analog.com/media/en/technical-documentation/data-sheets/AD7170.pdf
+AD7171:
+
https://www.analog.com/media/en/technical-documentation/data-sheets/AD7171.pdf
+AD7780:
+
https://www.analog.com/media/en/technical-documentation/data-sheets/ad7780.pdf
+AD7781:
+
https://www.analog.com/media/en/technical-documentation/data-sheets/AD7781.pdf
+
+properties:
+ compatible:
+enum:
+ - adi,ad7170
+ - adi,ad7171
+ - adi,ad7780
+ - adi,ad7781
+
+ reg:
+maxItems: 1
+
+ avdd-supply:
RE: [PATCH v2 1/2] dt-bindings: iio: adc: add adi, ad7780.yaml binding
> -Original Message-
> From: Jonathan Cameron [mailto:ji...@kernel.org]
> Sent: Sonntag, 26. Mai 2019 18:39
> To: Renato Lui Geh
> Cc: l...@metafoo.de; Hennerich, Michael ;
> knaac...@gmx.de; pme...@pmeerw.net;
> gre...@linuxfoundation.org; Popa, Stefan Serban
> ; Ardelean, Alexandru
> ; robh...@kernel.org; mark.rutl...@arm.com;
> linux-...@vger.kernel.org;
> de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org;
> kernel-...@googlegroups.com; devicet...@vger.kernel.org
> Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: add adi,ad7780.yaml binding
>
> On Fri, 24 May 2019 22:26:30 -0300
> Renato Lui Geh wrote:
>
> > This patch adds a YAML binding for the Analog Devices AD7780/1 and
> > AD7170/1 analog-to-digital converters.
> >
> > Signed-off-by: Renato Lui Geh
> Looks good to me, but I'm still finding my feet with these so will
> leave it for a few days for others to have time to comment.
>
> Michael, looking for a quick reply from you to say if you are happy
> being explicitly listed as maintainer for this one, or if you'd
> rather land it on someone else. Same applies for patch 2.
Hi Jonathan,
Listing me as an maintainer is ok.
Acked-by: Michael Hennerich
>
> Renato, if I seem to have forgotten this in a week or so, feel
> free to give me a poke. I've been known to loose patches entirely!
>
> Thanks,
>
> Jonathan
> > ---
> > Changes in v2:
> > - vref-supply to avdd-supply
> > - remove avdd-supply from required list
> > - include adc block in an spi block
> >
> > .../bindings/iio/adc/adi,ad7780.txt | 48 --
> > .../bindings/iio/adc/adi,ad7780.yaml | 87 +++
> > 2 files changed, 87 insertions(+), 48 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> > create mode 100644
> > Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> > b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> > deleted file mode 100644
> > index 440e52555349..
> > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> > +++ /dev/null
> > @@ -1,48 +0,0 @@
> > -* Analog Devices AD7170/AD7171/AD7780/AD7781
> > -
> > -Data sheets:
> > -
> > -- AD7170:
> > - *
> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7170.pdf
> > -- AD7171:
> > - *
> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7171.pdf
> > -- AD7780:
> > - *
> > https://www.analog.com/media/en/technical-documentation/data-sheets/ad7780.pdf
> > -- AD7781:
> > - *
> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7781.pdf
> > -
> > -Required properties:
> > -
> > -- compatible: should be one of
> > - * "adi,ad7170"
> > - * "adi,ad7171"
> > - * "adi,ad7780"
> > - * "adi,ad7781"
> > -- reg: spi chip select number for the device
> > -- vref-supply: the regulator supply for the ADC reference voltage
> > -
> > -Optional properties:
> > -
> > -- powerdown-gpios: must be the device tree identifier of the PDRST pin. If
> > - specified, it will be asserted during driver probe. As the
> > - line is active high, it should be marked GPIO_ACTIVE_HIGH.
> > -- adi,gain-gpios: must be the device tree identifier of the GAIN pin.
> > Only for
> > - the ad778x chips. If specified, it will be asserted during
> > - driver probe. As the line is active low, it should be
> > marked
> > - GPIO_ACTIVE_LOW.
> > -- adi,filter-gpios: must be the device tree identifier of the FILTER pin.
> > Only
> > - for the ad778x chips. If specified, it will be asserted
> > - during driver probe. As the line is active low, it should
> > be
> > - marked GPIO_ACTIVE_LOW.
> > -
> > -Example:
> > -
> > -adc@0 {
> > - compatible = "adi,ad7780";
> > - reg = <0>;
> > - vref-supply = <&vdd_supply>
> > -
> > - powerdown-gpios = <&gpio 12 GPIO_ACTIVE_HIGH>;
> > - adi,gain-gpios = <&gpio 5 GPIO_ACTIVE_LOW>;
> > - adi,filter-gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yam
Re: [PATCH v2 1/2] dt-bindings: iio: adc: add adi,ad7780.yaml binding
On Fri, 24 May 2019 22:26:30 -0300
Renato Lui Geh wrote:
> This patch adds a YAML binding for the Analog Devices AD7780/1 and
> AD7170/1 analog-to-digital converters.
>
> Signed-off-by: Renato Lui Geh
Looks good to me, but I'm still finding my feet with these so will
leave it for a few days for others to have time to comment.
Michael, looking for a quick reply from you to say if you are happy
being explicitly listed as maintainer for this one, or if you'd
rather land it on someone else. Same applies for patch 2.
Renato, if I seem to have forgotten this in a week or so, feel
free to give me a poke. I've been known to loose patches entirely!
Thanks,
Jonathan
> ---
> Changes in v2:
> - vref-supply to avdd-supply
> - remove avdd-supply from required list
> - include adc block in an spi block
>
> .../bindings/iio/adc/adi,ad7780.txt | 48 --
> .../bindings/iio/adc/adi,ad7780.yaml | 87 +++
> 2 files changed, 87 insertions(+), 48 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> deleted file mode 100644
> index 440e52555349..
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> +++ /dev/null
> @@ -1,48 +0,0 @@
> -* Analog Devices AD7170/AD7171/AD7780/AD7781
> -
> -Data sheets:
> -
> -- AD7170:
> - *
> https://www.analog.com/media/en/technical-documentation/data-sheets/AD7170.pdf
> -- AD7171:
> - *
> https://www.analog.com/media/en/technical-documentation/data-sheets/AD7171.pdf
> -- AD7780:
> - *
> https://www.analog.com/media/en/technical-documentation/data-sheets/ad7780.pdf
> -- AD7781:
> - *
> https://www.analog.com/media/en/technical-documentation/data-sheets/AD7781.pdf
> -
> -Required properties:
> -
> -- compatible: should be one of
> - * "adi,ad7170"
> - * "adi,ad7171"
> - * "adi,ad7780"
> - * "adi,ad7781"
> -- reg: spi chip select number for the device
> -- vref-supply: the regulator supply for the ADC reference voltage
> -
> -Optional properties:
> -
> -- powerdown-gpios: must be the device tree identifier of the PDRST pin. If
> - specified, it will be asserted during driver probe. As the
> - line is active high, it should be marked GPIO_ACTIVE_HIGH.
> -- adi,gain-gpios: must be the device tree identifier of the GAIN pin. Only
> for
> - the ad778x chips. If specified, it will be asserted during
> - driver probe. As the line is active low, it should be marked
> - GPIO_ACTIVE_LOW.
> -- adi,filter-gpios: must be the device tree identifier of the FILTER pin.
> Only
> - for the ad778x chips. If specified, it will be asserted
> - during driver probe. As the line is active low, it should be
> - marked GPIO_ACTIVE_LOW.
> -
> -Example:
> -
> -adc@0 {
> - compatible = "adi,ad7780";
> - reg = <0>;
> - vref-supply = <&vdd_supply>
> -
> - powerdown-gpios = <&gpio 12 GPIO_ACTIVE_HIGH>;
> - adi,gain-gpios = <&gpio 5 GPIO_ACTIVE_LOW>;
> - adi,filter-gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
> -};
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
> b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
> new file mode 100644
> index ..d1109416963c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
> @@ -0,0 +1,87 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,ad7780.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD7170/AD7171/AD7780/AD7781 analog to digital
> converters
> +
> +maintainers:
> + - Michael Hennerich
> +
> +description: |
> + The ad7780 is a sigma-delta analog to digital converter. This driver
> provides
> + reading voltage values and status bits from both the ad778x and ad717x
> series.
> + Its interface also allows writing on the FILTER and GAIN GPIO pins on the
> + ad778x.
> +
> + Specifications on the converters can be found at:
> +AD7170:
> +
> https://www.analog.com/media/en/technical-documentation/data-sheets/AD7170.pdf
> +AD7171:
> +
> https://www.analog.com/media/en/technical-documentation/data-sheets/AD7171.pdf
> +AD7780:
> +
> https://www.analog.com/media/en/technical-documentation/data-sheets/ad7780.pdf
> +AD7781:
> +
> https://www.analog.com/media/en/technical-documentation/data-sheets/AD7781.pdf
> +
> +properties:
> + compatible:
> +enum:
> + - adi,ad7170
> + - adi,ad7171
> + - adi,ad7780
> + - adi,ad7781
> +
> + reg:
> +maxItems: 1
> +
> + avdd-supply:
> +description:
> + The regulator supply f
