Re: [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-12 Thread Johan Hovold 
On Thu, Jan 12, 2017 at 10:05:10AM +0300, Dan Carpenter wrote:
> On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote:
> > Note that this patch does not fix all checkpatch warnings for the
> > affected files.
> > 
> 
> A lot of ways that display git commits put the changelog and the summary
> far apart.  The changelog is pretty useless by itself in this case.
> 
> https://lkml.org/lkml/2017/1/11/308
> 
> See how it puts the date in between?  marc.info is even worse but google
> hasn't indexed it yet and I'm too lazy to look it up.  So people read
> the summary or the changelog but not necessarily both.

Yeah, let's do this right.

Roman, could you resend this with a self-contained commit message, and a
more compact summary (Subject) as I suggested earlier?

Thanks,
Johan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-11 Thread Dan Carpenter 
On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote:
> Note that this patch does not fix all checkpatch warnings for the
> affected files.
> 

A lot of ways that display git commits put the changelog and the summary
far apart.  The changelog is pretty useless by itself in this case.

https://lkml.org/lkml/2017/1/11/308

See how it puts the date in between?  marc.info is even worse but google
hasn't indexed it yet and I'm too lazy to look it up.  So people read
the summary or the changelog but not necessarily both.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-11 Thread Johan Hovold 
On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote:
> Note that this patch does not fix all checkpatch warnings for the
> affected files.
> 
> Signed-off-by: Christian Bewermeyer 
> Signed-off-by: Roman Sommer 

Next time I suggest you drop "checkpatch: " from your subject since
that's not a (greybus) component. You could have rephrased the summary
as "fix checkpatch unsigned warnings" or similar instead.

Reviewed-by: Johan Hovold 

Thanks,
Johan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel