Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages
On Sun, 2018-08-19 at 13:34 +0200, Greg Kroah-Hartman wrote:
> On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote:
> > Fixed four debug macros and their usages. Replaced printk with
> > dev_ without __func__ or __LINE__ or current->comm and
> > current->pid. Further removed the do {} while(0) loop for single
> > statement macros.
> > Out of the four, replaced all usages of ERR_MSG and IRQ_MSG with
> > dev_err() in the code itself and dropped them from dbg.h.
> > Removed all INIT_MSG usages and dropped it from dgb.h.
> > Issues found by checkpatch.
>
> This needs to be multiple patches. One for each type of macro you are
> deleting/changing, not all lumped together into one big patch.
>
> Plaese fix that up and resend.
I'd also be tempted to add some logging macros like:
#define host_err(host, fmt, ...) \
dev_err(mmc_dev((host)->mmc, fmt, ##__VA_ARGS__)
so that the code flows a little better.
e.g.:
@@ -521,7 +517,7 @@ static void msdc_abort_data(struct msdc_host *host)> {
> struct mmc_command *stop = host->mrq->stop;
> - ERR_MSG("Need to Abort.");
> + dev_err(mmc_dev(host->mmc), "%d -> Need to Abort.\n", host->id);
> msdc_reset_hw(host);
> msdc_clr_fifo(host);
becomes
host_err(host, "%d -> Need to Abort\n", host->id);
etc...
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages
On Sun, Aug 19, 2018 at 01:34:01PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote:
> > Fixed four debug macros and their usages. Replaced printk with
> > dev_ without __func__ or __LINE__ or current->comm and
> > current->pid. Further removed the do {} while(0) loop for single
> > statement macros.
> > Out of the four, replaced all usages of ERR_MSG and IRQ_MSG with
> > dev_err() in the code itself and dropped them from dbg.h.
> > Removed all INIT_MSG usages and dropped it from dgb.h.
> > Issues found by checkpatch.
>
> This needs to be multiple patches. One for each type of macro you are
> deleting/changing, not all lumped together into one big patch.
>
> Plaese fix that up and resend.
>
> thanks,
>
> greg k-h
Ok, I'll do that.
Thanks for the review.
regards,
nishad
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages
On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote:
> #define N_MSG(evt, fmt, args...)
> /*
> -do {\
> -if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \
> -printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \
> -host->id, ##args , __FUNCTION__, __LINE__, current->comm,
> current->pid);\
> -} \
> -} while(0)
> -*/
> -
> -#define ERR_MSG(fmt, args...) \
> -do { \
> - printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \
> -host->id, ##args, __FUNCTION__, __LINE__, current->comm,
> current->pid); \
> -} while (0);
> -
> -#if 1
> -//defined CONFIG_MTK_MMC_CD_POLL
> -#define INIT_MSG(fmt, args...)
> -#define IRQ_MSG(fmt, args...)
> -#else
> -#define INIT_MSG(fmt, args...) \
> -do { \
> - printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \
> -host->id, ##args, __FUNCTION__, __LINE__, current->comm,
> current->pid); \
> -} while (0);
> -
> -/* PID in ISR in not corrent */
> -#define IRQ_MSG(fmt, args...) \
> -do { \
> - printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d>\n", \
> -host->id, ##args, __FUNCTION__, __LINE__); \
> -} while (0);
> -#endif
> + *if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \
> + *dev_err(mmc_dev(host->mmc), "%d -> " fmt "\n", host->id, ##args) \
> + *}
> + */
I'm sorry but this patch doesn't make any sort of sense at all...
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages
On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote:
> Fixed four debug macros and their usages. Replaced printk with
> dev_ without __func__ or __LINE__ or current->comm and
> current->pid. Further removed the do {} while(0) loop for single
> statement macros.
> Out of the four, replaced all usages of ERR_MSG and IRQ_MSG with
> dev_err() in the code itself and dropped them from dbg.h.
> Removed all INIT_MSG usages and dropped it from dgb.h.
> Issues found by checkpatch.
This needs to be multiple patches. One for each type of macro you are
deleting/changing, not all lumped together into one big patch.
Plaese fix that up and resend.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
