Re: [PATCH v3 1/2] staging: slicoss: fix different address space warnings: 32 bits
On Thu, Nov 17, 2016 at 12:46:12PM +0100, Sergio Paracuellos wrote: > On Thu, Nov 17, 2016 at 12:33 PM, Dan Carpenter > wrote: > > Give it a shot and see if the warnings go away. I don't think the tag > > is correct. > > Just removing __iomem tag in shmem_data field of slic_shmemory struct > makes sparse happy. No warnings around. > > Should I send a v4 patch with the tag removed? Yes, please fix up this series and resend. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 1/2] staging: slicoss: fix different address space warnings: 32 bits
On Thu, Nov 17, 2016 at 12:33 PM, Dan Carpenter wrote: > Give it a shot and see if the warnings go away. I don't think the tag > is correct. Just removing __iomem tag in shmem_data field of slic_shmemory struct makes sparse happy. No warnings around. Should I send a v4 patch with the tag removed? Cheers, Sergio Paracuellos ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 1/2] staging: slicoss: fix different address space warnings: 32 bits
On Thu, Nov 17, 2016 at 12:22:00PM +0100, Sergio Paracuellos wrote: > On Thu, Nov 17, 2016 at 11:51 AM, Dan Carpenter > wrote: > > Hm... I seem to duplicate the Sparse warnings at all. That's weird. > > > > With this patch applied, sparse warnings dissapear for me... That's weird. > I understand that. > > Anyway as far as I can tell the warnings are false positives... Can't > > you just remove the __iomem tag? Have you tested this change? > > > I haven' t tested this change because I can't test it :(. Do you think > that just removing > __iomem tag is enough? Give it a shot and see if the warnings go away. I don't think the tag is correct. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 1/2] staging: slicoss: fix different address space warnings: 32 bits
On Thu, Nov 17, 2016 at 11:51 AM, Dan Carpenter wrote: > Hm... I seem to duplicate the Sparse warnings at all. That's weird. > With this patch applied, sparse warnings dissapear for me... That's weird. > Anyway as far as I can tell the warnings are false positives... Can't > you just remove the __iomem tag? Have you tested this change? > I haven' t tested this change because I can't test it :(. Do you think that just removing __iomem tag is enough? Maybe we can get feedback from Lior or someone. Thanks for your review time, Dan. Cheers, Sergio Paracuellos ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 1/2] staging: slicoss: fix different address space warnings: 32 bits
Hm... I seem to duplicate the Sparse warnings at all. That's weird. Anyway as far as I can tell the warnings are false positives... Can't you just remove the __iomem tag? Have you tested this change? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
