Re: [PATCH v4 2/2] staging: ccree: fixed sparse pointer signedness warnings.

[Jeremy Sowden]

On 2018-01-11, at 08:25:20 +0200, Gilad Ben-Yossef wrote:
> On Wed, Jan 10, 2018 at 3:33 PM, Jeremy Sowden  wrote:
> > This patch fixes sparse warnings arising when the addresses of signed
> > variables are passed to functions expecting pointers to unsigned
> > integers by converting those signed variables to unsigned as follows:
> >
> >   * changed the types of a number of index and length variables from
> > signed to unsigned integer types.
> >
> >   * changed the return-types of a couple of functions that return length
> > values which are assigned to one of these variables from signed to
> > unsigned integer types.
> >
> > Signed-off-by: Jeremy Sowden 
> > ---
>
> Please run scripts/checkpatch.pl on patches before submission.
> They have multiple coding style errors.

Apologies.  v3 was fine and I got complacent. :-/

J.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4 2/2] staging: ccree: fixed sparse pointer signedness warnings.

[Gilad Ben-Yossef]

Hi Jermey,

On Wed, Jan 10, 2018 at 3:33 PM, Jeremy Sowden  wrote:
> This patch fixes sparse warnings arising when the addresses of signed
> variables are passed to functions expecting pointers to unsigned
> integers by converting those signed variables to unsigned as follows:
>
>   * changed the types of a number of index and length variables from
> signed to unsigned integer types.
>
>   * changed the return-types of a couple of functions that return length
> values which are assigned to one of these variables from signed to
> unsigned integer types.
>
> Signed-off-by: Jeremy Sowden 
> ---


Please run scripts/checkpatch.pl on patches before submission.
They have multiple coding style errors.

You should probably also read Documentation/process/submitting-patches.rst

Thanks,
Gilad


-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel