Re: [PATCHv2 0/5] ft1000 driver checkpatch.pl fixes
On Wed, 2015-04-01 at 12:23 -0700, Janakarajan Natarajan wrote: > I initially sent a single patch on March 11th. It was recommended that I > send it in a patchset as it did too many things in 1 patch. > I submitted the v2 patchset on March 12th. After a week of not knowing if > it was accepted, I resent it again on March 18. > > I will resend the patchset. Should it be labled 'v2'? People can be busy and for most patches that aren't critical fixes, you should wait a month or so before resending anything that hasn't been applied or commented on. And instead of incrementing the version, just prefix with something like: "[resend PATCH v]" ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCHv2 0/5] ft1000 driver checkpatch.pl fixes
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Mar 26, 2015 at 08:16:14PM -0700, Janakarajan Natarajan wrote: > I resent v2 because I didn't know if my previous patchset had been accepted or > not. Then it's really not a 'v2' patch series, is it :( I suggest resending them in the proper format, if I haven't already applied them... thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCHv2 0/5] ft1000 driver checkpatch.pl fixes
On Wed, Mar 18, 2015 at 01:56:31PM -0700, Janakarajan Natarajan wrote: > Minor changes to fix ft1000 driver checkpatch.pl warnings > > Janakarajan Natarajan (5): > Drivers: Staging: ft1000: Single line if-statement changes > Drivers: Staging: ft1000: Fix extra parenthesis warnings > Drivers: Staging: ft1000: Refactoring if-else statement > Drivers: Staging: ft1000: Fix blank line after declartion warning > Drivers: Staging: ft1000: checkpatch.pl header file warning fix > > v2: if-else refactored as suggested by Joe Perches Variable reworked as suggested by Giedrius Statkevicius > > > drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 16 +++- > drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 6 ++ > 2 files changed, 9 insertions(+), 13 deletions(-) Why did you resend this "v2" series with no changes? I don't know what to do here, so I've dropped all of your pending patches for this driver, please resend anything I haven't applied. Remember, you need to be _really_ explicit as to what to do, I deal with over a thousand emails a day, and handle patches in batches, and have no short-term memory as to what happened yesterday/last week in email threads. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
