Re: [Patch v2][ 04/37] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format.

2013-10-31 Thread Mauro Carvalho Chehab
Em Thu, 17 Oct 2013 17:02:02 +0200
Denis Carikli de...@eukrea.com escreveu:

 That new macro is needed by the imx_drm staging driver
   for supporting the QVGA display of the eukrea-cpuimx51 board.
 
 Cc: Rob Herring rob.herr...@calxeda.com
 Cc: Pawel Moll pawel.m...@arm.com
 Cc: Mark Rutland mark.rutl...@arm.com
 Cc: Stephen Warren swar...@wwwdotorg.org
 Cc: Ian Campbell ijc+devicet...@hellion.org.uk
 Cc: devicet...@vger.kernel.org
 Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
 Cc: driverdev-devel@linuxdriverproject.org
 Cc: David Airlie airl...@linux.ie
 Cc: dri-de...@lists.freedesktop.org
 Cc: Mauro Carvalho Chehab m.che...@samsung.com
 Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
 Cc: linux-me...@vger.kernel.org
 Cc: Sascha Hauer ker...@pengutronix.de
 Cc: linux-arm-ker...@lists.infradead.org
 Cc: Eric Bénard e...@eukrea.com
 Signed-off-by: Denis Carikli de...@eukrea.com

It seems better to apply this one together with the other DRM patches via
DRM tree. So:
Acked-by: Mauro Carvalho Chehab m.che...@samsung.com

 ---
  include/uapi/linux/videodev2.h |1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
 index 437f1b0..e8ff410 100644
 --- a/include/uapi/linux/videodev2.h
 +++ b/include/uapi/linux/videodev2.h
 @@ -294,6 +294,7 @@ struct v4l2_pix_format {
  #define V4L2_PIX_FMT_RGB555X v4l2_fourcc('R', 'G', 'B', 'Q') /* 16  
 RGB-5-5-5 BE  */
  #define V4L2_PIX_FMT_RGB565X v4l2_fourcc('R', 'G', 'B', 'R') /* 16  
 RGB-5-6-5 BE  */
  #define V4L2_PIX_FMT_BGR666  v4l2_fourcc('B', 'G', 'R', 'H') /* 18  
 BGR-6-6-6  */
 +#define V4L2_PIX_FMT_RGB666  v4l2_fourcc('R', 'G', 'B', 'H') /* 18  
 RGB-6-6-6  */
  #define V4L2_PIX_FMT_BGR24   v4l2_fourcc('B', 'G', 'R', '3') /* 24  
 BGR-8-8-8 */
  #define V4L2_PIX_FMT_RGB24   v4l2_fourcc('R', 'G', 'B', '3') /* 24  
 RGB-8-8-8 */
  #define V4L2_PIX_FMT_BGR32   v4l2_fourcc('B', 'G', 'R', '4') /* 32  
 BGR-8-8-8-8   */


-- 

Cheers,
Mauro
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


Re: [Patch v2][ 04/37] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format.

2013-10-31 Thread Laurent Pinchart
On Thursday 31 October 2013 11:18:06 Mauro Carvalho Chehab wrote:
 Em Thu, 17 Oct 2013 17:02:02 +0200
 
 Denis Carikli de...@eukrea.com escreveu:
  That new macro is needed by the imx_drm staging driver
  
for supporting the QVGA display of the eukrea-cpuimx51 board.
  
  Cc: Rob Herring rob.herr...@calxeda.com
  Cc: Pawel Moll pawel.m...@arm.com
  Cc: Mark Rutland mark.rutl...@arm.com
  Cc: Stephen Warren swar...@wwwdotorg.org
  Cc: Ian Campbell ijc+devicet...@hellion.org.uk
  Cc: devicet...@vger.kernel.org
  Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
  Cc: driverdev-devel@linuxdriverproject.org
  Cc: David Airlie airl...@linux.ie
  Cc: dri-de...@lists.freedesktop.org
  Cc: Mauro Carvalho Chehab m.che...@samsung.com
  Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
  Cc: linux-me...@vger.kernel.org
  Cc: Sascha Hauer ker...@pengutronix.de
  Cc: linux-arm-ker...@lists.infradead.org
  Cc: Eric Bénard e...@eukrea.com
  Signed-off-by: Denis Carikli de...@eukrea.com
 
 It seems better to apply this one together with the other DRM patches via
 DRM tree. So:
   Acked-by: Mauro Carvalho Chehab m.che...@samsung.com

Actually, if I might, I'd like to nak this patch, as adding new pixel formats 
requires updating the documentation as well (see 
Documentation/DocBook/media/v4l/pixfmt*.xml).

  ---
  
   include/uapi/linux/videodev2.h |1 +
   1 file changed, 1 insertion(+)
  
  diff --git a/include/uapi/linux/videodev2.h
  b/include/uapi/linux/videodev2.h index 437f1b0..e8ff410 100644
  --- a/include/uapi/linux/videodev2.h
  +++ b/include/uapi/linux/videodev2.h
  @@ -294,6 +294,7 @@ struct v4l2_pix_format {
  
   #define V4L2_PIX_FMT_RGB555X v4l2_fourcc('R', 'G', 'B', 'Q') /* 16 
   RGB-5-5-5 BE  */ #define V4L2_PIX_FMT_RGB565X v4l2_fourcc('R', 'G', 'B',
   'R') /* 16  RGB-5-6-5 BE  */ #define V4L2_PIX_FMT_BGR666 
   v4l2_fourcc('B', 'G', 'R', 'H') /* 18  BGR-6-6-6 */ 
  +#define V4L2_PIX_FMT_RGB666  v4l2_fourcc('R', 'G', 'B', 'H') /* 18 
  RGB-6-6-6 */ 
   #define V4L2_PIX_FMT_BGR24   v4l2_fourcc('B', 'G', 'R', '3') /* 24 
   BGR-8-8-8 */ #define V4L2_PIX_FMT_RGB24   v4l2_fourcc('R', 'G', 'B',
   '3') /* 24  RGB-8-8-8 */ #define V4L2_PIX_FMT_BGR32  
   v4l2_fourcc('B', 'G', 'R', '4') /* 32  BGR-8-8-8-8   */
-- 
Regards,

Laurent Pinchart

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel