Re: [PATCH] staging: rtl8712: fix potential leak in r871x_wx_set_enc_ext()
On Wed, 2014-05-07 at 11:55 +0300, Dan Carpenter wrote: > On Wed, May 07, 2014 at 09:55:47AM +0300, Andy Shevchenko wrote: > > > @@ -1824,6 +1817,15 @@ static int r871x_wx_set_enc_ext(struct net_device > > > *dev, > > > default: > > > return -EINVAL; > > > } > > > + > > > + param_len = sizeof(struct ieee_param) + pext->key_len; > > > + param = (struct ieee_param *)_malloc(param_len); > > > > While you are here could you substitute _malloc by kzalloc and remove > > explicit casting and memset? > > > > Normally, that's the kind of thing we would do in a separate patch > because or the "one thing per patch" rule. Eventually someone will do a > driver wide replacement of _malloc(). Or if the bug fixer wanted, he > could do it in this patch because it is on the same line and all so it > counts as a "minor closely related change." Either way is fine. > > Another way to say this is that since the _malloc() was there in the > original code and Christian didn't introduce it, then we shouldn't > reject his patch because of it. This is staging code, and there are so > many problems that if you start trying to fix everything you'll just get > lost. > > In my experience v2 patches are much harder to write than v1 patches. > Twice in the past few days I have messed up the subject line in my v2 > patches. I'm not objecting to let green light for it, indeed maybe someone could change all _mallocs & memsets in that code. -- Andy Shevchenko Intel Finland Oy ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[patch v3] Documentation/email-clients.txt: add a section about git
These days most people use git to send patches so I have added a section about that. Signed-off-by: Dan Carpenter --- v2: fix typo in commit message v3: update git am and log commands. Mention the man pages. diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt index 4e30eba..9293477 100644 --- a/Documentation/email-clients.txt +++ b/Documentation/email-clients.txt @@ -1,6 +1,17 @@ Email clients info for Linux == +Git +-- +These days most developers use `git send-email` instead of regular +email clients. The man page for this is quite good. On the receiving +end, maintainers use `git am` to apply the patches. + +If you are new to git then send your first patch to yourself. Save it +as raw text including all the headers. Run `git am raw_email.txt` and +then review the changelog with `git log`. When that works then send +the patch to list. + General Preferences -- Patches for the Linux kernel are submitted via email, preferably as ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: ft1000: Replace printk with pr_info in ft1000_cs.c
This patch replaced printk with pr_info.
Signed-off-by: Masanari Iida
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
index f376ca4..00c86db 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
@@ -95,20 +95,20 @@ static int ft1000_config(struct pcmcia_device *link)
/* setup IO window */
ret = pcmcia_loop_config(link, ft1000_confcheck, NULL);
if (ret) {
- printk(KERN_INFO "ft1000: Could not configure pcmcia\n");
+ pr_info("ft1000: Could not configure pcmcia\n");
return -ENODEV;
}
/* configure device */
ret = pcmcia_enable_device(link);
if (ret) {
- printk(KERN_INFO "ft1000: could not enable pcmcia\n");
+ pr_info("ft1000: could not enable pcmcia\n");
goto failed;
}
link->priv = init_ft1000_card(link, &ft1000_reset);
if (!link->priv) {
- printk(KERN_INFO "ft1000: Could not register as network
device\n");
+ pr_info("ft1000: Could not register as network device\n");
goto failed;
}
--
2.0.0.rc3.2.g998f840
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS
From: Wilfried Klaebe Date: Sun, 11 May 2014 00:12:32 + > net: get rid of SET_ETHTOOL_OPS > > Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone. > This does that. > > Mostly done via coccinelle script: > @@ > struct ethtool_ops *ops; > struct net_device *dev; > @@ > - SET_ETHTOOL_OPS(dev, ops); > + dev->ethtool_ops = ops; > > Compile tested only, but I'd seriously wonder if this broke anything. > > Suggested-by: Dave Miller > Signed-off-by: Wilfried Klaebe Applied to net-next, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
