Re: [PATCH v3 0/4] Correct vendor-prefix and document device isl29028

2014-10-04 Thread Jonathan Cameron 
Please repost this series with the device tree list and maintainers cc'd.
What you have looks fine to me, but as it is effecting bindings they must
have the opportunity to comment. Rules are either an Ack from them or
a least 3 weeks on their list then I can make up my own mind :)

On 30/09/14 12:59, Darshana Padmadas wrote:
> Patchset documents correct and the deprecated vendor-prefix found by 
> checkpatch 
> warning and also documents information of device isl29028 for compatibility. 
> Patchset also includes corrected vendor-prefix and device name in compatible 
> property for files with checkpatch warning of undocumented string 
> "isil,isl29028".
> 
> Darshana Padmadas (4):
>   Documentation: devicetree: bindings: Document correct and deprecated
> vendor-prefix with device isl29028
>   Documentation: devicetree: bindings: Document deprecated device vendor
> name to fix related warning
>   Staging: iio: light: Added correct vendor-prefix for device isl29028
>   arch: arm: boot: dts: Added correct vendor-prefix with device name to
> compatible property
>   
> Changes in v3:
> - In PATCH 1/4 corrected alphabetical order of vendor-prefix and device 
> name.
> - In PATCH 2/4 inserted deprecated vendor-prefix in list in alphabetical 
> order
>   and edited vendor/chip string.
> - In PATCH 4/4 dropped deprecated string "isil,isl29028" and included 
> correct 
>   vendor-prefix isl with isl29028 to give "isl,isl29028" for device's 
> compatible
>   property.
> 
>  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>  drivers/staging/iio/light/isl29028.c  | 3 ++-
>  arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +-
>  4 files changed, 6 insertions(+), 2 deletions(-)
> 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: et131x: Remove et131x driver from drivers/staging

2014-10-04 Thread Mark Einon 
On Sat, Oct 04, 2014 at 01:37:31AM +0300, Dan Carpenter wrote:
> Congrats.  :)
> 
> regards,
> dan carpenter
> 

And thanks for all the help, both!

Cheers,

Mark
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: media: Added semicolon.

2014-10-04 Thread Stevean Raja Kumar 
Added semicolon for the line usleep_range(1, 11000);

Signed-off-by: Stevean Raja Kumar 
---
 drivers/staging/media/cxd2099/cxd2099.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/cxd2099/cxd2099.c 
b/drivers/staging/media/cxd2099/cxd2099.c
index cda1595..657ea48 100644
--- a/drivers/staging/media/cxd2099/cxd2099.c
+++ b/drivers/staging/media/cxd2099/cxd2099.c
@@ -527,7 +527,7 @@ static int slot_reset(struct dvb_ca_en50221 *ca, int slot)
u8 val;
 #endif
for (i = 0; i < 100; i++) {
-   usleep_range(1, 11000)
+   usleep_range(1, 11000);
 #if 0
read_reg(ci, 0x06, &val);
dev_info(&ci->i2c->dev, "%d:%02x\n", i, val);
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: gdm72xx: fix typo and coding style

2014-10-04 Thread Greg Kroah-Hartman 
On Tue, Sep 30, 2014 at 01:03:03PM +0200, Thibaut Robert wrote:
> Fix a typo in error message.
> Add missing curling braces to conform to coding style.
> Improve readibility.

That's three things in one patch :(

Please only do one thing per patch.

> 
> Signed-off-by: Thibaut Robert 
> ---
>  drivers/staging/gdm72xx/netlink_k.c | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/gdm72xx/netlink_k.c 
> b/drivers/staging/gdm72xx/netlink_k.c
> index 9d78bfc..31862e5 100644
> --- a/drivers/staging/gdm72xx/netlink_k.c
> +++ b/drivers/staging/gdm72xx/netlink_k.c
> @@ -71,10 +71,11 @@ static void netlink_rcv_cb(struct sk_buff *skb)
>   if (dev) {
>   rcv_cb(dev, nlh->nlmsg_type, msg, mlen);
>   dev_put(dev);
> - } else
> + } else {
>   netdev_err(skb->dev,
>  "dev_get_by_index(%d) is not 
> found.\n",
>  ifindex);
> + }
>   } else {
>   netdev_err(skb->dev, "Unregistered Callback\n");
>   }
> @@ -120,9 +121,9 @@ int netlink_send(struct sock *sock, int group, u16 type, 
> void *msg, int len)
>   struct nlmsghdr *nlh;
>   int ret = 0;
>  
> - if (group > ND_MAX_GROUP) {
> - pr_err("Group %d is invalied.\n", group);
> - pr_err("Valid group is 0 ~ %d.\n", ND_MAX_GROUP);
> + if (group < 0 || group > ND_MAX_GROUP) {

How can group be less than 0?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel