Re: [PATCH 01/15 RESEND] staging: dgnc: remove redundant NULL checks in
2016-08-17 15:25 GMT+09:00 Greg KH : > On Wed, Aug 17, 2016 at 10:05:03AM +0900, DaeSeok Youn wrote: >> 2016-08-16 2:05 GMT+09:00 Greg KH : >> > On Wed, Jul 06, 2016 at 03:11:13PM +0900, Daeseok Youn wrote: >> >> The dgnc_block_til_ready() is only used in dgnc_tty_open(). >> >> The unit data(struct un_t) was stored into tty->driver_data in >> >> dgnc_tty_open(). >> >> And also tty and un were tested about NULL so these variables doesn't >> >> need to check for NULL in dgnc_block_til_ready(). >> >> >> >> Signed-off-by: Daeseok Youn >> >> --- >> >> RESEND: This patch was not merged for a long time, if there is any reason >> >> why this patch could NOT be merged into staging tree, let me know. >> >> There were no comment for this patch. >> >> I cannot understand why this patch have to wait long time to merge. >> >> And I also sent emails to mailing-lists for reminding this patch... >> >> please let me know, what is the problem to merge this patch into staging >> >> tree. >> > >> > Please note, staging patches are at the bottom of my priority queue. >> > Combined with a vacation, conferences, and a merge window and there are >> > a lot of pending staging patches in my to-review queue. >> >> That's Ok. but I took a long time to wait for merging my patches in >> this case. :-( > > You are not alone. And what's the rush? These are just trivial staging > driver patches, it's not like you have the hardware for this device and > are needing these patches to get it to work, right? yes, you're right. Thanks. Regards, Daeseok Youn. > > thanks, > > greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH 0/2] Drivers: hv: vmbus: make bus ids in sysfs persistent
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Monday, August 15, 2016 9:11 AM > To: KY Srinivasan > Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Haiyang Zhang > > Subject: Re: [PATCH 0/2] Drivers: hv: vmbus: make bus ids in sysfs persistent > > KY Srinivasan writes: > > >> -Original Message- > >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > >> Sent: Thursday, August 11, 2016 2:17 AM > >> To: KY Srinivasan > >> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Haiyang > Zhang > >> > >> Subject: Re: [PATCH 0/2] Drivers: hv: vmbus: make bus ids in sysfs > >> persistent > >> > >> KY Srinivasan writes: > >> > >> >> -Original Message- > >> >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > >> >> Sent: Tuesday, August 9, 2016 1:46 AM > >> >> To: de...@linuxdriverproject.org > >> >> Cc: linux-ker...@vger.kernel.org; Haiyang Zhang > >> >> ; KY Srinivasan > >> >> Subject: [PATCH 0/2] Drivers: hv: vmbus: make bus ids in sysfs > >> >> persistent > >> >> > >> >> Bus ids for VMBus devices in /sys/bus/vmbus/devices/ are not > >> >> guaranteed to be persistent across reboot or kernel restart and this > >> >> causes problems for some tools. E.g. kexec tools use these ids to > >> >> identify > >> NIC on kdump. > >> >> Fix the issue by using relid from channel offer as the unique id > >> >> instead of an auto incremented counter. > >> > > >> > Relids are not persistent. It is only valid between a channel offer > >> > message and a relid released message (or an unload or initiate contact > >> > message, which invalidates all channels). This is an opaque number > >> > that the root generates and uses to track channels. There is no > >> > guarantee that the same type of channel (networking, storage, etc) > >> > will get the same relid on each reboot. > >> > > >> > >> Thanks for the info, > >> > >> can we use device_id (offermsg.offer.if_instance.b) instead? > > > > I think you could; I am going to verify and get back to you on this. > > Thanks! The instance GUID is guaranteed to be persistent between boots and also across live migration. K. Y ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
