[PATCH] staging: exfat: Fix checkpatch.pl camelcase issues

2020-03-19 Thread Aravind Ceyardass
Fix ffsCamelCase function names and mixed case enums

Signed-off-by: Aravind Ceyardass 
---
 drivers/staging/exfat/TODO  |   1 -
 drivers/staging/exfat/exfat.h   |  12 +-
 drivers/staging/exfat/exfat_super.c | 222 ++--
 3 files changed, 117 insertions(+), 118 deletions(-)

diff --git a/drivers/staging/exfat/TODO b/drivers/staging/exfat/TODO
index a283ce534cf4..51019e4431d8 100644
--- a/drivers/staging/exfat/TODO
+++ b/drivers/staging/exfat/TODO
@@ -4,7 +4,6 @@ require more work than the average checkpatch cleanup...
 Note that some of these entries may not be bugs - they're things
 that need to be looked at, and *possibly* fixed.
 
-Clean up the ffsCamelCase function names.
 
 Fix (thing)->flags to not use magic numbers - multiple offenders
 
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 4a0a481fe010..92aac0d86249 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -227,11 +227,11 @@ struct date_time_t {
 };
 
 struct vol_info_t {
-   u32  FatType;
-   u32  ClusterSize;
-   u32  NumClusters;
-   u32  FreeClusters;
-   u32  UsedClusters;
+   u32  fat_type;
+   u32  cluster_size;
+   u32  num_clusters;
+   u32  free_clusters;
+   u32  used_clusters;
 };
 
 /* directory structure */
@@ -257,7 +257,7 @@ struct file_id_t {
 struct dir_entry_t {
char name[MAX_NAME_LENGTH * MAX_CHARSET_SIZE];
u32 attr;
-   u64 Size;
+   u64 size;
u32 num_subdirs;
struct date_time_t create_timestamp;
struct date_time_t modify_timestamp;
diff --git a/drivers/staging/exfat/exfat_super.c 
b/drivers/staging/exfat/exfat_super.c
index c7bc07e91c45..46e791ac9135 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -343,7 +343,7 @@ static inline void exfat_save_attr(struct inode *inode, u32 
attr)
EXFAT_I(inode)->fid.attr = attr & (ATTR_RWMASK | ATTR_READONLY);
 }
 
-static int ffsMountVol(struct super_block *sb)
+static int ffs_mount_vol(struct super_block *sb)
 {
int i, ret;
struct pbr_sector_t *p_pbr;
@@ -439,7 +439,7 @@ static int ffsMountVol(struct super_block *sb)
return ret;
 }
 
-static int ffsUmountVol(struct super_block *sb)
+static int ffs_umount_vol(struct super_block *sb)
 {
struct fs_info_t *p_fs = &(EXFAT_SB(sb)->fs_info);
int err = 0;
@@ -479,7 +479,7 @@ static int ffsUmountVol(struct super_block *sb)
return err;
 }
 
-static int ffsGetVolInfo(struct super_block *sb, struct vol_info_t *info)
+static int ffs_get_vol_info(struct super_block *sb, struct vol_info_t *info)
 {
int err = 0;
struct fs_info_t *p_fs = &(EXFAT_SB(sb)->fs_info);
@@ -494,11 +494,11 @@ static int ffsGetVolInfo(struct super_block *sb, struct 
vol_info_t *info)
if (p_fs->used_clusters == UINT_MAX)
p_fs->used_clusters = exfat_count_used_clusters(sb);
 
-   info->FatType = EXFAT;
-   info->ClusterSize = p_fs->cluster_size;
-   info->NumClusters = p_fs->num_clusters - 2; /* clu 0 & 1 */
-   info->UsedClusters = p_fs->used_clusters;
-   info->FreeClusters = info->NumClusters - info->UsedClusters;
+   info->fat_type = EXFAT;
+   info->cluster_size = p_fs->cluster_size;
+   info->num_clusters = p_fs->num_clusters - 2; /* clu 0 & 1 */
+   info->used_clusters = p_fs->used_clusters;
+   info->free_clusters = info->num_clusters - info->used_clusters;
 
if (p_fs->dev_ejected)
err = -EIO;
@@ -509,7 +509,7 @@ static int ffsGetVolInfo(struct super_block *sb, struct 
vol_info_t *info)
return err;
 }
 
-static int ffsSyncVol(struct super_block *sb, bool do_sync)
+static int ffs_sync_vol(struct super_block *sb, bool do_sync)
 {
int err = 0;
struct fs_info_t *p_fs = &(EXFAT_SB(sb)->fs_info);
@@ -534,7 +534,7 @@ static int ffsSyncVol(struct super_block *sb, bool do_sync)
 /*  File Operation Functions*/
 /*--*/
 
-static int ffsLookupFile(struct inode *inode, char *path, struct file_id_t 
*fid)
+static int ffs_lookup_file(struct inode *inode, char *path, struct file_id_t 
*fid)
 {
int ret, dentry, num_entries;
struct chain_t dir;
@@ -619,7 +619,7 @@ static int ffsLookupFile(struct inode *inode, char *path, 
struct file_id_t *fid)
return ret;
 }
 
-static int ffsCreateFile(struct inode *inode, char *path, u8 mode,
+static int ffs_create_file(struct inode *inode, char *path, u8 mode,
 struct file_id_t *fid)
 {
struct chain_t dir;
@@ -660,7 +660,7 @@ static int ffsCreateFile(struct inode *inode, char *path, 
u8 mode,
return ret;
 }
 
-stati

Re: [PATCH] staging: exfat: Fix checkpatch.pl camelcase issues

2020-03-19 Thread Aravind Ceyardass



On 3/19/20 10:12 AM, Greg KH wrote:
> On Thu, Mar 19, 2020 at 10:06:47AM -0400, Aravind Ceyardass wrote:
>> Fix ffsCamelCase function names and mixed case enums
>>
>> Signed-off-by: Aravind Ceyardass 
>> ---
>>  drivers/staging/exfat/TODO  |   1 -
>>  drivers/staging/exfat/exfat.h   |  12 +-
>>  drivers/staging/exfat/exfat_super.c | 222 ++--
>>  3 files changed, 117 insertions(+), 118 deletions(-)
> 
> These files are not in linux-next, or in my tree, anymore.
> 
> Please always work against the latest development tree so you do not
> waste duplicated effort.
> 
> thanks,
> 
> greg k-h
> 

As a very beginner, I used the 
staging(git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git) tree 
based on what I read on kernelnewbies.org

What tree or branch should I use instead?

Thanks

Aravind
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel