[PATCH v1] staging: comedi: dmm32at: fix style issues
Before: 1 ERROR: code indent should use tabs where possible 1 WARNING: please, no spaces at the start of a line After: (none) Signed-off-by: David Decotigny --- drivers/staging/comedi/drivers/dmm32at.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c index 6df298a..1615103 100644 --- a/drivers/staging/comedi/drivers/dmm32at.c +++ b/drivers/staging/comedi/drivers/dmm32at.c @@ -363,9 +363,9 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec) outb(hi2, dev->iobase + DMM32AT_CLK2); /* enable the ai conversion interrupt and the clock to start scans */ - outb(DMM32AT_INTCLK_ADINT | -DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL, - dev->iobase + DMM32AT_INTCLK_REG); + outb(DMM32AT_INTCLK_ADINT | DMM32AT_INTCLK_CLKEN | +DMM32AT_INTCLK_CLKSEL, +dev->iobase + DMM32AT_INTCLK_REG); } static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s) -- 2.2.0.rc0.207.ga3a616c ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] staging: comedi: dmm32at: fix style issues
Before: 1 ERROR: code indent should use tabs where possible 1 WARNING: please, no spaces at the start of a line After: (none) Signed-off-by: David Decotigny --- drivers/staging/comedi/drivers/dmm32at.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c index 6df298a..31919b8 100644 --- a/drivers/staging/comedi/drivers/dmm32at.c +++ b/drivers/staging/comedi/drivers/dmm32at.c @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec) /* enable the ai conversion interrupt and the clock to start scans */ outb(DMM32AT_INTCLK_ADINT | DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL, - dev->iobase + DMM32AT_INTCLK_REG); +dev->iobase + DMM32AT_INTCLK_REG); } static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s) -- 2.2.0.rc0.207.ga3a616c ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: comedi: dmm32at: fix style issues
thanks! I have a preference for the v2 I sent: my $EDITOR handles the indentation for me; using 2 tabs forces me to manually override my editor's behavior. But if there is a strong push for a v3 of this patch with 2 tabs instead of current v2 indentation, I'll do it, please let me know. On Fri, Dec 26, 2014 at 11:00 PM, Sudip Mukherjee wrote: > On Thu, Dec 25, 2014 at 12:28:28PM -0800, David Decotigny wrote: >> Before: >> 1 ERROR: code indent should use tabs where possible >> 1 WARNING: please, no spaces at the start of a line >> >> After: >> (none) >> >> Signed-off-by: David Decotigny >> --- >> drivers/staging/comedi/drivers/dmm32at.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/comedi/drivers/dmm32at.c >> b/drivers/staging/comedi/drivers/dmm32at.c >> index 6df298a..31919b8 100644 >> --- a/drivers/staging/comedi/drivers/dmm32at.c >> +++ b/drivers/staging/comedi/drivers/dmm32at.c >> @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device >> *dev, unsigned int nansec) >> /* enable the ai conversion interrupt and the clock to start scans */ >> outb(DMM32AT_INTCLK_ADINT | >>DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL, >> - dev->iobase + DMM32AT_INTCLK_REG); >> + dev->iobase + DMM32AT_INTCLK_REG); > > another suggestion: > if you do like the following patch (use 2 tabs) then you do not need to give > spaces to indent the code. > > diff --git a/drivers/staging/comedi/drivers/dmm32at.c > b/drivers/staging/comedi/drivers/dmm32at.c > index 6df298a..cedf8ed 100644 > --- a/drivers/staging/comedi/drivers/dmm32at.c > +++ b/drivers/staging/comedi/drivers/dmm32at.c > @@ -364,8 +364,8 @@ static void dmm32at_setaitimer(struct comedi_device *dev, > unsigned int nansec) > > /* enable the ai conversion interrupt and the clock to start scans */ > outb(DMM32AT_INTCLK_ADINT | > -DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL, > - dev->iobase + DMM32AT_INTCLK_REG); > + DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL, > + dev->iobase + DMM32AT_INTCLK_REG); > } > > static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice > *s) > > > thanks > sudip > >> } >> >> static int dmm32at_ai_cmd(struct comedi_device *dev, struct >> comedi_subdevice *s) >> -- >> 2.2.0.rc0.207.ga3a616c >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v1] staging: lustre: libcfs: add __user annotation in libcfs_ioctl_data
This fixes the following sparse warnings:
drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38: warning: incorrect type
in argument 1 (different address spaces)
drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38:expected void
[noderef] *to
drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38:got struct
lnet_process_id_t [usertype] *
drivers/staging/lustre/lnet/selftest/conctl.c:833:37: warning: incorrect
type in argument 2 (different address spaces)
drivers/staging/lustre/lnet/selftest/conctl.c:833:37:expected void const
[noderef] *from
drivers/staging/lustre/lnet/selftest/conctl.c:833:37:got char *ioc_pbuf1
drivers/staging/lustre/lnet/selftest/conctl.c:918:30: warning: incorrect
type in argument 1 (different address spaces)
drivers/staging/lustre/lnet/selftest/conctl.c:918:30:expected void
[noderef] *to
drivers/staging/lustre/lnet/selftest/conctl.c:918:30:got char *ioc_pbuf2
Signed-off-by: David Decotigny
---
drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h | 4 ++--
drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 2 +-
drivers/staging/lustre/lnet/lnet/api-ni.c | 5 +++--
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
index 3ee3878..aa687b7 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
@@ -61,9 +61,9 @@ struct libcfs_ioctl_data {
char *ioc_inlbuf2;
__u32 ioc_plen1; /* buffers in userspace */
- char *ioc_pbuf1;
+ char __user *ioc_pbuf1;
__u32 ioc_plen2; /* buffers in userspace */
- char *ioc_pbuf2;
+ char __user *ioc_pbuf2;
char ioc_bulk[0];
};
diff --git a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
b/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
index 0038d29..7f06b9f7 100644
--- a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
+++ b/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
@@ -858,7 +858,7 @@ void lnet_swap_pinginfo(lnet_ping_info_t *info);
int lnet_ping_target_init(void);
void lnet_ping_target_fini(void);
int lnet_ping(lnet_process_id_t id, int timeout_ms,
- lnet_process_id_t *ids, int n_ids);
+ lnet_process_id_t __user *ids, int n_ids);
int lnet_parse_ip2nets(char **networksp, char *ip2nets);
int lnet_parse_routes(char *route_str, int *im_a_router);
diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c
b/drivers/staging/lustre/lnet/lnet/api-ni.c
index 4a14e51..1a0cd57 100644
--- a/drivers/staging/lustre/lnet/lnet/api-ni.c
+++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
@@ -1470,7 +1470,7 @@ LNetCtl(unsigned int cmd, void *arg)
id.nid = data->ioc_nid;
id.pid = data->ioc_u32[0];
rc = lnet_ping(id, data->ioc_u32[1], /* timeout */
- (lnet_process_id_t *)data->ioc_pbuf1,
+ (lnet_process_id_t __user *)data->ioc_pbuf1,
data->ioc_plen1/sizeof(lnet_process_id_t));
if (rc < 0)
return rc;
@@ -1757,7 +1757,8 @@ lnet_ping_target_fini(void)
}
int
-lnet_ping(lnet_process_id_t id, int timeout_ms, lnet_process_id_t *ids, int
n_ids)
+lnet_ping(lnet_process_id_t id, int timeout_ms,
+ lnet_process_id_t __user *ids, int n_ids)
{
lnet_handle_eq_t eqh;
lnet_handle_md_t mdh;
--
2.2.0.rc0.207.ga3a616c
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v1] staging: lustre: libcfs: add __user annotation in libcfs_ioctl_data
Thanks for reviewing.
The 2 struct members were not marked as __user, which this patch does
here. This was causing warnings with copy from/to user (see commit
description). This patch also propagates the annotation to the couple
of functions that are using those members.
On Sat, May 30, 2015 at 7:27 PM, Greg Kroah-Hartman
wrote:
> On Mon, May 25, 2015 at 09:40:04PM -0700, David Decotigny wrote:
>> This fixes the following sparse warnings:
>>drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38: warning: incorrect
>> type in argument 1 (different address spaces)
>>drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38:expected void
>> [noderef] *to
>>drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38:got struct
>> lnet_process_id_t [usertype] *
>>drivers/staging/lustre/lnet/selftest/conctl.c:833:37: warning: incorrect
>> type in argument 2 (different address spaces)
>>drivers/staging/lustre/lnet/selftest/conctl.c:833:37:expected void
>> const [noderef] *from
>>drivers/staging/lustre/lnet/selftest/conctl.c:833:37:got char
>> *ioc_pbuf1
>>drivers/staging/lustre/lnet/selftest/conctl.c:918:30: warning: incorrect
>> type in argument 1 (different address spaces)
>>drivers/staging/lustre/lnet/selftest/conctl.c:918:30:expected void
>> [noderef] *to
>> drivers/staging/lustre/lnet/selftest/conctl.c:918:30:got char
>> *ioc_pbuf2
>>
>> Signed-off-by: David Decotigny
>> ---
>> drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h | 4 ++--
>> drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 2 +-
>> drivers/staging/lustre/lnet/lnet/api-ni.c | 5 +++--
>> 3 files changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
>> b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
>> index 3ee3878..aa687b7 100644
>> --- a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
>> +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
>> @@ -61,9 +61,9 @@ struct libcfs_ioctl_data {
>> char *ioc_inlbuf2;
>>
>> __u32 ioc_plen1; /* buffers in userspace */
>> - char *ioc_pbuf1;
>> + char __user *ioc_pbuf1;
>> __u32 ioc_plen2; /* buffers in userspace */
>> - char *ioc_pbuf2;
>> + char __user *ioc_pbuf2;
>>
>> char ioc_bulk[0];
>> };
>> diff --git a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
>> b/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
>> index 0038d29..7f06b9f7 100644
>> --- a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
>> +++ b/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
>> @@ -858,7 +858,7 @@ void lnet_swap_pinginfo(lnet_ping_info_t *info);
>> int lnet_ping_target_init(void);
>> void lnet_ping_target_fini(void);
>> int lnet_ping(lnet_process_id_t id, int timeout_ms,
>> - lnet_process_id_t *ids, int n_ids);
>> + lnet_process_id_t __user *ids, int n_ids);
>>
>> int lnet_parse_ip2nets(char **networksp, char *ip2nets);
>> int lnet_parse_routes(char *route_str, int *im_a_router);
>> diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c
>> b/drivers/staging/lustre/lnet/lnet/api-ni.c
>> index 4a14e51..1a0cd57 100644
>> --- a/drivers/staging/lustre/lnet/lnet/api-ni.c
>> +++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
>> @@ -1470,7 +1470,7 @@ LNetCtl(unsigned int cmd, void *arg)
>> id.nid = data->ioc_nid;
>> id.pid = data->ioc_u32[0];
>> rc = lnet_ping(id, data->ioc_u32[1], /* timeout */
>> -(lnet_process_id_t *)data->ioc_pbuf1,
>> +(lnet_process_id_t __user *)data->ioc_pbuf1,
>
> Why is this marking needed? If so, something must be wrong as isn't
> this variable already __user now due to the other part of this patch?
>
> thanks,
>
> greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 1/2] staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness
This fixes bitwise arithmetic performed on the host on a variable
previously converted to little-endian, and subsequently converted
again to little-endian:
- issue_action_BA23a() called with "status" crafted in host byte order
- "status" converted to LE
- bitwise arithmetic on the (LE) "status", performed with masks and
shifts in host byte order
- result converted to LE (again) and stored in device structure
Sparse warning addressed by this patch:
drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3806:16: warning: incorrect
type in assignment (different base types)
drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3806:16:expected unsigned
short [unsigned] status
drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3806:16:got restricted
__le16 [usertype]
Signed-off-by: David Decotigny
---
drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index 196beaf..7c3b5dd 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
@@ -3803,8 +3803,6 @@ void issue_action_BA23a(struct rtw_adapter *padapter,
pattrib->pktlen = sizeof(struct ieee80211_hdr_3addr) + 1;
- status = cpu_to_le16(status);
-
switch (action) {
case WLAN_ACTION_ADDBA_REQ:
pattrib->pktlen += sizeof(mgmt->u.action.u.addba_req);
--
2.2.0.rc0.207.ga3a616c
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 0/2] staging: rtl8723au: core: endianness issues
The code shows a couple inconsistencies (described in commit descriptions) which would not be an issue on little-endian cpus, but could cause breakage on non-LE cpus. Note: I could not test on real hardware, these patches created based on sparse reports. # Patch Set Summary: David Decotigny (2): staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness staging: rtl8723au: core: remove redundant endianness conversion drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.2.0.rc0.207.ga3a616c ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 2/2] staging: rtl8723au: core: remove redundant endianness conversion
Source and destination have the same little-endian annotation: this patch removes forced conversion from host byte order to little-endian. This addresses the following sparse warning: drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56: warning: incorrect type in argument 1 (different base types) drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56:expected unsigned short [unsigned] [usertype] val drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56:got restricted __le16 [usertype] BA_timeout_value Signed-off-by: David Decotigny --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index 7c3b5dd..142f214 100644 --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c @@ -3906,8 +3906,8 @@ void issue_action_BA23a(struct rtw_adapter *padapter, put_unaligned_le16(BA_para_set, &mgmt->u.action.u.addba_resp.capab); - put_unaligned_le16(pmlmeinfo->ADDBA_req.BA_timeout_value, - &mgmt->u.action.u.addba_resp.timeout); + mgmt->u.action.u.addba_resp.timeout + = pmlmeinfo->ADDBA_req.BA_timeout_value; pattrib->pktlen += 8; break; -- 2.2.0.rc0.207.ga3a616c ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 1/2] staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness
This was introduced by kernel bulk commit 5e93f3520 "staging: r8723au: Add source files for new driver - part 1", initially from github according to commit description. On github, this traces back to another bulk commit: 2896bda04353 "Add new files in core directory", which is the 1st version of the driver. Not sure where to find the parent repos. PS: sorry for the incorrect To/Cc, going to resend to more appropriate recipients. On Sun, Jun 7, 2015 at 4:20 AM, Dan Carpenter wrote: > You're CC'ing all the lustre people on this by mistake. > > Can we find which patch introduced this bug, and add a Fixes: tag and > CC whoever introduced it? > > Please, resend with the correct CC list. > > regards, > dan carpenter > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 0/2] staging: rtl8723au: core: endianness issues
The code shows a couple inconsistencies (described in commit descriptions) which would not be an issue on little-endian cpus, but could cause breakage on non-LE cpus. Note: I could not test on real hardware, these patches created based on sparse reports. Hostory: - resending the same patches to correct recipients, only changed commit descriptions (credits to Dan Carpenter) # Patch Set Summary: David Decotigny (2): staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness staging: rtl8723au: core: remove redundant endianness conversion drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.2.0.rc0.207.ga3a616c ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 1/2] staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness
This fixes bitwise arithmetic performed on the host on a variable
previously converted to little-endian, and subsequently converted
again to little-endian:
- issue_action_BA23a() called with "status" crafted in host byte order
- "status" converted to LE
- bitwise arithmetic on the (LE) "status", performed with masks and
shifts in host byte order
- result converted to LE (again) and stored in device structure
Sparse warning addressed by this patch:
drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3806:16: warning: incorrect
type in assignment (different base types)
drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3806:16:expected unsigned
short [unsigned] status
drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3806:16:got restricted
__le16 [usertype]
Additional notes: initial cpu_to_le16 was introduced by kernel bulk
commit 5e93f3520 "staging: r8723au: Add source files for new driver
- part 1", initially from github according to commit description. On
github, this traces back to another bulk commit: 2896bda04353 "Add
new files in core directory", which is the 1st version of the
driver.
Signed-off-by: David Decotigny
---
drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index 196beaf..7c3b5dd 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
@@ -3803,8 +3803,6 @@ void issue_action_BA23a(struct rtw_adapter *padapter,
pattrib->pktlen = sizeof(struct ieee80211_hdr_3addr) + 1;
- status = cpu_to_le16(status);
-
switch (action) {
case WLAN_ACTION_ADDBA_REQ:
pattrib->pktlen += sizeof(mgmt->u.action.u.addba_req);
--
2.2.0.rc0.207.ga3a616c
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 2/2] staging: rtl8723au: core: remove redundant endianness conversion
Source and destination have the same little-endian annotation: this patch removes incorrect byte-swap on non-LE cpus. This addresses the following sparse warning: drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56: warning: incorrect type in argument 1 (different base types) drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56:expected unsigned short [unsigned] [usertype] val drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56:got restricted __le16 [usertype] BA_timeout_value Signed-off-by: David Decotigny --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index 7c3b5dd..142f214 100644 --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c @@ -3906,8 +3906,8 @@ void issue_action_BA23a(struct rtw_adapter *padapter, put_unaligned_le16(BA_para_set, &mgmt->u.action.u.addba_resp.capab); - put_unaligned_le16(pmlmeinfo->ADDBA_req.BA_timeout_value, - &mgmt->u.action.u.addba_resp.timeout); + mgmt->u.action.u.addba_resp.timeout + = pmlmeinfo->ADDBA_req.BA_timeout_value; pattrib->pktlen += 8; break; -- 2.2.0.rc0.207.ga3a616c ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
