Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net
Mark Einon : [...] > > No need for the #define here, just assigne et131x_pm_ops to .driver.pm > > directly, its members will be NULL and thus never called. Also, you can > > make et131x_pm_ops const. > > Ok, I can change this. > > Btw, this appears to be a fairly standard way of using .driver.pm among > ethernet drivers, e.g. see 3com/3c59x.c, atheros, marvell... - perhaps > there is a case for changing all instances of this code? How about kernel tinification ? -- Ueimor ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net
Joe Perches : > On Tue, 2014-09-23 at 21:02 +0200, Francois Romieu wrote: [...] > > How about kernel tinification ? > > The tiny case where a large number of ethernet drivers are included? No. A couple of bytes here and there vs a cosmetic kernel wide change. -- Ueimor ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] hyperv: Add netpoll support
Richard Weinberger : [...] > This won't work as netpoll runs with IRQs disabled. > ->ndo_poll_controller() has to make sure that SKBs can be received and > transmitted > while IRQs are off. I thought calling the channel callback by hand would be > enough to receive SKBs. What are you taking about ? netconsole does not need to receive. hyperv start_xmit handler almost does its own Tx completion as you have noticed. The situation is imho close to a virtual device one as was veth in bb446c19fefd7b4435adb12a9dd7666adc5b553a. -- Ueimor ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] hyperv: Add netpoll support
Richard Weinberger : > Am 09.07.2014 00:47, schrieb Francois Romieu: [...] > > What are you taking about ? netconsole does not need to receive. > > Isn't netconsole is only one user of netpoll ? Out of tree users are irrelevant. See netpoll related comments in cd6362befe4cc7bf589a5236d2a780af2d47bcc9 > Of course netconsole needs only to transmit SKBs. > But if you look at other ->ndo_poll_controller implementations > you'll notice that they care also about receiving. It's just the long, illuminating history of netpoll :o) Some limited Rx netpoll support may be done but it needs more work than was originally advertised. > > hyperv start_xmit handler almost does its own Tx completion as you have > > noticed. The situation is imho close to a virtual device one as was veth > > in bb446c19fefd7b4435adb12a9dd7666adc5b553a. > > Bad commit reference: bb446c19fefd7b4435adb12a9dd7666adc5b553a Sorry, it currently belongs to davem's net-next. -- Ueimor ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
