Re: [PATCH 1/1] staging: media: imx: imx7-mipi-csis: simplify getting .driver_data
On Tue, Mar 19, 2019 at 05:36:22PM +0100, Wolfram Sang wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Simon Horman
> ---
>
> Build tested only. buildbot is happy.
>
> drivers/staging/media/imx/imx7-mipi-csis.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c
> b/drivers/staging/media/imx/imx7-mipi-csis.c
> index 2ddcc42ab8ff..44569c63e4de 100644
> --- a/drivers/staging/media/imx/imx7-mipi-csis.c
> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
> @@ -1039,8 +1039,7 @@ static int mipi_csis_probe(struct platform_device *pdev)
>
> static int mipi_csis_pm_suspend(struct device *dev, bool runtime)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct v4l2_subdev *mipi_sd = platform_get_drvdata(pdev);
> + struct v4l2_subdev *mipi_sd = dev_get_drvdata(dev);
> struct csi_state *state = mipi_sd_to_csis_state(mipi_sd);
> int ret = 0;
>
> @@ -1064,8 +1063,7 @@ static int mipi_csis_pm_suspend(struct device *dev,
> bool runtime)
>
> static int mipi_csis_pm_resume(struct device *dev, bool runtime)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct v4l2_subdev *mipi_sd = platform_get_drvdata(pdev);
> + struct v4l2_subdev *mipi_sd = dev_get_drvdata(dev);
> struct csi_state *state = mipi_sd_to_csis_state(mipi_sd);
> int ret = 0;
>
> --
> 2.11.0
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 31/34] staging: media: soc_camera: imx074: simplify getting the adapter of a client
On Sat, Jun 08, 2019 at 12:56:10PM +0200, Wolfram Sang wrote:
> We have a dedicated pointer for that, so use it. Much easier to read and
> less computation involved.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Simon Horman
> ---
>
> Please apply to your subsystem tree.
>
> drivers/staging/media/soc_camera/imx074.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/soc_camera/imx074.c
> b/drivers/staging/media/soc_camera/imx074.c
> index d907aa62f898..14240b74cdd0 100644
> --- a/drivers/staging/media/soc_camera/imx074.c
> +++ b/drivers/staging/media/soc_camera/imx074.c
> @@ -409,7 +409,7 @@ static int imx074_probe(struct i2c_client *client,
> const struct i2c_device_id *did)
> {
> struct imx074 *priv;
> - struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent);
> + struct i2c_adapter *adapter = client->adapter;
> struct soc_camera_subdev_desc *ssdd = soc_camera_i2c_to_desc(client);
> int ret;
>
> --
> 2.19.1
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 33/34] staging: media: soc_camera: soc_mt9v022: simplify getting the adapter of a client
On Sat, Jun 08, 2019 at 12:56:12PM +0200, Wolfram Sang wrote:
> We have a dedicated pointer for that, so use it. Much easier to read and
> less computation involved.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Simon Horman
> ---
>
> Please apply to your subsystem tree.
>
> drivers/staging/media/soc_camera/soc_mt9v022.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/soc_camera/soc_mt9v022.c
> b/drivers/staging/media/soc_camera/soc_mt9v022.c
> index e7e0d3d29499..1739a618846d 100644
> --- a/drivers/staging/media/soc_camera/soc_mt9v022.c
> +++ b/drivers/staging/media/soc_camera/soc_mt9v022.c
> @@ -883,7 +883,7 @@ static int mt9v022_probe(struct i2c_client *client,
> {
> struct mt9v022 *mt9v022;
> struct soc_camera_subdev_desc *ssdd = soc_camera_i2c_to_desc(client);
> - struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent);
> + struct i2c_adapter *adapter = client->adapter;
> struct mt9v022_platform_data *pdata;
> int ret;
>
> --
> 2.19.1
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 32/34] staging: media: soc_camera: mt9t031: simplify getting the adapter of a client
On Sat, Jun 08, 2019 at 12:56:11PM +0200, Wolfram Sang wrote:
> We have a dedicated pointer for that, so use it. Much easier to read and
> less computation involved.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Simon Horman
> ---
>
> Please apply to your subsystem tree.
>
> drivers/staging/media/soc_camera/mt9t031.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/soc_camera/mt9t031.c
> b/drivers/staging/media/soc_camera/mt9t031.c
> index 615ae9df2c57..c14f23221544 100644
> --- a/drivers/staging/media/soc_camera/mt9t031.c
> +++ b/drivers/staging/media/soc_camera/mt9t031.c
> @@ -751,7 +751,7 @@ static int mt9t031_probe(struct i2c_client *client,
> {
> struct mt9t031 *mt9t031;
> struct soc_camera_subdev_desc *ssdd = soc_camera_i2c_to_desc(client);
> - struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent);
> + struct i2c_adapter *adapter = client->adapter;
> int ret;
>
> if (!ssdd) {
> --
> 2.19.1
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 5/8] staging: emxx_udc: Change platform dependency to ARCH_RENESAS
On Fri, Apr 20, 2018 at 03:28:31PM +0200, Geert Uytterhoeven wrote:
> Emma Mobile is a Renesas ARM SoC. Since commit 9b5ba0df4ea4f940 ("ARM:
> shmobile: Introduce ARCH_RENESAS") is ARCH_RENESAS a more appropriate
> platform dependency than the legacy ARCH_SHMOBILE, hence use the
> former.
>
> This will allow to drop ARCH_SHMOBILE on ARM in the near future.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Simon Horman
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 4/8] sh_eth: Change platform check to CONFIG_ARCH_RENESAS
On Fri, Apr 20, 2018 at 03:28:30PM +0200, Geert Uytterhoeven wrote:
> Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS")
> is CONFIG_ARCH_RENESAS a more appropriate platform check than the legacy
> CONFIG_ARCH_SHMOBILE, hence use the former.
>
> Renesas SuperH SH-Mobile SoCs are still covered by the CONFIG_CPU_SH4
> check.
>
> This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near
> future.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Simon Horman
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 6/8] ASoC: sh: Update menu title and platform dependency
On Fri, Apr 20, 2018 at 03:28:32PM +0200, Geert Uytterhoeven wrote:
> Change the menu title to refer to "Renesas SoCs" instead of "SuperH", as
> both SuperH and ARM SoCs are supported.
>
> Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS")
> is ARCH_RENESAS a more appropriate platform dependency for Renesas ARM
> SoCs than the legacy ARCH_SHMOBILE, hence use the former.
> Renesas SuperH SH-Mobile SoCs are still covered by the SUPERH
> dependency.
>
> This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near
> future.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Simon Horman
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/8] arm: shmobile: Change platform dependency to ARCH_RENESAS
On Fri, Apr 20, 2018 at 05:53:18PM +0300, Sergei Shtylyov wrote:
> On 04/20/2018 04:28 PM, Geert Uytterhoeven wrote:
>
> > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS")
> > is ARCH_RENESAS a more appropriate platform dependency than the legacy
>
>"ARCH_RENESAS is", no?
Thanks, applied with that corrected.
>
> > ARCH_SHMOBILE, hence use the former.
> >
> > This will allow to drop ARCH_SHMOBILE on ARM in the near future.
> >
> > Signed-off-by: Geert Uytterhoeven
> [...]
>
> MBR, Sergei
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 3/8] [media] v4l: rcar_fdp1: Change platform dependency to ARCH_RENESAS
On Fri, Apr 20, 2018 at 03:28:29PM +0200, Geert Uytterhoeven wrote:
> The Renesas Fine Display Processor driver is used on Renesas R-Car SoCs
> only. Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce
> ARCH_RENESAS") is ARCH_RENESAS a more appropriate platform dependency
> than the legacy ARCH_SHMOBILE, hence use the former.
>
> This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near
> future.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Simon Horman
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/8] dmaengine: shdmac: Change platform check to CONFIG_ARCH_RENESAS
On Fri, Apr 20, 2018 at 03:28:28PM +0200, Geert Uytterhoeven wrote:
> Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS")
> is CONFIG_ARCH_RENESAS a more appropriate platform check than the legacy
> CONFIG_ARCH_SHMOBILE, hence use the former.
>
> Renesas SuperH SH-Mobile SoCs are still covered by the CONFIG_CPU_SH4
> check, just like before support for Renesas ARM SoCs was added.
>
> Instead of blindly changing all the #ifdefs, switch the main code block
> in sh_dmae_probe() to IS_ENABLED(), as this allows to remove all the
> remaining #ifdefs.
>
> This will allow to drop ARCH_SHMOBILE on ARM in the near future.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Simon Horman
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH/RFC 7/8] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol
On Fri, Apr 20, 2018 at 03:28:33PM +0200, Geert Uytterhoeven wrote:
> All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS
> platform dependencies. Hence finish the conversion from ARCH_SHMOBILE
> to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit
> 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS").
>
> Signed-off-by: Geert Uytterhoeven
> ---
> This depends on the previous patches in this series, hence the RFC.
>
> JFTR, after this, the following symbols for drivers supporting only
> Renesas SuperH "SH-Mobile" SoCs can no longer be selected:
> - CONFIG_KEYBOARD_SH_KEYSC,
> - CONFIG_VIDEO_SH_VOU,
> - CONFIG_VIDEO_SH_MOBILE_CEU,
> - CONFIG_DRM_SHMOBILE[*],
> - CONFIG_FB_SH_MOBILE_MERAM.
> (changes for a shmobile_defconfig .config)
>
> [*] CONFIG_DRM_SHMOBILE has a dependency on ARM, but it was never wired
> up. From the use of sh_mobile_meram, I guess it was meant for
> SH-Mobile AP4 on Mackerel or AP4EVB, which are long gone.
> So the only remaining upstream platforms that could make use of it
> are legacy SuperH SH-Mobile SoCs?
That sounds about right. If there is interest I can sift through my mail
archive and see if it yields any answers.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH/RFC 7/8] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol
On Fri, Apr 20, 2018 at 03:28:33PM +0200, Geert Uytterhoeven wrote:
> All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS
> platform dependencies. Hence finish the conversion from ARCH_SHMOBILE
> to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit
> 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS").
>
> Signed-off-by: Geert Uytterhoeven
> ---
> This depends on the previous patches in this series, hence the RFC.
Thanks, I have marked this and the following patch as deferred.
Please repost or otherwise ping me once the dependencies are in place.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/6] Revert "staging: board: disable as it breaks the build"
On Tue, Apr 07, 2015 at 03:16:54PM +0200, Geert Uytterhoeven wrote:
> On Mon, Apr 6, 2015 at 2:40 AM, Simon Horman wrote:
> > On Fri, Apr 03, 2015 at 02:41:58PM +0200, Geert Uytterhoeven wrote:
> >> This reverts commit d13778d537a0ed6115d2a79a942af999cfb8eec6.
> >>
> >> Commit 13c11072536f2613 ("staging:board: remove unnecessary function")
> >> fixed the build of drivers/staging/board/board.c.
> >>
> >> Signed-off-by: Geert Uytterhoeven
> >
> > Signed-off-by: Simon Horman
>
> Acked-by? Reviewed-by? Tested-by? Rejected-by?
To be honest I was flipping between Signed-off-by and Acked-by.
But it seems you don't think either of those would be appropriate.
So how about:
Reviewed-by: Simon Horman
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 0/7] staging: board: armadillo800eva: Board staging for sh_mobile_lcdc_fb
On Wed, Jun 17, 2015 at 10:38:49AM +0200, Geert Uytterhoeven wrote:
> Hi Greg, Simon, Magnus,
>
> This patch series adds board staging support for the Renesas R-Mobile A1
> (r8a7740) based Armadillo-800 EVA board. It allows to support the frame
> buffer device for the on-board LCD (which isn't supported by a DT-aware
> driver yet) in modern DT-based multi-platform kernels.
>
> The board staging area was introduced last year to allow continuous
> upstream in-tree development and integration of platform devices. It
> helps developers integrate devices as platform devices for device
> drivers that only provide platform device bindings. This in turn allows
> for incremental development of both hardware feature support and DT
> binding work in parallel.
>
> The goal is to complete the move to ARM multi-platform kernels for all
> shmobile platforms, and drop the existing board files
> (arch/arm/mach-shmobile/board-*). Once this series is accepted, more
> than 3000 lines of legacy armadillo board code and r8a7740 SoC code can
> be removed.
>
> This series consists of 5 parts:
> - Patch 1 re-enables compilation of the board staging area, which was
> disabled after a compile breakage, but has been fixed in the mean
> time,
> - Path 2 moves initialization of staging board code to an earlier
> moment, as currently it happens after unused PM domains are powered
> down,
> - Patches 3 and 4 (hopefully) fix the existing kzm9d board staging
> code, which was presumably "broken" by commit 9a1091ef0017c40a
> ("irqchip: gic: Support hierarchy irq domain."),
> - Patches 5 and 6 add support for registering platform devices with
> complex dependencies (clocks and PM domains), and add armadillo
> board staging code for enabling a frame buffer on the on-board LCD,
> - Patch 7 (new) adds pinctrl and gpio-hog configuration to enable the
> LCD.
>
> The first 6 patches should go in through the staging tree, the last one
> through the shmobile tree.
>
> Major changes since v1 (more detailed changelogs in the individual
> patches):
> - Add support for low/high edge/level interrupts in hwirq translation,
> - Move pinctrl and GPIO configuration from board staging code to DT,
> - Use clk_add_alias() instead of open coding.
>
> Dependencies:
> - This is against next-20150617,
> - The gpio-hog in patch 7 depends on a bug fix like "[PATCH] [RFC]
> gpio: Retry deferred GPIO hogging on pin range change"
> (https://lkml.org/lkml/2015/6/16/455). It can be applied as-is
> though.
>
> This was tested on r8a7740/armadillo.
> This was not tested on emev2/kzm9d, due to lack of hardware.
I have verified that kzm9d still boots with your patches applied on top
of renesas-devel-20150617-v4.1-rc8. I used shmobile_defconfig and
then enabled CONFIG_STAGING and in turn CONFIG_STAGING_BOARD.
Let me know if you think further testing is appropriate.
> Thanks for applying!
>
> Geert Uytterhoeven (7):
> Revert "staging: board: disable as it breaks the build"
> staging: board: Initialize staging board code earlier
> staging: board: Add support for translating hwirq to virq numbers
> staging: board: kzm9d: Translate hwirq numbers to virq numbers
> staging: board: Add support for devices with complex dependencies
> staging: board: armadillo800eva: Board staging for sh_mobile_lcdc_fb
Feel free to add:
Acked-by: Simon Horman
to the above.
> ARM: shmobile: armadillo800eva dts: Add pinctrl and gpio-hog for lcdc0
>
> arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 13 +++
> drivers/staging/board/Kconfig | 1 -
> drivers/staging/board/Makefile| 3 +-
> drivers/staging/board/armadillo800eva.c | 105
> drivers/staging/board/board.c | 136
> ++
> drivers/staging/board/board.h | 27 -
> drivers/staging/board/kzm9d.c | 10 +-
> 7 files changed, 290 insertions(+), 5 deletions(-)
> create mode 100644 drivers/staging/board/armadillo800eva.c
>
> --
> 1.9.1
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 7/7] ARM: shmobile: armadillo800eva dts: Add pinctrl and gpio-hog for lcdc0
On Wed, Jun 17, 2015 at 10:38:56AM +0200, Geert Uytterhoeven wrote: > Configure pinctrl and a GPIO-controller board mux for LCD use. > This allows the armadillo800eva board staging code to enable lcdc0. > > Signed-off-by: Geert Uytterhoeven Thanks Geert, As Greg has now taken patches 1 - 6 I have queued this up. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/6] Revert "staging: board: disable as it breaks the build"
On Fri, Apr 03, 2015 at 02:41:58PM +0200, Geert Uytterhoeven wrote:
> This reverts commit d13778d537a0ed6115d2a79a942af999cfb8eec6.
>
> Commit 13c11072536f2613 ("staging:board: remove unnecessary function")
> fixed the build of drivers/staging/board/board.c.
>
> Signed-off-by: Geert Uytterhoeven
Signed-off-by: Simon Horman
> ---
> drivers/staging/board/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/board/Kconfig b/drivers/staging/board/Kconfig
> index 0a89ad16371f7ded..b8ee81840666ad35 100644
> --- a/drivers/staging/board/Kconfig
> +++ b/drivers/staging/board/Kconfig
> @@ -1,7 +1,6 @@
> config STAGING_BOARD
> bool "Staging Board Support"
> depends on OF_ADDRESS
> - depends on BROKEN
> help
> Select to enable per-board staging support code.
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 04/05] staging: board: Initial board staging support
On Thu, May 29, 2014 at 10:27:30PM +0900, Magnus Damm wrote: > Hi Dan, > > On Thu, May 29, 2014 at 10:20 PM, Dan Carpenter > wrote: > > On Thu, May 29, 2014 at 10:17:32PM +0900, Magnus Damm wrote: > >> --- /dev/null > >> +++ work/drivers/staging/board/Kconfig2014-05-29 > >> 21:40:41.0 +0900 > >> @@ -0,0 +1,7 @@ > >> +config STAGING_BOARD > >> + boolean "Staging Board Support" > >> + help > >> + Select to enable per-board staging support code. > >> + > >> + If in doubt, say N here. > >> + > > > > Actually, you're probably going to need to add a bunch of dependencies > > here or it will break "make randconfig" right away. Sorry that I forgot > > about this in the first review. > > Good point, thanks for checking. I will have a look at this and add > dependencies to make sure it builds on a wide range of platforms. Hi Magnus, let me know if you would like me to perform some build-testing. > Regarding the emxx_udc portion of the patches (in the v2 series patch > 1 -> 3), if there are no objections would it be possible for you to > take them as-is? If so I'll resend the staging board bits only. > > Thanks! > > / magnus > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 04/05] staging: board: Initial board staging support
On Fri, Jun 06, 2014 at 09:07:44PM +0900, Magnus Damm wrote: > On Fri, May 30, 2014 at 8:10 AM, Simon Horman wrote: > > On Thu, May 29, 2014 at 10:27:30PM +0900, Magnus Damm wrote: > >> Hi Dan, > >> > >> On Thu, May 29, 2014 at 10:20 PM, Dan Carpenter > >> wrote: > >> > On Thu, May 29, 2014 at 10:17:32PM +0900, Magnus Damm wrote: > >> >> --- /dev/null > >> >> +++ work/drivers/staging/board/Kconfig2014-05-29 > >> >> 21:40:41.0 +0900 > >> >> @@ -0,0 +1,7 @@ > >> >> +config STAGING_BOARD > >> >> + boolean "Staging Board Support" > >> >> + help > >> >> + Select to enable per-board staging support code. > >> >> + > >> >> + If in doubt, say N here. > >> >> + > >> > > >> > Actually, you're probably going to need to add a bunch of dependencies > >> > here or it will break "make randconfig" right away. Sorry that I forgot > >> > about this in the first review. > >> > >> Good point, thanks for checking. I will have a look at this and add > >> dependencies to make sure it builds on a wide range of platforms. > > > > Hi Magnus, > > > > let me know if you would like me to perform some build-testing. > > Hey Simon, > > Thanks for the offer. When you have time, can you please feed V3 into > your build test setup? > > [PATCH v3 00/05] staging: Emma Mobile USB driver and KZM9D board code V3 > [PATCH v3 01/05] staging: emxx_udc: Add Emma Mobile USB Gadget driver > [PATCH v3 02/05] staging: emxx_udc: I/O memory and IRQ resource support > [PATCH v3 03/05] staging: emxx_udc: Add TODO file > [PATCH v3 04/05] staging: board: Initial board staging support > [PATCH v3 05/05] staging: board: kzm9d: Board staging support for emxx_udc Hi Magnus, my test was less exciting as I had hoped as STAGING is not widely enabled in defconfigs. I compiled v3.15-rc8 with the patches above applied using the defconfigs and allmodconfigs for a wide range of architectures. The result was that all of the configs that built for v3.15-rc8 also built with your patches applied. In other words, I did not find a problem. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 00/05] staging: Emma Mobile USB driver and KZM9D board code V3
On Mon, Jun 09, 2014 at 02:14:38PM +0900, Magnus Damm wrote: > On Sat, Jun 7, 2014 at 12:39 AM, Greg KH wrote: > > On Fri, Jun 06, 2014 at 07:44:08PM +0900, Magnus Damm wrote: > >> staging: Emma Mobile USB driver and KZM9D board code V3 > >> > >> [PATCH v3 01/05] staging: emxx_udc: Add Emma Mobile USB Gadget driver > >> [PATCH v3 02/05] staging: emxx_udc: I/O memory and IRQ resource support > >> [PATCH v3 03/05] staging: emxx_udc: Add TODO file > >> [PATCH v3 04/05] staging: board: Initial board staging support > >> [PATCH v3 05/05] staging: board: kzm9d: Board staging support for emxx_udc > >> > >> This patch series is V3 of the old USB Gadget driver for Emma Mobile > >> that gets slightly adjusted to make use of the platform device interface > >> which in turn is used to add USB Gadget support to the KZM9D board. > >> > >> Two separate staging components are included in this series: > >> 1) the emxx_udc driver - from out-of-tree Android 2.6.35.7 > >> 2) board staging support for KZM9D - platform device for DT-only KZM9D > >> > >> The two components above will be used to continously improve the driver > >> and board integration code until the driver can be moved out of staging > >> and/or DT bindings are available so the board staging platform device code > >> can be replaced with a DT node. > >> > >> Changes since V2: > >> - Added CONFIG_OF_ADDRESS dependency for the board staging bits > >> > >> Changes since V1: > >> - Added TODO file for emxx_udc > >> - Broke out board staging base support, included TODO file > >> - Added code to avoid registering platform device if DT node exists > >> - Modified KZM9D board code build condition to use SoC Kconfig entry > >> > >> Many thanks to Dan Carpenter, Geert Uytterhoeven, Greg KH and > >> Paul Bolle for feedback! > >> > >> Please let me know if you would like me to rebase this code somehow. > > > > At quick glance, this looks good. I'll queue it up after 3.16-rc1 is > > out as it's too late for this merge window. > > Thanks, Greg! This sounds perfect to me! FWIW, Acked-by: Simon Horman ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/94] ARM: shmobile: Add DT and defconfigs to MAINTAINERS
On Tue, Jul 15, 2014 at 10:05:30AM -0700, Greg KH wrote: > On Tue, Jul 15, 2014 at 07:53:07PM +0300, Sam Asadi wrote: > > From: Simon Horman > > > > There are a number of DT and defconfig files which > > are maintained as part of shmobile but have not been > > listed as such in the MAINTAINERS file. This creates > > confusion from time to time. > > > > Signed-off-by: Simon Horman > > Signed-off-by: sam-the-6 > > Really? We need a "real" name here. > > And why are you passing on Simon's patches, why would I care about this > patch to the MAINTAINERS file? > > confused, I'm also a little confused as this same patch is sitting in my tree and has been queued up for v3.17 by in the arm-soc tree. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [staging:staging-testing 36/53] drivers/staging/rtl8192e/rtllib_crypt_tkip.c:640:7: warning: variable 'iv16' set but not used
On Fri, Aug 23, 2024 at 08:35:15PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 5315266844ea3b0b8b6be9842d5901e439fa838a > commit: 5f1a6826ea4900f8540d5eeb29f97796860f2d08 [36/53] staging: rtl8192e: > remove set but otherwise unused local variable iv32 > config: x86_64-allyesconfig > (https://download.01.org/0day-ci/archive/20240823/202408232049.ujef268y-...@intel.com/config) > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project > 617a15a9eac96088ae5e9134248d8236e34b91b1) > reproduce (this is a W=1 build): > (https://download.01.org/0day-ci/archive/20240823/202408232049.ujef268y-...@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version > of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: > https://lore.kernel.org/oe-kbuild-all/202408232049.ujef268y-...@intel.com/ > > All warnings (new ones prefixed by >>): > > >> drivers/staging/rtl8192e/rtllib_crypt_tkip.c:640:7: warning: variable > >> 'iv16' set but not used [-Wunused-but-set-variable] > 640 | u16 iv16 = tkey->tx_iv16; > | ^ >1 warning generated. Sorry about this. It seems that my patch, cited above, which removed a set but otherwise unused variable results in iv16 being set but otherwise unused. I'll prepare a follow-up patch to address this. ... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [staging:staging-testing 36/53] drivers/staging/rtl8192e/rtllib_crypt_tkip.c:640:7: warning: variable 'iv16' set but not used
On Fri, Aug 23, 2024 at 06:16:49PM +0100, Simon Horman wrote: > On Fri, Aug 23, 2024 at 08:35:15PM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > staging-testing > > head: 5315266844ea3b0b8b6be9842d5901e439fa838a > > commit: 5f1a6826ea4900f8540d5eeb29f97796860f2d08 [36/53] staging: rtl8192e: > > remove set but otherwise unused local variable iv32 > > config: x86_64-allyesconfig > > (https://download.01.org/0day-ci/archive/20240823/202408232049.ujef268y-...@intel.com/config) > > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project > > 617a15a9eac96088ae5e9134248d8236e34b91b1) > > reproduce (this is a W=1 build): > > (https://download.01.org/0day-ci/archive/20240823/202408232049.ujef268y-...@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new > > version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: > > https://lore.kernel.org/oe-kbuild-all/202408232049.ujef268y-...@intel.com/ > > > > All warnings (new ones prefixed by >>): > > > > >> drivers/staging/rtl8192e/rtllib_crypt_tkip.c:640:7: warning: variable > > >> 'iv16' set but not used [-Wunused-but-set-variable] > > 640 | u16 iv16 = tkey->tx_iv16; > > | ^ > >1 warning generated. > > Sorry about this. > > It seems that my patch, cited above, which removed a set but otherwise > unused variable results in iv16 being set but otherwise unused. > > I'll prepare a follow-up patch to address this. Patch is here: - [PATCH] staging: rtl8192e: remove set but otherwise unused local variable iv16 https://lore.kernel.org/linux-staging/20240823-rtl8192e-iv16-v1-1-000702673...@kernel.org/T/#u ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
