[PATCH] Staging: emxx_udc: emxx_udc: Fixed a coding style error
Removed unnecessary parentheses. Signed-off-by: Will Cunningham --- drivers/staging/emxx_udc/emxx_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index a913d40f0801..80a906742cdc 100644 --- a/drivers/staging/emxx_udc/emxx_udc.c +++ b/drivers/staging/emxx_udc/emxx_udc.c @@ -136,7 +136,7 @@ static void _nbu2ss_ep0_complete(struct usb_ep *_ep, struct usb_request *_req) struct usb_ctrlrequest *p_ctrl; struct nbu2ss_udc *udc; - if ((!_ep) || (!_req)) + if (!_ep || !_req) return; udc = (struct nbu2ss_udc *)_req->context; -- 2.19.2 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: greybus: usb: Fixed a coding style error
Line was >80 characters.
Signed-off-by: Will Cunningham
---
drivers/staging/greybus/usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c
index 1c246c73a085..5b4cbec88159 100644
--- a/drivers/staging/greybus/usb.c
+++ b/drivers/staging/greybus/usb.c
@@ -169,8 +169,8 @@ static int gb_usb_probe(struct gbphy_device *gbphy_dev,
return -ENOMEM;
connection = gb_connection_create(gbphy_dev->bundle,
-
le16_to_cpu(gbphy_dev->cport_desc->id),
- NULL);
+ le16_to_cpu(gbphy_dev->cport_desc->id),
+ NULL);
if (IS_ERR(connection)) {
retval = PTR_ERR(connection);
goto exit_usb_put;
--
2.19.2
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style error.
Removed unnecessary parentheses.`
Signed-off-by: Will Cunningham
---
drivers/staging/comedi/drivers/pcl818.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c
b/drivers/staging/comedi/drivers/pcl818.c
index 0af5315d4357..da5d53a288f7 100644
--- a/drivers/staging/comedi/drivers/pcl818.c
+++ b/drivers/staging/comedi/drivers/pcl818.c
@@ -1012,7 +1012,7 @@ static int pcl818_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
pcl818_alloc_dma(dev, it->options[2]);
/* use 1MHz or 10MHz oscilator */
- if ((it->options[3] == 0) || (it->options[3] == 10))
+ if (it->options[3] == 0 || it->options[3] == 10)
osc_base = I8254_OSC_BASE_10MHZ;
else
osc_base = I8254_OSC_BASE_1MHZ;
@@ -1026,7 +1026,7 @@ static int pcl818_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
devpriv->ns_min = board->ns_min;
if (!board->is_818) {
/* extended PCL718 to 100kHz DAC */
- if ((it->options[6] == 1) || (it->options[6] == 100))
+ if (it->options[6] == 1 || it->options[6] == 100)
devpriv->ns_min = 1;
}
@@ -1067,12 +1067,12 @@ static int pcl818_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
s->maxdata = 0x0fff;
s->range_table = &range_unipolar5;
if (board->is_818) {
- if ((it->options[4] == 1) || (it->options[4] == 10))
+ if (it->options[4] == 1 || it->options[4] == 10)
s->range_table = &range_unipolar10;
if (it->options[4] == 2)
s->range_table = &range_unknown;
} else {
- if ((it->options[5] == 1) || (it->options[5] == 10))
+ if (it->options[5] == 1 || it->options[5] == 10)
s->range_table = &range_unipolar10;
if (it->options[5] == 2)
s->range_table = &range_unknown;
--
2.19.2
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] Staging: comedi: drivers: pcl818: Fixed a coding style error.
Removed unnecessary parentheses.
Signed-off-by: Will Cunningham
---
Changes in v2:
- Removed a typo from the commit message.
---
drivers/staging/comedi/drivers/pcl818.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c
b/drivers/staging/comedi/drivers/pcl818.c
index 0af5315d4357..da5d53a288f7 100644
--- a/drivers/staging/comedi/drivers/pcl818.c
+++ b/drivers/staging/comedi/drivers/pcl818.c
@@ -1012,7 +1012,7 @@ static int pcl818_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
pcl818_alloc_dma(dev, it->options[2]);
/* use 1MHz or 10MHz oscilator */
- if ((it->options[3] == 0) || (it->options[3] == 10))
+ if (it->options[3] == 0 || it->options[3] == 10)
osc_base = I8254_OSC_BASE_10MHZ;
else
osc_base = I8254_OSC_BASE_1MHZ;
@@ -1026,7 +1026,7 @@ static int pcl818_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
devpriv->ns_min = board->ns_min;
if (!board->is_818) {
/* extended PCL718 to 100kHz DAC */
- if ((it->options[6] == 1) || (it->options[6] == 100))
+ if (it->options[6] == 1 || it->options[6] == 100)
devpriv->ns_min = 1;
}
@@ -1067,12 +1067,12 @@ static int pcl818_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
s->maxdata = 0x0fff;
s->range_table = &range_unipolar5;
if (board->is_818) {
- if ((it->options[4] == 1) || (it->options[4] == 10))
+ if (it->options[4] == 1 || it->options[4] == 10)
s->range_table = &range_unipolar10;
if (it->options[4] == 2)
s->range_table = &range_unknown;
} else {
- if ((it->options[5] == 1) || (it->options[5] == 10))
+ if (it->options[5] == 1 || it->options[5] == 10)
s->range_table = &range_unipolar10;
if (it->options[5] == 2)
s->range_table = &range_unknown;
--
2.19.2
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] Staging: greybus: usb: Fixed a coding style error
Line was >80 characters.
Signed-off-by: Will Cunningham
---
Changes in v2:
- Created a tmp variable to shorten line length.
---
drivers/staging/greybus/usb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c
index 1c246c73a085..c09793b48850 100644
--- a/drivers/staging/greybus/usb.c
+++ b/drivers/staging/greybus/usb.c
@@ -163,14 +163,14 @@ static int gb_usb_probe(struct gbphy_device *gbphy_dev,
struct gb_usb_device *gb_usb_dev;
struct usb_hcd *hcd;
int retval;
+ u16 tmp;
hcd = usb_create_hcd(&usb_gb_hc_driver, dev, dev_name(dev));
if (!hcd)
return -ENOMEM;
- connection = gb_connection_create(gbphy_dev->bundle,
-
le16_to_cpu(gbphy_dev->cport_desc->id),
- NULL);
+ tmp = le16_to_cpu(gbphy_dev->cport_desc->id);
+ connection = gb_connection_create(gbphy_dev->bundle, tmp, NULL);
if (IS_ERR(connection)) {
retval = PTR_ERR(connection);
goto exit_usb_put;
--
2.19.2
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
