dbclient reports integrity errors with GitHub

2015-04-22 Thread Laurent Bercot


 Hello,
 dropbear-2015.67, compiled with a recent (last week) musl libc,
statically linked.
 The problem also occurs with dropbear-2014.66.

 Since a few days ago (but I'm not sure when it started; in any
case it's less than a month ago), every git pull and push over SSH
from/to GitHub fails with the following message:

dbclient: Connection to g...@github.com:22 exited: Integrity error (bad packet 
size $N)

$N is a nonsensical number, sometimes negative, but not always.

 Connections to GitHub via the OpenSSH client *work*.
 Connections to git repositories other than GitHub via dbclient *work*.
 Connections to GitHub via dbclient *do not work*, whether my client
key is ECDSA or RSA. I don't use DSA.

 Any idea of what's going on or what I could do to learn more ?
It's probably a GitHub problem, but I figured I had more chances of
finding knowledgeable people here :)

 Thanks,

--
 Laurent


Re: dbclient reports integrity errors with GitHub

2015-04-22 Thread Steven Honeyman
On 22 April 2015 at 15:39, Laurent Bercot ska-dietl...@skarnet.org wrote:

  Hello,
  dropbear-2015.67, compiled with a recent (last week) musl libc,
 statically linked.
  The problem also occurs with dropbear-2014.66.

  Since a few days ago (but I'm not sure when it started; in any
 case it's less than a month ago), every git pull and push over SSH
 from/to GitHub fails with the following message:

 dbclient: Connection to g...@github.com:22 exited: Integrity error (bad
 packet size $N)

 $N is a nonsensical number, sometimes negative, but not always.

  Connections to GitHub via the OpenSSH client *work*.
  Connections to git repositories other than GitHub via dbclient *work*.
  Connections to GitHub via dbclient *do not work*, whether my client
 key is ECDSA or RSA. I don't use DSA.

  Any idea of what's going on or what I could do to learn more ?
 It's probably a GitHub problem, but I figured I had more chances of
 finding knowledgeable people here :)

  Thanks,

 --
  Laurent

Hmm strange! I get the exact same behaviour with both musl and glibc,
so it's likely a dropbear problem.

Steven


Re: dbclient reports integrity errors with GitHub

2015-04-22 Thread Laurent Bercot

On 23/04/2015 02:03, Matt Johnston wrote:

I think its because their version of libssh ignores one of the protocol flags, 
fixed in libssh 0.6.4. I'll send an email to github.

https://git.libssh.org/projects/libssh.git/commit/?id=eb86fd8cdfd69f46c60bf0885a2125285e4a22b3


 Thanks for your quick answer! I hope their reaction time will be as quick.
(One can dream.)

--
 Laurent



Re: dbclient reports integrity errors with GitHub

2015-04-22 Thread Matt Johnston
It sounds like something's going wrong with the cryptographic key setup. The 
packet size is the first thing decrypted so if they key is wrong the size will 
be wrong.

I'll investigate what's going on, sounds like its easy to reproduce.

Cheers,
Matt

On 22 April 2015 11:16:36 pm AWST, Steven Honeyman stevenhoney...@gmail.com 
wrote:
On 22 April 2015 at 15:39, Laurent Bercot ska-dietl...@skarnet.org
wrote:

  Hello,
  dropbear-2015.67, compiled with a recent (last week) musl libc,
 statically linked.
  The problem also occurs with dropbear-2014.66.

  Since a few days ago (but I'm not sure when it started; in any
 case it's less than a month ago), every git pull and push over SSH
 from/to GitHub fails with the following message:

 dbclient: Connection to g...@github.com:22 exited: Integrity error
(bad
 packet size $N)

 $N is a nonsensical number, sometimes negative, but not always.

  Connections to GitHub via the OpenSSH client *work*.
  Connections to git repositories other than GitHub via dbclient
*work*.
  Connections to GitHub via dbclient *do not work*, whether my client
 key is ECDSA or RSA. I don't use DSA.

  Any idea of what's going on or what I could do to learn more ?
 It's probably a GitHub problem, but I figured I had more chances of
 finding knowledgeable people here :)

  Thanks,

 --
  Laurent

Hmm strange! I get the exact same behaviour with both musl and glibc,
so it's likely a dropbear problem.

Steven