[Dspace-devel] [DSJ] Updated: (DS-544) Removal of mapped items can lead to NPE

2010-04-16 Thread Kim Shepherd (JIRA)

 [ 
http://jira.dspace.org/jira/browse/DS-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kim Shepherd updated DS-544:


Fix Version/s: 1.7
   1.6.1

> Removal of mapped items can lead to NPE
> ---
>
> Key: DS-544
> URL: http://jira.dspace.org/jira/browse/DS-544
> Project: DSpace 1.x
>  Issue Type: Bug
>  Components: JSPUI
>Affects Versions: 1.6.0
>Reporter: Claudia Jürgen
>Assignee: Kim Shepherd
>Priority: Minor
> Fix For: 1.6.1, 1.7
>
>
> When clicking "remove" on the list  of mapped items without having selected 
> an item, leads to an internal error due to a NPE.
> This should be handled more graceful.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

   

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel


[Dspace-devel] [DSJ] Updated: (DS-544) Removal of mapped items can lead to NPE

2010-05-13 Thread Kim Shepherd (JIRA)

 [ 
http://jira.dspace.org/jira/browse/DS-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kim Shepherd updated DS-544:


Attachment: DS-544.patch

Attached patch which makes the following changes:

org.dspace.app.webui.servlet.admin.ItemMapServlet:
--
* If ItemsID[] is null, add a "none-removed" message and skip attempt at 
removing mapping (this is how the "Add" action was handled already)
* Remove some old, obselete code for "add" action that's been commented out for 
a long time, to tidy up ItemMapServlet

itemmap-info.jsp:
--
* Add handling for the "none-removed" message in itemmap-info.jsp

Messages.properties:
--
* Add a new i18n key: 
jsp.tools.itemmap-info.msg.none-removed  = No items selected, none removed.


Tested and committed to trunk and dspace-1.6.x branch

> Removal of mapped items can lead to NPE
> ---
>
> Key: DS-544
> URL: http://jira.dspace.org/jira/browse/DS-544
> Project: DSpace 1.x
>  Issue Type: Bug
>  Components: JSPUI
>Affects Versions: 1.6.0
>Reporter: Claudia Jürgen
>Assignee: Kim Shepherd
>Priority: Minor
> Fix For: 1.6.1, 1.7
>
> Attachments: DS-544.patch
>
>
> When clicking "remove" on the list  of mapped items without having selected 
> an item, leads to an internal error due to a NPE.
> This should be handled more graceful.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

   

--

___
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel