[Dspace-devel] [DuraSpace JIRA] Commented: (DS-898) Caching error in browse, search and discovery results
[ https://jira.duraspace.org/browse/DS-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20343#action_20343 ] Hardy Pottinger commented on DS-898: Hi, I've confirmed that, with the revised patch, searching no longer throws NPEs, and have put the code into production in our repository. Thanks to the quick response from everyone, we have a great community here! > Caching error in browse, search and discovery results > - > > Key: DS-898 > URL: https://jira.duraspace.org/browse/DS-898 > Project: DSpace > Issue Type: Bug > Components: XMLUI >Affects Versions: 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1 >Reporter: Ben Bosman >Assignee: Ben Bosman >Priority: Major > Fix For: 1.8.0 > > > The results page for browse, search and discovery uses caching based on the > validity. This validity takes the listed items into account. It doesn't take > the amount of results into account however. > The total amount of results is incorrect if the page was rendered before, and > the same list of items is returned, but some items are added or removed which > are not displayed on the current page -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.duraspace.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel
[Dspace-devel] [DuraSpace JIRA] Commented: (DS-898) Caching error in browse, search and discovery results
[ https://jira.duraspace.org/browse/DS-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20337#action_20337 ] Ben Bosman commented on DS-898: --- I was able to verify there was an error pasting the changes to the AbstractSearch class. I moved the lines to the correct location now. > Caching error in browse, search and discovery results > - > > Key: DS-898 > URL: https://jira.duraspace.org/browse/DS-898 > Project: DSpace > Issue Type: Bug > Components: XMLUI >Affects Versions: 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1 >Reporter: Ben Bosman >Assignee: Ben Bosman >Priority: Major > Fix For: 1.8.0 > > > The results page for browse, search and discovery uses caching based on the > validity. This validity takes the listed items into account. It doesn't take > the amount of results into account however. > The total amount of results is incorrect if the page was rendered before, and > the same list of items is returned, but some items are added or removed which > are not displayed on the current page -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.duraspace.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel
[Dspace-devel] [DuraSpace JIRA] Commented: (DS-898) Caching error in browse, search and discovery results
[ https://jira.duraspace.org/browse/DS-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20334#action_20334 ] Peter Dietz commented on DS-898: @Hardy, See the commit to trunk/1.8 for your patch: Pretty: https://github.com/DSpace/DSpace/commit/9a907b0f5ebabb7686d982f3213443a659a7a359 Diff/patch: https://github.com/DSpace/DSpace/commit/9a907b0f5ebabb7686d982f3213443a659a7a359.diff @Mark and @Tim, I think we'll stick with our decision to keep 1.7.2 limited to things broken _by_ the 1.7.x work. Since this appears to have affected previous versions (1.6.x) as well, then the general fix can come in 1.8.0. > Caching error in browse, search and discovery results > - > > Key: DS-898 > URL: https://jira.duraspace.org/browse/DS-898 > Project: DSpace > Issue Type: Bug > Components: XMLUI >Affects Versions: 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1 >Reporter: Ben Bosman >Assignee: Ben Bosman >Priority: Major > Fix For: 1.8.0 > > > The results page for browse, search and discovery uses caching based on the > validity. This validity takes the listed items into account. It doesn't take > the amount of results into account however. > The total amount of results is incorrect if the page was rendered before, and > the same list of items is returned, but some items are added or removed which > are not displayed on the current page -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.duraspace.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel
[Dspace-devel] [DuraSpace JIRA] Commented: (DS-898) Caching error in browse, search and discovery results
[ https://jira.duraspace.org/browse/DS-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20328#action_20328 ] Hardy Pottinger commented on DS-898: See this thread on DSpace-tech: http://sourceforge.net/mailarchive/message.php?msg_id=27508120 looks like in production, with this patch applied, we've found that searches produce an NPE with a stack trace that points back to lines of code from this patch. In production, we're planning to revert this patch, but in testing we'll try out Graham's suggestion, and will post any revised patches that we can confirm still addresses the issue with DS-898, as well as does not produce NPEs when searching. I will keep an eye out for any modifications to this ticket, in the mean time. > Caching error in browse, search and discovery results > - > > Key: DS-898 > URL: https://jira.duraspace.org/browse/DS-898 > Project: DSpace > Issue Type: Bug > Components: XMLUI >Affects Versions: 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1 >Reporter: Ben Bosman >Assignee: Ben Bosman >Priority: Major > Fix For: 1.8.0 > > > The results page for browse, search and discovery uses caching based on the > validity. This validity takes the listed items into account. It doesn't take > the amount of results into account however. > The total amount of results is incorrect if the page was rendered before, and > the same list of items is returned, but some items are added or removed which > are not displayed on the current page -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.duraspace.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel
[Dspace-devel] [DuraSpace JIRA] Commented: (DS-898) Caching error in browse, search and discovery results
[ https://jira.duraspace.org/browse/DS-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20318#action_20318 ] Tim Donohue commented on DS-898: Please run this by Peter Dietz (1.7.2 Release Coordinator) before applying to 1.7.x branch. We specifically decided in this week's Developers Meeting (May 11) that we were going to drastically limit what changes/bug fixes are allowed into 1.7.2. Based on Hardy's testing, I'd be OK with putting this into 1.7.2, but it needs to be run by Peter as well to ensure he has no concerns. Thanks! > Caching error in browse, search and discovery results > - > > Key: DS-898 > URL: https://jira.duraspace.org/browse/DS-898 > Project: DSpace > Issue Type: Bug > Components: XMLUI >Affects Versions: 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1 >Reporter: Ben Bosman >Assignee: Ben Bosman >Priority: Major > Fix For: 1.8.0 > > > The results page for browse, search and discovery uses caching based on the > validity. This validity takes the listed items into account. It doesn't take > the amount of results into account however. > The total amount of results is incorrect if the page was rendered before, and > the same list of items is returned, but some items are added or removed which > are not displayed on the current page -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.duraspace.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel
[Dspace-devel] [DuraSpace JIRA] Commented: (DS-898) Caching error in browse, search and discovery results
[ https://jira.duraspace.org/browse/DS-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20317#action_20317 ] Mark Diggory commented on DS-898: - Ben, we should apply this to the 1.7.x branch as well so it comes out in 1.7.2. > Caching error in browse, search and discovery results > - > > Key: DS-898 > URL: https://jira.duraspace.org/browse/DS-898 > Project: DSpace > Issue Type: Bug > Components: XMLUI >Affects Versions: 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1 >Reporter: Ben Bosman >Assignee: Ben Bosman >Priority: Major > Fix For: 1.8.0 > > > The results page for browse, search and discovery uses caching based on the > validity. This validity takes the listed items into account. It doesn't take > the amount of results into account however. > The total amount of results is incorrect if the page was rendered before, and > the same list of items is returned, but some items are added or removed which > are not displayed on the current page -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.duraspace.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel
[Dspace-devel] [DuraSpace JIRA] Commented: (DS-898) Caching error in browse, search and discovery results
[ https://jira.duraspace.org/browse/DS-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20315#action_20315 ] Hardy Pottinger commented on DS-898: Hi, we've confirmed this bug with our in-production 1.62-based repository, and the patch committed here is confirmed to address the problem. We're rolling out our 1.7.1-based repository iteration this weekend, with this patch applied. Thanks, Ben! > Caching error in browse, search and discovery results > - > > Key: DS-898 > URL: https://jira.duraspace.org/browse/DS-898 > Project: DSpace > Issue Type: Bug > Components: XMLUI >Affects Versions: 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1 >Reporter: Ben Bosman >Assignee: Ben Bosman >Priority: Major > Fix For: 1.8.0 > > > The results page for browse, search and discovery uses caching based on the > validity. This validity takes the listed items into account. It doesn't take > the amount of results into account however. > The total amount of results is incorrect if the page was rendered before, and > the same list of items is returned, but some items are added or removed which > are not displayed on the current page -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.duraspace.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel
