[Dspace-tech] [RFC] Incorrect Java Vendor in DSpace control panel

2013-08-15 Thread Alan Orth
Hi,

I've just realized that DSpace tries to be helpful and print the Java 
JDK vendor in the control panel, but gets it utterly wrong and is 
ultimately misleading.  For example:

Java Runtime Environment Vendor:Oracle Corporation

But in reality, we're using OpenJDK:

[aorth@dspace: ~]$ java -version
java version "1.7.0_21"
OpenJDK Runtime Environment (IcedTea 2.3.9)
(7u21-2.3.9-0ubuntu0.12.04.1)
OpenJDK 64-Bit Server VM (build 23.7-b01, mixed mode)

I guess DSpace is using the wrong string to determine the vendor, ie:

java.vendor=Oracle Corporation

When it should probably be using:

java.vm.name=OpenJDK 64-Bit Server VM

We were recently working with a vendor (@mire!) and we told them to test 
their addons with Oracle JDK, as it appeared that's what we were using.  
I think it's more relevant to report the implementation vendor, not the 
specification vendor here.

If I make an issue on Jira and a GitHub commit, would people appreciate 
that?

Cheers,

-- 
Alan Orth
alan.o...@gmail.com
http://alaninkenya.org
http://mjanja.co.ke
"I have always wished for my computer to be as easy to use as my telephone; my 
wish has come true because I can no longer figure out how to use my telephone." 
-Bjarne Stroustrup, inventor of C++


--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech
List Etiquette: https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette


Re: [Dspace-tech] [RFC] Incorrect Java Vendor in DSpace control panel

2013-08-15 Thread Alan Orth
Ok,

I've created a Jira Bug[0] and submitted a patch[1].

Cheers,

Alan

[0] https://jira.duraspace.org/browse/DS-1629
[1] 
https://github.com/alanorth/DSpace/commit/fba6c5b9771f04374daf10e7b20c288e85b6f715
 


On 08/15/2013 11:22 AM, Alan Orth wrote:
> Hi,
>
> I've just realized that DSpace tries to be helpful and print the Java 
> JDK vendor in the control panel, but gets it utterly wrong and is 
> ultimately misleading.  For example:
>
>Java Runtime Environment Vendor:Oracle Corporation
>
> But in reality, we're using OpenJDK:
>
>[aorth@dspace: ~]$ java -version
>java version "1.7.0_21"
>OpenJDK Runtime Environment (IcedTea 2.3.9)
>(7u21-2.3.9-0ubuntu0.12.04.1)
>OpenJDK 64-Bit Server VM (build 23.7-b01, mixed mode)
>
> I guess DSpace is using the wrong string to determine the vendor, ie:
>
>java.vendor=Oracle Corporation
>
> When it should probably be using:
>
>java.vm.name=OpenJDK 64-Bit Server VM
>
> We were recently working with a vendor (@mire!) and we told them to 
> test their addons with Oracle JDK, as it appeared that's what we were 
> using.  I think it's more relevant to report the implementation 
> vendor, not the specification vendor here.
>
> If I make an issue on Jira and a GitHub commit, would people 
> appreciate that?
>
> Cheers,
>

-- 
Alan Orth
alan.o...@gmail.com
http://alaninkenya.org
http://mjanja.co.ke
"I have always wished for my computer to be as easy to use as my telephone; my 
wish has come true because I can no longer figure out how to use my telephone." 
-Bjarne Stroustrup, inventor of C++


--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech
List Etiquette: https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette