Re: [Dspace-tech] ConfigurableSubmissionPatch compile error

2007-07-27 Thread Christian Voelker
Hello,

Am 27.07.2007 um 06:18 schrieb Gary Browne:
 I'm trying to apply the said patch to 1.4.1.

 I'm using SF patch #1532695 (should I be using SF patch #1691345?)  
 and I get compile errors.
 .
 .

 All of the exceptions are 'class' or 'interface' expected. Can  
 anyone offer advice here?
This patch doesnt fit the version you are using.
There were conflicting changes made to this file
in the meantime. You have to merge manually.
Which version was current or under development
at the time the patch was sent in? You may
downlaod this version, patch it then diff it
with your current version, probably using a
three way diff tool (wonderful: FileMerge on
MacOS X, comes as a utility with the developer
tools). Or, you just read the patch, try to
understand, then reimplement it for the current
version. This approach might be easier in some
cases. You should use a decent editor that
helps you in highlighting java syntax and
jump to the apropriate section where the
methods are implemented. The same is true
for classes although it takes me wonder that
it even messes up with them as there is usually
only one per file. You are not a programmer?
Me not either. But you can come to an under-
standing by reading after a short kickstart.
You could also vote and promote your favourite
patches so that they get in with the next
release.

Bye, Christian


-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now   http://get.splunk.com/
___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech


Re: [Dspace-tech] ConfigurableSubmissionPatch compile error

2007-07-27 Thread Tim Donohue
Gary,

Christian is correct.  That older Configurable Submission patch was 
specifically for DSpace 1.4 (and not 1.4.1 or 1.4.2).  So, it would take 
some manual merging to try and get it working on 1.4.1 or 1.4.2.

In fact, I'd actually discourage anyone from installing that old 
Configurable Submission patch (SF #1532695), as it's now considered 
out-of-date.  An updated and more stable version of the Configurable 
Submission is already committed to be released as part of DSpace 1.5, 
and I'd encourage you to wait for that if you can.  (DSpace 1.5 should 
hopefully be released in the next few months).  I'm actually going to go 
into the Patch Queue right now and mark that older patch as out of date.

In addition, since I'm only one person supporting this patch, there is 
unlikely to be a migration path between that old Configurable Submission 
patch and DSpace 1.5.  So, before upgrading to the eventual DSpace 1.5, 
you'd likely need to completely uninstall this old Configurable 
Submission patch anyways.

Feel free to let me know if you have further questions on this!

- Tim

Christian Voelker wrote:
 Hello,
 
 Am 27.07.2007 um 06:18 schrieb Gary Browne:
 I'm trying to apply the said patch to 1.4.1.

 I'm using SF patch #1532695 (should I be using SF patch #1691345?)  
 and I get compile errors.
 .
 .

 All of the exceptions are 'class' or 'interface' expected. Can  
 anyone offer advice here?
 This patch doesnt fit the version you are using.
 There were conflicting changes made to this file
 in the meantime. You have to merge manually.
 Which version was current or under development
 at the time the patch was sent in? You may
 downlaod this version, patch it then diff it
 with your current version, probably using a
 three way diff tool (wonderful: FileMerge on
 MacOS X, comes as a utility with the developer
 tools). Or, you just read the patch, try to
 understand, then reimplement it for the current
 version. This approach might be easier in some
 cases. You should use a decent editor that
 helps you in highlighting java syntax and
 jump to the apropriate section where the
 methods are implemented. The same is true
 for classes although it takes me wonder that
 it even messes up with them as there is usually
 only one per file. You are not a programmer?
 Me not either. But you can come to an under-
 standing by reading after a short kickstart.
 You could also vote and promote your favourite
 patches so that they get in with the next
 release.
 
 Bye, Christian
 
 
 -
 This SF.net email is sponsored by: Splunk Inc.
 Still grepping through log files to find problems?  Stop.
 Now Search log events and configuration files using AJAX and a browser.
 Download your FREE copy of Splunk now   http://get.splunk.com/
 ___
 DSpace-tech mailing list
 DSpace-tech@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/dspace-tech
 

-- 


Tim Donohue
Research Programmer, Illinois Digital Environment for
Access to Learning and Scholarship (IDEALS)
135 Grainger Engineering Library
University of Illinois at Urbana-Champaign

email: [EMAIL PROTECTED]
web:   http://www.ideals.uiuc.edu
phone: (217) 333-4648
fax:   (217) 244-7764


-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now   http://get.splunk.com/
___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech


[Dspace-tech] ConfigurableSubmissionPatch compile error

2007-07-26 Thread Gary Browne

Hi

I'm trying to apply the said patch to 1.4.1.

I'm using SF patch #1532695 (should I be using SF patch #1691345?) and I get 
compile errors (42 of 'em) when I try to redeploy, so the build fails with:

compile:
[javac] Compiling 23 source files to /home/dspace/dspace-src/build/classes
[javac] 
/home/dspace/dspace-src/src/org/dspace/app/webui/servlet/SubmitServlet.java:2671:
 'class' or 'interface' expected
[javac] package org.dspace.app.webui.servlet;
[javac] ^
[javac] 
/home/dspace/dspace-src/src/org/dspace/app/webui/servlet/SubmitServlet.java:2673:
 'class' or 'interface' expected
[javac] import java.io.BufferedInputStream;
.
.
.

und so weiter, und so weiter...

All of the exceptions are 'class' or 'interface' expected. Can anyone offer 
advice here?

BTW, does anyone know if this patch works with 1.4.2?

Thanks
Gary

-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now   http://get.splunk.com/___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech