subject:"Re\: \[Dspace\-tech\] Question about changing java code in DSpace 1.5.2"

Re: [Dspace-tech] Question about changing java code in DSpace 1.5.2

2009-07-07 Thread George Kozak


Mark:

No, they are not in the classes directories.  What do I need to do to 
get them there?  Thanks!


Mark Diggory wrote:

Hi George,

On Tue, Jul 7, 2009 at 7:30 AM, George Kozakg...@cornell.edu wrote:
  

I went to
[dspace-1.5.2-src-release]/dspace/modules/jspui/src/main/java/org/dspace/

I put in my own versions of  app/webui/serlvet/BitstreamServlet.java
and content/Bitstream.java

I ran mvn package and then ant -Dconfig=[dspace
main]/config/dspace.cfg update
and copied the new webapps over to Tomcat.



Can you verify if your classes have shown up in the following locations?

[dspace-1.5.2-src-release]/dspace/modules/jspui/target/jspui-1.5.2/WEB-INF/classes/

[dspace-1.5.2-src-release]/dspace/target/dspace-release-1.5.2/webapps/jspui/WEB-INF/classes/

They need to show up in the classes directory to override those in
the dspace-jspui-api jar.

Cheers,
Mark

  


--
***
George Kozak
Digital Library Specialist
Division of Library Information Technologies (DLIT), Digital Media Group
501 Olin Library
Cornell University
607-255-8924
***
g...@cornell.edu

--
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have 
the opportunity to enter the BlackBerry Developer Challenge. See full prize 
details at: http://p.sf.net/sfu/blackberry___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech

Re: [Dspace-tech] Question about changing java code in DSpace 1.5.2

2009-07-07 Thread bill . anderson

You may want to wait for a more authoritative answer on this, since deleting 
stuff is always troublesome -- but when this happened to us, we deleted the 
contents of the target directories (dspace/target/dspace-1.5.0-build.dir/ and 
dspace/modules/jspui/target/jspui-1.5.0) and ran mvn package again; the 
directories were rebuilt by maven.  You could backup and try this; or you could 
wait for somebody on the actual dspace development team (I'm not) to scream 
No!  Don't do that!

Cheers,

Bill
 
Bill Anderson
Software Developer
Digital Library Development
Georgia Tech Library

- George Kozak g...@cornell.edu wrote:

| Thanks, Bill:
| 
| Yes, I have had problems with the jsps.  My new classes did not end up
| 
| in WEB-INF/classes nor did they end up in my dspace build.  I didn't
| see 
| any maven errors.  So, I guess I will have to do some digging. 
| Thanks!
| 
| bill.ander...@library.gatech.edu wrote:
|  Hi, George.  I assume you copied the entire package path as a
| directory structure under java/org/dspace, and restarted Tomcat.  Did
| the new files compile correctly when you ran mvn package?  If so, I
| can think of three things that have happened to us in the past:  
| 
|  1) We've occassionally had to clean out the tomcat work directory to
| get new code to run.  The java classes aren't in there, of course; but
| the cached jsps seem to get stuck sometimes, and continue to call the
| code from the dspace libs.
| 
|  2) Check to make sure your new classes are actually in the deployed
| app (jspui/WEB-INF/classes/).  If they aren't, then check to be sure
| they're being copied to the target directory in your dspace build.  
| 
|  3) If you're running any of these classes from outside the jspui
| (from the command line, for instance), then the updated class files
| have to be copied to the appropriate jar in the dspace lib directory. 
| I assume you're not running the bitstream code from the command line,
| but include this for completeness.
| 
|  Let me know if any of this helps.
| 
|  Cheers,
| 
|  Bill
| 
|  Bill Anderson
|  Software Developer
|  Digital Library Development
|  Georgia Tech Library
| 
|  - George Kozak g...@cornell.edu wrote:
| 
|  | Hi...
|  | 
|  | I wanted to put in a local change to two java programs.  This is
| my
|  | 
|  | first time with DSpace .1.5.2 (I have been working with DSpace
| 1.4.2).
|  |  
|  | These local mods were our modified version of Terry Owen's (U of 
|  | Maryland) Embargo code.
|  | 
|  | I went to 
|  |
| [dspace-1.5.2-src-release]/dspace/modules/jspui/src/main/java/org/dspace/
|  | 
|  | I put in my own versions of 
| app/webui/serlvet/BitstreamServlet.java
|  | and content/Bitstream.java
|  | 
|  | I ran mvn package and then ant -Dconfig=[dspace 
|  | main]/config/dspace.cfg update
|  | and copied the new webapps over to Tomcat.
|  | 
|  | However, when I execute my code, I do not seem to be getting my
| unique
|  | 
|  | versions of BitstreamServlet.java and Bitstream.java.  It acts
| like it
|  | 
|  | would if it was using the vanilla versions of these modules.
|  | 
|  | Did I do this wrong?  Does the modified java code go elsewhere?
|  | 
|  | -- 
|  | ***
|  | George Kozak
|  | Digital Library Specialist
|  | Division of Library Information Technologies (DLIT), Digital
| Media
|  | Group
|  | 501 Olin Library
|  | Cornell University
|  | 607-255-8924
|  | ***
|  | g...@cornell.edu
|  | 
|  | 
|  |
| --
|  | Enter the BlackBerry Developer Challenge  
|  | This is your chance to win up to $100,000 in prizes! For a
| limited
|  | time, 
|  | vendors submitting new applications to BlackBerry App World(TM)
| will
|  | have 
|  | the opportunity to enter the BlackBerry Developer Challenge. See
| full
|  | prize 
|  | details at: http://p.sf.net/sfu/blackberry
|  | ___
|  | DSpace-tech mailing list
|  | DSpace-tech@lists.sourceforge.net
|  | https://lists.sourceforge.net/lists/listinfo/dspace-tech
|
| 
| -- 
| ***
| George Kozak
| Digital Library Specialist
| Division of Library Information Technologies (DLIT), Digital Media
| Group
| 501 Olin Library
| Cornell University
| 607-255-8924
| ***
| g...@cornell.edu

--
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have 
the opportunity to enter the BlackBerry Developer Challenge. See full prize 
details at: http://p.sf.net/sfu/blackberry
___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech

Re: [Dspace-tech] Question about changing java code in DSpace 1.5.2

2009-07-07 Thread Mark Diggory


 On Tue, Jul 7, 2009 at 9:31 AM, bill.ander...@library.gatech.edu wrote:

 You may want to wait for a more authoritative answer on this, since
 deleting stuff is always troublesome -- but when this happened to us, we
 deleted the contents of the target directories
 (dspace/target/dspace-1.5.0-build.dir/ and
 dspace/modules/jspui/target/jspui-1.5.0) and ran mvn package again; the
 directories were rebuilt by maven.  You could backup and try this; or you
 could wait for somebody on the actual dspace development team (I'm not) to
 scream No!  Don't do that!


mvn clean will clear all your target directories and you should feel very
comfortable running it. consider anything under target to be transient.

Mark
--
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have 
the opportunity to enter the BlackBerry Developer Challenge. See full prize 
details at: http://p.sf.net/sfu/blackberry___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech

Re: [Dspace-tech] Question about changing java code in DSpace 1.5.2

2009-07-07 Thread Mark Diggory

Ok, lets walk through your process and verify we are not missing details.
place your Bitstream.java in
[dspace-1.5.2-src-release]/dspace/modules/jspui/src/main/java/org/dspace/content/Bitstream.java

cd [dspace-1.5.2-src-release]/dspace

mvn clean package

ls -a
-l 
[dspace-1.5.2-src-release]/dspace/target/dspace-1.5.2-build.dir/webapps/jspui/WEB-INF/classes/org/dspace/content/


This should be where your replaced Bitstream.java shows up as a compiled
Bitstream.class.  I just copied and ran a build test doing this with dspace
1.5.2 successfully.

Mark

On Tue, Jul 7, 2009 at 9:08 AM, George Kozak g...@cornell.edu wrote:

  Mark:

 No, they are not in the classes directories.  What do I need to do to get
 them there?  Thanks!


 Mark Diggory wrote:

 Hi George,

 On Tue, Jul 7, 2009 at 7:30 AM, George Kozakg...@cornell.edu 
 g...@cornell.edu wrote:


  I went to
 [dspace-1.5.2-src-release]/dspace/modules/jspui/src/main/java/org/dspace/

 I put in my own versions of  app/webui/serlvet/BitstreamServlet.java
 and content/Bitstream.java

 I ran mvn package and then ant -Dconfig=[dspace
 main]/config/dspace.cfg update
 and copied the new webapps over to Tomcat.


  Can you verify if your classes have shown up in the following locations?

 [dspace-1.5.2-src-release]/dspace/modules/jspui/target/jspui-1.5.2/WEB-INF/classes/

 [dspace-1.5.2-src-release]/dspace/target/dspace-release-1.5.2/webapps/jspui/WEB-INF/classes/

 They need to show up in the classes directory to override those in
 the dspace-jspui-api jar.

 Cheers,
 Mark




 --
 ***
 George Kozak
 Digital Library Specialist
 Division of Library Information Technologies (DLIT), Digital Media Group
 501 Olin Library
 Cornell University
 607-255-8924
 ***g...@cornell.edu


-- 
Mark R. Diggory
@mire - http://www.atmire.com
--
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have 
the opportunity to enter the BlackBerry Developer Challenge. See full prize 
details at: http://p.sf.net/sfu/blackberry___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech

Re: [Dspace-tech] Question about changing java code in DSpace 1.5.2

2009-07-07 Thread George Kozak

Thanks. Mark! I will give it a try.

Mark Diggory wrote:

Ok, lets walk through your process and verify we are not missing details.

place your Bitstream.java
in [dspace-1.5.2-src-release]/dspace/modules/jspui/src/main/java/org/dspace/content/Bitstream.java

cd [dspace-1.5.2-src-release]/dspace

mvn clean package

ls -a
-l [dspace-1.5.2-src-release]/dspace/target/dspace-1.5.2-build.dir/webapps/jspui/WEB-INF/classes/org/dspace/content/

This should be where your replaced Bitstream.java shows up as a
compiled Bitstream.class. I just copied and ran a build test doing
this with dspace 1.5.2 successfully.

Mark

On Tue, Jul 7, 2009 at 9:08 AM, George Kozak g...@cornell.edu
mailto:g...@cornell.edu wrote:

Mark:

No, they are not in the classes directories. What do I need to do
to get them there? Thanks!

Mark Diggory wrote:

Hi George,

On Tue, Jul 7, 2009 at 7:30 AM, George Kozakg...@cornell.edu
mailto:g...@cornell.edu wrote:

I went to
[dspace-1.5.2-src-release]/dspace/modules/jspui/src/main/java/org/dspace/

I put in my own versions of app/webui/serlvet/BitstreamServlet.java
and content/Bitstream.java

I ran mvn package and then ant -Dconfig=[dspace
main]/config/dspace.cfg update
and copied the new webapps over to Tomcat.

Can you verify if your classes have shown up in the following locations?

[dspace-1.5.2-src-release]/dspace/modules/jspui/target/jspui-1.5.2/WEB-INF/classes/

[dspace-1.5.2-src-release]/dspace/target/dspace-release-1.5.2/webapps/jspui/WEB-INF/classes/

They need to show up in the classes directory to override those in
the dspace-jspui-api jar.

Cheers,
Mark

--
***

George Kozak
Digital Library Specialist
Division of Library Information Technologies (DLIT), Digital Media Group
501 Olin Library
Cornell University
607-255-8924
***
g...@cornell.edu mailto:g...@cornell.edu

--
Mark R. Diggory
@mire - http://www.atmire.com

--
***
George Kozak
Digital Library Specialist
Division of Library Information Technologies (DLIT), Digital Media Group
501 Olin Library
Cornell University
607-255-8924
***
g...@cornell.edu

--
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/blackberry___
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech

Re: [Dspace-tech] Question about changing java code in DSpace 1.5.2

2009-07-07 Thread George Kozak

Thanks, Mark:

It turns out that my compile of Bitstream. java is failing. Somehow, I
missed the error messages the first time. Looks like the code I copied
in has some problems. At least I know where things are supposed to go
and where they are supposed to be after compiling. A big thank you to
Mark and Bill. Now for the hard part...debugging my code! ;-)