[E1000-devel] setting rx-flow-hash for ESP

2015-10-23 Thread Sowmini Varadhan
hi,

I have a setup that uses ipsec/esp, and in theory, since the SPI 
falls in the same byte location as the tcp ports, one ought to 
be able to set up the rx-flow-hash etc based on the spi.

But when I try something like this:

#   ethtool -N eth13 rx-flow-hash esp4 sdfn
Cannot change RX network flow hashing options: Invalid argument

I see that is error-ing out (for me) in ixgbe_set_rss_hash_opt() for
nfc->flow_type == 4 (AH_ESP_V4_FLOW).  But is there a significant
technical reason why this cannot follow the same logic as 
TCP_V4_FLOW or TCP_V6_FLOW, i.e., use "sdfn" for classification
(my reading of the code in that function is that tcp v4/v6 flows
do sdfn by default).

Related question that motivates this, has anyone looked into whether 
sdfn would improve perf for esp?

--Sowmini




--
___
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel Ethernet, visit 
http://communities.intel.com/community/wired


Re: [E1000-devel] X710 / i40e interface resets

2015-10-23 Thread Christian Ruppert
On 2015-10-21 01:30, Rose, Gregory V wrote:
>> -Original Message-
>> From: Christian Ruppert [mailto:id...@qasl.de]
>> Sent: Thursday, October 15, 2015 4:02 AM
>> To: Rose, Gregory V
>> Cc: Fujinaka, Todd; e1000-de...@lists.sf.net
>> Subject: RE: [E1000-devel] X710 / i40e interface resets
>> 
>> On 2015-10-08 17:05, Rose, Gregory V wrote:
>> >> -Original Message-
>> >> From: Christian Ruppert [mailto:id...@qasl.de]
>> >> Sent: Thursday, October 08, 2015 7:34 AM
>> >> To: Rose, Gregory V
>> >> Cc: Fujinaka, Todd; e1000-de...@lists.sf.net
>> >> Subject: RE: [E1000-devel] X710 / i40e interface resets
>> > Please try turning off TSO/GSO to see if that helps.
>> 
>> That seems to help. No more resets. Do you want me to enable TSO or 
>> GSO
>> again to see which one exactly cause those resets? Or do you want me 
>> to do
>> anything else?
>> 
> 
> Sorry for the delayed response but I've been out of the office for the
> last week.

No problem! ;)

> 
> Yes, please do try disabling TSO and GSO separately - I suspect that
> internally to the driver it won't make a difference but if it does
> then it would be good to know.

You seem to be right, no resets, nothing unusual currently.

> 
> Thanks!
> 
> - Greg

-- 
Regards,
Christian Ruppert

--
___
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel Ethernet, visit 
http://communities.intel.com/community/wired