Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Check correct variable for NULL

2017-05-14 Thread Carsey, Jaben 
Reviewed-by: Jaben Carsey 

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff
> Westfahl
> Sent: Friday, May 12, 2017 1:42 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben 
> Subject: [edk2] [PATCH] ShellPkg/UefiShellLib: Check correct variable for NULL
> Importance: High
> 
> Cc: Ruiyu Ni 
> Cc: Jaben Carsey 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeff Westfahl 
> ---
>  ShellPkg/Library/UefiShellLib/UefiShellLib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> index 55e8a67..0f37886 100644
> --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> @@ -702,7 +702,7 @@ ShellOpenFileByName(
>// Create the directory to create the file in
>//
>FileNameCopy = AllocateCopyPool (StrSize (FileName), FileName);
> -  if (FileName == NULL) {
> +  if (FileNameCopy == NULL) {
>  return (EFI_OUT_OF_RESOURCES);
>}
>PathCleanUpDirectories (FileNameCopy);
> --
> 2.7.4
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Shell 'touch' command fails if touched file doesn't already exist

2017-05-14 Thread Carsey, Jaben 
I think that since the UEFI Shell Spec does not mention creating new files and 
no one has mentioned it before, we just didn't think of it.  I don't see that 
it would violate the spec; I would welcome such a enhancement.

-Jaben

> -Original Message-
> From: Jeff Westfahl [mailto:jeff.westf...@ni.com]
> Sent: Friday, May 12, 2017 2:44 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben 
> Subject: Shell 'touch' command fails if touched file doesn't already exist
> Importance: High
> 
> I see that the shell 'touch' command doesn't create the specified file if it 
> doesn't
> already exist. Is this by design? My experience with the 'touch' command in
> other operating environments leads me to expect it to create the file if it 
> doesn't
> already exist.
> 
> Regards,
> Jeff
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] GCC build script change.

2017-05-14 Thread zwei4 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: zwei4 
---
 BuildBIOS.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BuildBIOS.sh b/BuildBIOS.sh
index cc1cb783c..49a9e1b12 100755
--- a/BuildBIOS.sh
+++ b/BuildBIOS.sh
@@ -14,5 +14,7 @@ export 
PACKAGES_PATH=$WORKSPACE:$WORKSPACE/Core:$WORKSPACE/Silicon/:$WORKSPACE/P
 
 . edksetup.sh
 
+make -C BaseTools
+
 ./Platform/BroxtonPlatformPkg/BuildIFWI.sh APLI Release
 
-- 
2.11.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Fix GCC build errors.

2017-05-14 Thread zwei4 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: zwei4 
---
 .../Common/PlatformSettings/PlatformPreMemPei/PlatformInitPreMem.c   | 5 +
 Platform/BroxtonPlatformPkg/PlatformDsc/BuildOptions.EDKII.Gcc.dsc   | 1 -
 .../SouthCluster/ScSmiDispatcher/Smm/ScSmiDispatcher.inf | 2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git 
a/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformPreMemPei/PlatformInitPreMem.c
 
b/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformPreMemPei/PlatformInitPreMem.c
index d7ef4970b..fe454bf89 100644
--- 
a/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformPreMemPei/PlatformInitPreMem.c
+++ 
b/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformPreMemPei/PlatformInitPreMem.c
@@ -217,6 +217,10 @@ CopyMemSse4 (
   IN UINTN SizeInBytes
   )
 {
+
+  #ifdef __GNUC__
+  CopyMem (Dst, Src, SizeInBytes); 
+  #else
   _asm {
 //
 // Initialize pointers to start of the USWC memory
@@ -281,6 +285,7 @@ CopyMemSse4 (
 movdqu  xmm3, [esp + 48]
 add esp, 040h // stack cleanup
   }
+  #endif
   // End of Bulk Load loop
 }
 
diff --git a/Platform/BroxtonPlatformPkg/PlatformDsc/BuildOptions.EDKII.Gcc.dsc 
b/Platform/BroxtonPlatformPkg/PlatformDsc/BuildOptions.EDKII.Gcc.dsc
index 7c7f9c2b1..1d5786d59 100644
--- a/Platform/BroxtonPlatformPkg/PlatformDsc/BuildOptions.EDKII.Gcc.dsc
+++ b/Platform/BroxtonPlatformPkg/PlatformDsc/BuildOptions.EDKII.Gcc.dsc
@@ -104,5 +104,4 @@ DEFINE EDK_EDKII_DSC_FEATURE_BUILD_OPTIONS = 
$(EDK_EDKII_DSC_FEATURE_BUILD_OPTIO
   *_*_X64_ASLPP_FLAGS= $(EDK_EDKII_DSC_FEATURE_BUILD_OPTIONS)
   *_*_*_ASL_FLAGS= $(EDK_EDKII_DSC_FEATURE_BUILD_OPTIONS) -we
 
-  RELEASE_*_*_CC_FLAGS = /Zi
 
diff --git 
a/Silicon/BroxtonSoC/BroxtonSiPkg/SouthCluster/ScSmiDispatcher/Smm/ScSmiDispatcher.inf
 
b/Silicon/BroxtonSoC/BroxtonSiPkg/SouthCluster/ScSmiDispatcher/Smm/ScSmiDispatcher.inf
index 9ba40ca08..09b36eb33 100644
--- 
a/Silicon/BroxtonSoC/BroxtonSiPkg/SouthCluster/ScSmiDispatcher/Smm/ScSmiDispatcher.inf
+++ 
b/Silicon/BroxtonSoC/BroxtonSiPkg/SouthCluster/ScSmiDispatcher/Smm/ScSmiDispatcher.inf
@@ -82,4 +82,4 @@
   gEfiPciRootBridgeIoProtocolGuid
 
 [BuildOptions]
-  *_*_X64_CC_FLAGS  = -D X64_BUILD_SUPPORT = 1
+  *_*_X64_CC_FLAGS  = -D X64_BUILD_SUPPORT=1
-- 
2.11.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel