Re: [edk2] [PATCH] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include

2019-01-17 Thread Ard Biesheuvel 
On Thu, 17 Jan 2019 at 10:36, Leif Lindholm  wrote:
>
> On Wed, Jan 16, 2019 at 09:50:59PM +0100, Ard Biesheuvel wrote:
> > Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console
> > if available") added calls to AsciiPrint() to the default exception
> > handler code, but the ARM version did not include UefiLib.h yet
> > (even though the .INF declares it unconditionally), resulting in
> > build breakage. So add the missing include.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel 
>
> Reviewed-by: Leif Lindholm 
>

Thanks

Pushed as 3837e2e03840..00755e1c8019

> > ---
> >  ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 
> > 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git 
> > a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c 
> > b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > index 2e0cfb2d4e03..476ec2061084 100644
> > --- 
> > a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > +++ 
> > b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > @@ -22,6 +22,7 @@
> >  #include 
> >  #include 
> >  #include 
> > +#include 
> >
> >  #include 
> >
> > --
> > 2.17.1
> >
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include

2019-01-17 Thread Leif Lindholm 
On Wed, Jan 16, 2019 at 09:50:59PM +0100, Ard Biesheuvel wrote:
> Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console
> if available") added calls to AsciiPrint() to the default exception
> handler code, but the ARM version did not include UefiLib.h yet
> (even though the .INF declares it unconditionally), resulting in
> build breakage. So add the missing include.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel 

Reviewed-by: Leif Lindholm 

> ---
>  ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git 
> a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c 
> b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> index 2e0cfb2d4e03..476ec2061084 100644
> --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> @@ -22,6 +22,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  
>  #include 
>  
> -- 
> 2.17.1
> 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include

2019-01-16 Thread Ard Biesheuvel 
Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console
if available") added calls to AsciiPrint() to the default exception
handler code, but the ARM version did not include UefiLib.h yet
(even though the .INF declares it unconditionally), resulting in
build breakage. So add the missing include.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel 
---
 ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c 
b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
index 2e0cfb2d4e03..476ec2061084 100644
--- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
+++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
@@ -22,6 +22,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
-- 
2.17.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel