Re: [edk2] [PATCH] CryptoPkg/OpensslLib: Convert saved opensslconf.h to DOS line endings

2016-03-10 Thread Long, Qin
Reviewed-by: Qin Long 


Best Regards & Thanks,
LONG, Qin

> -Original Message-
> From: David Woodhouse [mailto:david.woodho...@intel.com]
> Sent: Thursday, March 10, 2016 3:15 AM
> To: edk2-de...@ml01.01.org
> Cc: Long, Qin 
> Subject: [PATCH] CryptoPkg/OpensslLib: Convert saved opensslconf.h to DOS 
> line endings
> 
> Until we fix the git repository to store line endings properly and then
> just check them out in the appropriate form for the platform, let's make
> process_files.sh convert the opensslconf.h to DOS line endings when it
> creates it.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: David Woodhouse 
> ---
>  CryptoPkg/Library/OpensslLib/process_files.sh | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/CryptoPkg/Library/OpensslLib/process_files.sh 
> b/CryptoPkg/Library/OpensslLib/process_files.sh
> index bb33c8a..1094fd4 100755
> --- a/CryptoPkg/Library/OpensslLib/process_files.sh
> +++ b/CryptoPkg/Library/OpensslLib/process_files.sh
> @@ -93,5 +93,6 @@ function filelist ()
>  filelist < "${OPENSSL_PATH}/MINFO" |  sed -n -f - -i OpensslLib.inf
> 
>  # We can tell Windows users to put this back manually if they can't run
> -# Configure.
> -cp "${OPENSSL_PATH}/crypto/opensslconf.h" .
> +# Configure. For now, until the git repository is fixed to store things
> +# sanely, also convert to DOS line-endings
> +unix2dos "${OPENSSL_PATH}/crypto/opensslconf.h" opensslconf.h
> --
> 2.5.0
> 
> --
> David WoodhouseOpen Source Technology Centre
> david.woodho...@intel.com  Intel Corporation

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


[edk2] [PATCH] CryptoPkg/OpensslLib: Convert saved opensslconf.h to DOS line endings

2016-03-10 Thread David Woodhouse
Until we fix the git repository to store line endings properly and then
just check them out in the appropriate form for the platform, let's make
process_files.sh convert the opensslconf.h to DOS line endings when it
creates it.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: David Woodhouse 
---
(Resent from list-subscribed email address)

 CryptoPkg/Library/OpensslLib/process_files.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/CryptoPkg/Library/OpensslLib/process_files.sh 
b/CryptoPkg/Library/OpensslLib/process_files.sh
index bb33c8a..1094fd4 100755
--- a/CryptoPkg/Library/OpensslLib/process_files.sh
+++ b/CryptoPkg/Library/OpensslLib/process_files.sh
@@ -93,5 +93,6 @@ function filelist ()
 filelist < "${OPENSSL_PATH}/MINFO" |  sed -n -f - -i OpensslLib.inf
 
 # We can tell Windows users to put this back manually if they can't run
-# Configure.
-cp "${OPENSSL_PATH}/crypto/opensslconf.h" .
+# Configure. For now, until the git repository is fixed to store things
+# sanely, also convert to DOS line-endings
+unix2dos "${OPENSSL_PATH}/crypto/opensslconf.h" opensslconf.h
-- 
2.5.0

-- 
David WoodhouseOpen Source Technology Centre
david.woodho...@intel.com  Intel Corporation



smime.p7s
Description: S/MIME cryptographic signature
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel