Re: [edk2] [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments

2016-11-09 Thread Ni, Ruiyu 
Bell,
FreePool (Blt) purposely frees the pool of Image.Bitmap, which was returned 
from previous loop. It's useful.

Thanks/Ray

> -Original Message-
> From: Song, BinX
> Sent: Thursday, November 10, 2016 1:42 PM
> To: Gao, Liming ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu 
> Subject: RE: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if
> judgments
> 
> Hi Liming,
> 
> In BootLogoEnableLogo() function, the FreePool(Blt) function will never be
> called, some Blt related code as below:
> 
> a. Blt = NULL;  -> Step 1, Blt was initialized.
> ..
> b.if (Blt != NULL) {  \
>   FreePool (Blt);  -- Step 2, Blt was checked, the judgment is always 
> false.
> }/
> 
> c.Blt = Image.Bitmap;  Step 3, Blt get an valid value.
> 
> From above, I think we can remove this if judgment.
> 
> Best Regards,
> Bell Song
> 
> > -Original Message-
> > From: Gao, Liming
> > Sent: Wednesday, November 9, 2016 10:25 AM
> > To: Song, BinX ; edk2-devel@lists.01.org
> > Cc: Ni, Ruiyu 
> > Subject: RE: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if
> > judgments
> >
> > Bin:
> >   Why remove FreePool (Blt)? It is still used.
> >
> > Thanks
> > Liming
> > > -Original Message-
> > > From: Song, BinX
> > > Sent: Tuesday, November 08, 2016 11:01 AM
> > > To: edk2-devel@lists.01.org
> > > Cc: Gao, Liming 
> > > Subject: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if
> > judgments
> > >
> > > There are two invalid if judgments in BootLogoEnableLogo() function,
> > > remove them.
> > >
> > > Cc: Liming Gao 
> > > Contributed-under: TianoCore Contribution Agreement 1.0
> > > Signed-off-by: Bell Song 
> > > ---
> > >  MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 8 
> > >  1 file changed, 8 deletions(-)
> > >
> > > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > > index 2c1e8ea..b69dda8 100644
> > > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > > @@ -141,14 +141,6 @@ BootLogoEnableLogo (
> > >  if (EFI_ERROR (Status)) {
> > >break;
> > >  }
> > > -
> > > -if (EFI_ERROR (Status)) {
> > > -  continue;
> > > -}
> > > -
> > > -if (Blt != NULL) {
> > > -  FreePool (Blt);
> > > -}
> > >  Blt = Image.Bitmap;
> > >
> > >  //
> > > --
> > > 2.7.2.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments

2016-11-09 Thread Song, BinX 
Hi Liming,

In BootLogoEnableLogo() function, the FreePool(Blt) function will never be 
called, some Blt related code as below:

a. Blt = NULL;  -> Step 1, Blt was initialized.
..
b.if (Blt != NULL) {  \
  FreePool (Blt);  -- Step 2, Blt was checked, the judgment is always 
false.
}/

c.Blt = Image.Bitmap;  Step 3, Blt get an valid value.

>From above, I think we can remove this if judgment.

Best Regards,
Bell Song

> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, November 9, 2016 10:25 AM
> To: Song, BinX ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu 
> Subject: RE: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if
> judgments
> 
> Bin:
>   Why remove FreePool (Blt)? It is still used.
> 
> Thanks
> Liming
> > -Original Message-
> > From: Song, BinX
> > Sent: Tuesday, November 08, 2016 11:01 AM
> > To: edk2-devel@lists.01.org
> > Cc: Gao, Liming 
> > Subject: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if
> judgments
> >
> > There are two invalid if judgments in BootLogoEnableLogo() function,
> > remove them.
> >
> > Cc: Liming Gao 
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Bell Song 
> > ---
> >  MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 8 
> >  1 file changed, 8 deletions(-)
> >
> > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > index 2c1e8ea..b69dda8 100644
> > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > @@ -141,14 +141,6 @@ BootLogoEnableLogo (
> >  if (EFI_ERROR (Status)) {
> >break;
> >  }
> > -
> > -if (EFI_ERROR (Status)) {
> > -  continue;
> > -}
> > -
> > -if (Blt != NULL) {
> > -  FreePool (Blt);
> > -}
> >  Blt = Image.Bitmap;
> >
> >  //
> > --
> > 2.7.2.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments

2016-11-08 Thread Gao, Liming 
Bin:
  Why remove FreePool (Blt)? It is still used.  

Thanks
Liming
> -Original Message-
> From: Song, BinX
> Sent: Tuesday, November 08, 2016 11:01 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming 
> Subject: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments
> 
> There are two invalid if judgments in BootLogoEnableLogo() function,
> remove them.
> 
> Cc: Liming Gao 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Bell Song 
> ---
>  MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 8 
>  1 file changed, 8 deletions(-)
> 
> diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> index 2c1e8ea..b69dda8 100644
> --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> @@ -141,14 +141,6 @@ BootLogoEnableLogo (
>  if (EFI_ERROR (Status)) {
>break;
>  }
> -
> -if (EFI_ERROR (Status)) {
> -  continue;
> -}
> -
> -if (Blt != NULL) {
> -  FreePool (Blt);
> -}
>  Blt = Image.Bitmap;
> 
>  //
> --
> 2.7.2.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments

2016-11-07 Thread Song, BinX 
There are two invalid if judgments in BootLogoEnableLogo() function,
remove them.

Cc: Liming Gao 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song 
---
 MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 8 
 1 file changed, 8 deletions(-)

diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c 
b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
index 2c1e8ea..b69dda8 100644
--- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
+++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
@@ -141,14 +141,6 @@ BootLogoEnableLogo (
 if (EFI_ERROR (Status)) {
   break;
 }
-
-if (EFI_ERROR (Status)) {
-  continue;
-}
-
-if (Blt != NULL) {
-  FreePool (Blt);
-}
 Blt = Image.Bitmap;
 
 //
-- 
2.7.2.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel