[edk2] [PATCH] MdeModulePkg Variable: ###VariableTotalSize need to be initialized to 0 first

[Star Zeng]

HwErrVariableTotalSize/CommonVariableTotalSize/CommonUserVariableTotalSize
need to be initialized to 0 first after reclaim failed, then to be assigned by 
+= operation.

Cc: Liming Gao 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng 
---
 MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c 
b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
index 8a07f0e..1cb0409 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
@@ -1191,6 +1191,9 @@ Reclaim (
   mVariableModuleGlobal->CommonVariableTotalSize = CommonVariableTotalSize;
   mVariableModuleGlobal->CommonUserVariableTotalSize = 
CommonUserVariableTotalSize;
 } else {
+  mVariableModuleGlobal->HwErrVariableTotalSize = 0;
+  mVariableModuleGlobal->CommonVariableTotalSize = 0;
+  mVariableModuleGlobal->CommonUserVariableTotalSize = 0;
   Variable = GetStartPointer ((VARIABLE_STORE_HEADER 
*)(UINTN)VariableBase);
   while (IsValidVariableHeader (Variable, GetEndPointer 
((VARIABLE_STORE_HEADER *)(UINTN)VariableBase))) {
 NextVariable = GetNextVariablePtr (Variable);
-- 
1.9.5.msysgit.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] MdeModulePkg Variable: ###VariableTotalSize need to be initialized to 0 first

[Gao, Liming]

Reviewed-by: Liming Gao <liming@intel.com>

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Monday, December 28, 2015 2:10 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: [edk2] [PATCH] MdeModulePkg Variable: ###VariableTotalSize need to be 
initialized to 0 first

HwErrVariableTotalSize/CommonVariableTotalSize/CommonUserVariableTotalSize
need to be initialized to 0 first after reclaim failed, then to be assigned by 
+= operation.

Cc: Liming Gao <liming@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.z...@intel.com>
---
 MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c 
b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
index 8a07f0e..1cb0409 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
@@ -1191,6 +1191,9 @@ Reclaim (
   mVariableModuleGlobal->CommonVariableTotalSize = CommonVariableTotalSize;
   mVariableModuleGlobal->CommonUserVariableTotalSize = 
CommonUserVariableTotalSize;
 } else {
+  mVariableModuleGlobal->HwErrVariableTotalSize = 0;
+  mVariableModuleGlobal->CommonVariableTotalSize = 0;
+  mVariableModuleGlobal->CommonUserVariableTotalSize = 0;
   Variable = GetStartPointer ((VARIABLE_STORE_HEADER 
*)(UINTN)VariableBase);
   while (IsValidVariableHeader (Variable, GetEndPointer 
((VARIABLE_STORE_HEADER *)(UINTN)VariableBase))) {
 NextVariable = GetNextVariablePtr (Variable);
-- 
1.9.5.msysgit.0

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel