[edk2] [PATCH] MdePkg/BaseLib: Change a variable type in a bitwise operation

2019-02-13 Thread Shenglei Zhang 
Change the type of variable Chr from CHAR8 to UINT32 in a
bitwise operation, to make the two variables in the operation
have the same size.
https://bugzilla.tianocore.org/show_bug.cgi?id=1527

Cc: Michael D Kinney 
Cc: Liming Gao 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang 
---
 MdePkg/Library/BaseLib/String.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Library/BaseLib/String.c b/MdePkg/Library/BaseLib/String.c
index 53ff730e9e..a389115d71 100644
--- a/MdePkg/Library/BaseLib/String.c
+++ b/MdePkg/Library/BaseLib/String.c
@@ -2070,7 +2070,7 @@ Base64Decode (
   Chr = DecodingTable[(UINT8) Source[SourceIndex++]];
   } while (Chr == BAD_V);
   Value <<= 6;
-  Value |= Chr;
+  Value |= (UINT32)Chr;
 }
 
 //
-- 
2.18.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] MdePkg/BaseLib: Change a variable type in a bitwise operation

2019-02-15 Thread Gao, Liming 
Reviewed-by: Liming Gao 

> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, February 14, 2019 10:45 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming 
> 
> Subject: [PATCH] MdePkg/BaseLib: Change a variable type in a bitwise operation
> 
> Change the type of variable Chr from CHAR8 to UINT32 in a
> bitwise operation, to make the two variables in the operation
> have the same size.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1527
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang 
> ---
>  MdePkg/Library/BaseLib/String.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Library/BaseLib/String.c b/MdePkg/Library/BaseLib/String.c
> index 53ff730e9e..a389115d71 100644
> --- a/MdePkg/Library/BaseLib/String.c
> +++ b/MdePkg/Library/BaseLib/String.c
> @@ -2070,7 +2070,7 @@ Base64Decode (
>Chr = DecodingTable[(UINT8) Source[SourceIndex++]];
>} while (Chr == BAD_V);
>Value <<= 6;
> -  Value |= Chr;
> +  Value |= (UINT32)Chr;
>  }
> 
>  //
> --
> 2.18.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel