Re: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

2015-12-15 Thread Yao, Jiewen 
OK. I can help on that.

Thanks to fix that.

Thank you
Yao Jiewen

From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com]
Sent: Tuesday, December 15, 2015 8:54 AM
To: edk2-devel@lists.01.org; Yao, Jiewen
Subject: RE: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

Thanks Jiewen. I agree.

I don't have permission to commit. Can you please fix the comment and commit it 
for me?






-Original Message-
From: Yao, Jiewen [jiewen@intel.com]
Received: Monday, 14 Dec 2015, 6:51PM
To: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]; 
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> 
[edk2-devel@lists.01.org]
CC: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]
Subject: RE: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions
HI Samer
The patch is good.
The check in comment seems not match the file you changed. Should it be "The 
GicVersion field is defined in ACPI 5.1 and 6.0"?

Reviewed-by: jiewen@intel.com<mailto:jiewen@intel.com>, if you change 
the comment, when you check in.



-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer 
El-Haj-Mahmoud
Sent: Tuesday, December 15, 2015 7:53 AM
To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Cc: Samer El-Haj-Mahmoud
Subject: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

The GicVersion field is defined in ACPI 5.0 and 6.0

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud <el...@hpe.com<mailto:el...@hpe.com>>
---
 MdePkg/Include/IndustryStandard/Acpi51.h | 12 +++-  
MdePkg/Include/IndustryStandard/Acpi60.h | 12 +++-
 2 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h 
b/MdePkg/Include/IndustryStandard/Acpi51.h
index 9e643bc..034094e 100644
--- a/MdePkg/Include/IndustryStandard/Acpi51.h
+++ b/MdePkg/Include/IndustryStandard/Acpi51.h
@@ -3,6 +3,7 @@

   Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
   Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.
+  (C) Copyright 2015 Hewlett Packard Enterprise Development LP
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
   which accompanies this distribution.  The full text of the license may be 
found at
@@ -529,10 +530,19 @@ typedef struct {
   UINT32  GicId;
   UINT64  PhysicalBaseAddress;
   UINT32  SystemVectorBase;
-  UINT32  Reserved2;
+  UINT8   GicVersion;
+  UINT8   Reserved2[3];
 } EFI_ACPI_5_1_GIC_DISTRIBUTOR_STRUCTURE;

 ///
+/// GIC Version
+///
+#define EFI_ACPI_5_1_GIC_V2   0x01
+#define EFI_ACPI_5_1_GIC_V2m  0x02
+#define EFI_ACPI_5_1_GIC_V3   0x03
+#define EFI_ACPI_5_1_GIC_V4   0x04
+
+///
 /// GIC MSI Frame Structure
 ///
 typedef struct {
diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h 
b/MdePkg/Include/IndustryStandard/Acpi60.h
index 3dac316..f0e4151 100644
--- a/MdePkg/Include/IndustryStandard/Acpi60.h
+++ b/MdePkg/Include/IndustryStandard/Acpi60.h
@@ -2,6 +2,7 @@
   ACPI 6.0 definitions from the ACPI Specification Revision 6.0 April, 2015.

   Copyright (c) 2015, Intel Corporation. All rights reserved.
+ (C) Copyright 2015 Hewlett Packard Enterprise Development LP
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
   which accompanies this distribution.  The full text of the license may be 
found at
@@ -532,10 +533,19 @@ typedef struct {
   UINT32  GicId;
   UINT64  PhysicalBaseAddress;
   UINT32  SystemVectorBase;
-  UINT32  Reserved2;
+  UINT8   GicVersion;
+  UINT8   Reserved2[3];
 } EFI_ACPI_6_0_GIC_DISTRIBUTOR_STRUCTURE;

 ///
+/// GIC Version
+///
+#define EFI_ACPI_6_0_GIC_V1   0x01
+#define EFI_ACPI_6_0_GIC_V2   0x02
+#define EFI_ACPI_6_0_GIC_V3   0x03
+#define EFI_ACPI_6_0_GIC_V4   0x04
+
+///
 /// GIC MSI Frame Structure
 ///
 typedef struct {
--
2.6.3.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

2015-12-14 Thread Yao, Jiewen 
HI Samer
The patch is good.
The check in comment seems not match the file you changed. Should it be "The 
GicVersion field is defined in ACPI 5.1 and 6.0"?

Reviewed-by: jiewen@intel.com, if you change the comment, when you check in.



-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer 
El-Haj-Mahmoud
Sent: Tuesday, December 15, 2015 7:53 AM
To: edk2-devel@lists.01.org
Cc: Samer El-Haj-Mahmoud
Subject: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

The GicVersion field is defined in ACPI 5.0 and 6.0

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud <el...@hpe.com>
---
 MdePkg/Include/IndustryStandard/Acpi51.h | 12 +++-  
MdePkg/Include/IndustryStandard/Acpi60.h | 12 +++-
 2 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h 
b/MdePkg/Include/IndustryStandard/Acpi51.h
index 9e643bc..034094e 100644
--- a/MdePkg/Include/IndustryStandard/Acpi51.h
+++ b/MdePkg/Include/IndustryStandard/Acpi51.h
@@ -3,6 +3,7 @@
 
   Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
   Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.
+  (C) Copyright 2015 Hewlett Packard Enterprise Development LP
   This program and the accompanying materials  
   are licensed and made available under the terms and conditions of the BSD 
License 
   which accompanies this distribution.  The full text of the license may be 
found at
@@ -529,10 +530,19 @@ typedef struct {
   UINT32  GicId;
   UINT64  PhysicalBaseAddress;
   UINT32  SystemVectorBase;
-  UINT32  Reserved2;
+  UINT8   GicVersion;
+  UINT8   Reserved2[3];
 } EFI_ACPI_5_1_GIC_DISTRIBUTOR_STRUCTURE;
 
 ///
+/// GIC Version
+///
+#define EFI_ACPI_5_1_GIC_V2   0x01
+#define EFI_ACPI_5_1_GIC_V2m  0x02
+#define EFI_ACPI_5_1_GIC_V3   0x03
+#define EFI_ACPI_5_1_GIC_V4   0x04
+
+///
 /// GIC MSI Frame Structure
 ///
 typedef struct {
diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h 
b/MdePkg/Include/IndustryStandard/Acpi60.h
index 3dac316..f0e4151 100644
--- a/MdePkg/Include/IndustryStandard/Acpi60.h
+++ b/MdePkg/Include/IndustryStandard/Acpi60.h
@@ -2,6 +2,7 @@
   ACPI 6.0 definitions from the ACPI Specification Revision 6.0 April, 2015.
 
   Copyright (c) 2015, Intel Corporation. All rights reserved.
+ (C) Copyright 2015 Hewlett Packard Enterprise Development LP
   This program and the accompanying materials  
   are licensed and made available under the terms and conditions of the BSD 
License 
   which accompanies this distribution.  The full text of the license may be 
found at
@@ -532,10 +533,19 @@ typedef struct {
   UINT32  GicId;
   UINT64  PhysicalBaseAddress;
   UINT32  SystemVectorBase;
-  UINT32  Reserved2;
+  UINT8   GicVersion;
+  UINT8   Reserved2[3];
 } EFI_ACPI_6_0_GIC_DISTRIBUTOR_STRUCTURE;
 
 ///
+/// GIC Version
+///
+#define EFI_ACPI_6_0_GIC_V1   0x01
+#define EFI_ACPI_6_0_GIC_V2   0x02
+#define EFI_ACPI_6_0_GIC_V3   0x03
+#define EFI_ACPI_6_0_GIC_V4   0x04
+
+///
 /// GIC MSI Frame Structure
 ///
 typedef struct {
--
2.6.3.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

2015-12-14 Thread Samer El-Haj-Mahmoud 
The GicVersion field is defined in ACPI 5.0 and 6.0

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud 
---
 MdePkg/Include/IndustryStandard/Acpi51.h | 12 +++-
 MdePkg/Include/IndustryStandard/Acpi60.h | 12 +++-
 2 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h 
b/MdePkg/Include/IndustryStandard/Acpi51.h
index 9e643bc..034094e 100644
--- a/MdePkg/Include/IndustryStandard/Acpi51.h
+++ b/MdePkg/Include/IndustryStandard/Acpi51.h
@@ -3,6 +3,7 @@
 
   Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
   Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.
+  (C) Copyright 2015 Hewlett Packard Enterprise Development LP
   This program and the accompanying materials  
   are licensed and made available under the terms and conditions of the BSD 
License 
   which accompanies this distribution.  The full text of the license may be 
found at
@@ -529,10 +530,19 @@ typedef struct {
   UINT32  GicId;
   UINT64  PhysicalBaseAddress;
   UINT32  SystemVectorBase;
-  UINT32  Reserved2;
+  UINT8   GicVersion;
+  UINT8   Reserved2[3];
 } EFI_ACPI_5_1_GIC_DISTRIBUTOR_STRUCTURE;
 
 ///
+/// GIC Version
+///
+#define EFI_ACPI_5_1_GIC_V2   0x01
+#define EFI_ACPI_5_1_GIC_V2m  0x02
+#define EFI_ACPI_5_1_GIC_V3   0x03
+#define EFI_ACPI_5_1_GIC_V4   0x04
+
+///
 /// GIC MSI Frame Structure
 ///
 typedef struct {
diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h 
b/MdePkg/Include/IndustryStandard/Acpi60.h
index 3dac316..f0e4151 100644
--- a/MdePkg/Include/IndustryStandard/Acpi60.h
+++ b/MdePkg/Include/IndustryStandard/Acpi60.h
@@ -2,6 +2,7 @@
   ACPI 6.0 definitions from the ACPI Specification Revision 6.0 April, 2015.
 
   Copyright (c) 2015, Intel Corporation. All rights reserved.
+ (C) Copyright 2015 Hewlett Packard Enterprise Development LP  
   This program and the accompanying materials  
   are licensed and made available under the terms and conditions of the BSD 
License 
   which accompanies this distribution.  The full text of the license may be 
found at
@@ -532,10 +533,19 @@ typedef struct {
   UINT32  GicId;
   UINT64  PhysicalBaseAddress;
   UINT32  SystemVectorBase;
-  UINT32  Reserved2;
+  UINT8   GicVersion;
+  UINT8   Reserved2[3];
 } EFI_ACPI_6_0_GIC_DISTRIBUTOR_STRUCTURE;
 
 ///
+/// GIC Version
+///
+#define EFI_ACPI_6_0_GIC_V1   0x01
+#define EFI_ACPI_6_0_GIC_V2   0x02
+#define EFI_ACPI_6_0_GIC_V3   0x03
+#define EFI_ACPI_6_0_GIC_V4   0x04
+
+///
 /// GIC MSI Frame Structure
 ///
 typedef struct {
-- 
2.6.3.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

2015-12-14 Thread El-Haj-Mahmoud, Samer 
Thanks Jiewen. I agree.

I don't have permission to commit. Can you please fix the comment and commit it 
for me?






-Original Message-
From: Yao, Jiewen [jiewen@intel.com]
Received: Monday, 14 Dec 2015, 6:51PM
To: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]; 
edk2-devel@lists.01.org [edk2-devel@lists.01.org]
CC: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]
Subject: RE: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

HI Samer
The patch is good.
The check in comment seems not match the file you changed. Should it be "The 
GicVersion field is defined in ACPI 5.1 and 6.0"?

Reviewed-by: jiewen@intel.com, if you change the comment, when you check in.



-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer 
El-Haj-Mahmoud
Sent: Tuesday, December 15, 2015 7:53 AM
To: edk2-devel@lists.01.org
Cc: Samer El-Haj-Mahmoud
Subject: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

The GicVersion field is defined in ACPI 5.0 and 6.0

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud <el...@hpe.com>
---
 MdePkg/Include/IndustryStandard/Acpi51.h | 12 +++-  
MdePkg/Include/IndustryStandard/Acpi60.h | 12 +++-
 2 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h 
b/MdePkg/Include/IndustryStandard/Acpi51.h
index 9e643bc..034094e 100644
--- a/MdePkg/Include/IndustryStandard/Acpi51.h
+++ b/MdePkg/Include/IndustryStandard/Acpi51.h
@@ -3,6 +3,7 @@

   Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
   Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.
+  (C) Copyright 2015 Hewlett Packard Enterprise Development LP
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
   which accompanies this distribution.  The full text of the license may be 
found at
@@ -529,10 +530,19 @@ typedef struct {
   UINT32  GicId;
   UINT64  PhysicalBaseAddress;
   UINT32  SystemVectorBase;
-  UINT32  Reserved2;
+  UINT8   GicVersion;
+  UINT8   Reserved2[3];
 } EFI_ACPI_5_1_GIC_DISTRIBUTOR_STRUCTURE;

 ///
+/// GIC Version
+///
+#define EFI_ACPI_5_1_GIC_V2   0x01
+#define EFI_ACPI_5_1_GIC_V2m  0x02
+#define EFI_ACPI_5_1_GIC_V3   0x03
+#define EFI_ACPI_5_1_GIC_V4   0x04
+
+///
 /// GIC MSI Frame Structure
 ///
 typedef struct {
diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h 
b/MdePkg/Include/IndustryStandard/Acpi60.h
index 3dac316..f0e4151 100644
--- a/MdePkg/Include/IndustryStandard/Acpi60.h
+++ b/MdePkg/Include/IndustryStandard/Acpi60.h
@@ -2,6 +2,7 @@
   ACPI 6.0 definitions from the ACPI Specification Revision 6.0 April, 2015.

   Copyright (c) 2015, Intel Corporation. All rights reserved.
+ (C) Copyright 2015 Hewlett Packard Enterprise Development LP
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
   which accompanies this distribution.  The full text of the license may be 
found at
@@ -532,10 +533,19 @@ typedef struct {
   UINT32  GicId;
   UINT64  PhysicalBaseAddress;
   UINT32  SystemVectorBase;
-  UINT32  Reserved2;
+  UINT8   GicVersion;
+  UINT8   Reserved2[3];
 } EFI_ACPI_6_0_GIC_DISTRIBUTOR_STRUCTURE;

 ///
+/// GIC Version
+///
+#define EFI_ACPI_6_0_GIC_V1   0x01
+#define EFI_ACPI_6_0_GIC_V2   0x02
+#define EFI_ACPI_6_0_GIC_V3   0x03
+#define EFI_ACPI_6_0_GIC_V4   0x04
+
+///
 /// GIC MSI Frame Structure
 ///
 typedef struct {
--
2.6.3.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel