Re: [edk2] [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"
On Thu, Nov 01, 2018 at 11:35:42AM +, Andrew Turner wrote: > The UEFI build fails for ArmVExpress-FVP-AArch64 when using the > "-D DT_SUPPORT" buildoption. > > ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package > and fails with: > .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33: > fatal error: VExpressMotherBoard.h: No such file or directory > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Andrew Turner > --- > .../ArmVExpressDtPlatformDtbLoaderLib.inf| 1 > + > 1 file changed, 1 insertion(+) > > diff --git > a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > > b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > index 5012101..eb821c7 100644 > --- > a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > +++ > b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > @@ -26,6 +26,7 @@ > [Packages] >ArmPkg/ArmPkg.dec >MdePkg/MdePkg.dec > ++ Platform/ARM/VExpressPkg/ArmVExpressPkg.dec Dropped this extra leading + (is this some sort of alternative diff format or a character encoding issue?). With that: Reviewed-by: Leif Lindholm Pushed as 113d2def98. >EmbeddedPkg/EmbeddedPkg.dec > > [LibraryClasses] > -- > 2.7.4 > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"
On Thu, Nov 1, 2018 at 5:18 PM Leif Lindholm wrote: > > Thanks Andrew, > > Thomas, Nariman - can I have a review from one of you guys before I > push? > > Regards, > > Leif > > On Thu, Nov 01, 2018 at 11:35:42AM +, Andrew Turner wrote: > > The UEFI build fails for ArmVExpress-FVP-AArch64 when using the > > "-D DT_SUPPORT" buildoption. > > > > ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package > > and fails with: > > .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33: > > fatal error: VExpressMotherBoard.h: No such file or directory > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Andrew Turner > > --- > > .../ArmVExpressDtPlatformDtbLoaderLib.inf| > > 1 + > > 1 file changed, 1 insertion(+) Tested with -D DT_SUPPORT as additional build option and the below change does fix the build issue reported in this commit message. Tested-by: Thomas Abraham > > > > diff --git > > a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > > > > b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > > index 5012101..eb821c7 100644 > > --- > > a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > > +++ > > b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > > @@ -26,6 +26,7 @@ > > [Packages] > >ArmPkg/ArmPkg.dec > >MdePkg/MdePkg.dec > > ++ Platform/ARM/VExpressPkg/ArmVExpressPkg.dec > >EmbeddedPkg/EmbeddedPkg.dec > > > > [LibraryClasses] > > -- > > 2.7.4 > > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"
On Thu, Nov 1, 2018 at 5:18 PM Leif Lindholm wrote: > > Thanks Andrew, > > Thomas, Nariman - can I have a review from one of you guys before I > push? > > Regards, > > Leif > > On Thu, Nov 01, 2018 at 11:35:42AM +, Andrew Turner wrote: > > The UEFI build fails for ArmVExpress-FVP-AArch64 when using the > > "-D DT_SUPPORT" buildoption. > > > > ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package > > and fails with: > > .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33: > > fatal error: VExpressMotherBoard.h: No such file or directory > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Andrew Turner > > --- > > .../ArmVExpressDtPlatformDtbLoaderLib.inf| > > 1 + > > 1 file changed, 1 insertion(+) Tested with -D DT_SUPPORT as additional build option and the below change does fix the build issue reported in this commit message. Tested-by: Thomas Abraham > > > > diff --git > > a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > > > > b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > > index 5012101..eb821c7 100644 > > --- > > a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > > +++ > > b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > > @@ -26,6 +26,7 @@ > > [Packages] > >ArmPkg/ArmPkg.dec > >MdePkg/MdePkg.dec > > ++ Platform/ARM/VExpressPkg/ArmVExpressPkg.dec > >EmbeddedPkg/EmbeddedPkg.dec > > > > [LibraryClasses] > > -- > > 2.7.4 > > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"
Thanks Andrew, Thomas, Nariman - can I have a review from one of you guys before I push? Regards, Leif On Thu, Nov 01, 2018 at 11:35:42AM +, Andrew Turner wrote: > The UEFI build fails for ArmVExpress-FVP-AArch64 when using the > "-D DT_SUPPORT" buildoption. > > ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package > and fails with: > .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33: > fatal error: VExpressMotherBoard.h: No such file or directory > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Andrew Turner > --- > .../ArmVExpressDtPlatformDtbLoaderLib.inf| 1 > + > 1 file changed, 1 insertion(+) > > diff --git > a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > > b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > index 5012101..eb821c7 100644 > --- > a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > +++ > b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > @@ -26,6 +26,7 @@ > [Packages] >ArmPkg/ArmPkg.dec >MdePkg/MdePkg.dec > ++ Platform/ARM/VExpressPkg/ArmVExpressPkg.dec >EmbeddedPkg/EmbeddedPkg.dec > > [LibraryClasses] > -- > 2.7.4 > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"
The UEFI build fails for ArmVExpress-FVP-AArch64 when using the "-D DT_SUPPORT" buildoption. ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package and fails with: .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33: fatal error: VExpressMotherBoard.h: No such file or directory Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Andrew Turner --- .../ArmVExpressDtPlatformDtbLoaderLib.inf| 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf index 5012101..eb821c7 100644 --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf @@ -26,6 +26,7 @@ [Packages] ArmPkg/ArmPkg.dec MdePkg/MdePkg.dec ++ Platform/ARM/VExpressPkg/ArmVExpressPkg.dec EmbeddedPkg/EmbeddedPkg.dec [LibraryClasses] -- 2.7.4 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
