Re: [edk2] [PATCH 1/1] ShellPkg: Added SMBIOS 3.0 support in dmem

2015-09-16 Thread Carsey, Jaben 
Thanks.  I looked at the wrong thing somehow.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com>

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El-
> Haj-Mahmoud, Samer
> Sent: Wednesday, September 16, 2015 11:15 AM
> To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin....@intel.com>
> Subject: Re: [edk2] [PATCH 1/1] ShellPkg: Added SMBIOS 3.0 support in
> dmem
> Importance: High
> 
> Jaben,
> 
> The GUID is in already UefiShellDebug1CommandsLib.inf
> 
>   gEfiSmbios3TableGuid## SOMETIMES_CONSUMES ## SystemTable
> 
> The GUID is also in Smbios.h which is already included in Dmem.c
> 
> #include 
> 
> 
> 
> 
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Wednesday, September 16, 2015 1:10 PM
> To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-
> de...@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin
> <shumin@intel.com>
> Subject: Re: [edk2] [PATCH 1/1] ShellPkg: Added SMBIOS 3.0 support in
> dmem
> 
> Samer,
> 
> 2 small things.
> 1) I think that you also need to update the INF for this newly used GUID.  I
> notice that it's not listed in the current tip.
> 2) do you need to include the header for this GUID?
> 
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> > Samer El-Haj-Mahmoud
> > Sent: Wednesday, September 16, 2015 11:05 AM
> > To: edk2-devel@lists.01.org
> > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin
> > <shumin@intel.com>; Samer El-Haj-Mahmoud  > mahm...@hp.com>
> > Subject: [edk2] [PATCH 1/1] ShellPkg: Added SMBIOS 3.0 support in dmem
> > Importance: High
> >
> > Added SMBIOS 3.0 support in dmdem Shell command since SMBIOS 3.0
> uses
> > a different GUID in the System Configuration Table.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Samer El-Haj-Mahmoud  mahm...@hpe.com>
> > ---
> >  ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 7 ++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> > index 05dc0d5..7693835 100644
> > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> > @@ -1,8 +1,9 @@
> >  /** @file
> >Main file for Dmem shell Debug1 function.
> >
> > -  (C) Copyright 2015 Hewlett-Packard Development Company, L.P.
> >Copyright (c) 2010 - 2011, Intel Corporation. All rights
> > reserved.
> > +  (C) Copyright 2015 Hewlett-Packard Development Company, L.P.
> > +  (C) Copyright 2015 Hewlett Packard Enterprise Development LP
> >This program and the accompanying materials
> >are licensed and made available under the terms and conditions of
> > the BSD License
> >which accompanies this distribution.  The full text of the license
> > may be found at @@ -193,6 +194,10 @@ ShellCommandRunDmem (
> >SmbiosTableAddress = (UINT64)(UINTN)gST-
> > >ConfigurationTable[TableWalker].VendorTable;
> >continue;
> >  }
> > +if (CompareGuid (
> > >ConfigurationTable[TableWalker].VendorGuid, )) {
> > +  SmbiosTableAddress = (UINT64) (UINTN) gST-
> > >ConfigurationTable[TableWalker].VendorTable;
> > +  continue;
> > +}
> >  if (CompareGuid(
> > >ConfigurationTable[TableWalker].VendorGuid, )) {
> >MpsTableAddress = (UINT64)(UINTN)gST-
> > >ConfigurationTable[TableWalker].VendorTable;
> >continue;
> > --
> > 1.9.5.msysgit.1
> >
> > ___
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 1/1] ShellPkg: Added SMBIOS 3.0 support in dmem

2015-09-16 Thread El-Haj-Mahmoud, Samer 
Jaben,

The GUID is in already UefiShellDebug1CommandsLib.inf

  gEfiSmbios3TableGuid## SOMETIMES_CONSUMES ## SystemTable

The GUID is also in Smbios.h which is already included in Dmem.c

#include 




-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, 
Jaben
Sent: Wednesday, September 16, 2015 1:10 PM
To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; 
edk2-devel@lists.01.org
Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin@intel.com>
Subject: Re: [edk2] [PATCH 1/1] ShellPkg: Added SMBIOS 3.0 support in dmem

Samer,

2 small things.
1) I think that you also need to update the INF for this newly used GUID.  I 
notice that it's not listed in the current tip.
2) do you need to include the header for this GUID?

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Samer El-Haj-Mahmoud
> Sent: Wednesday, September 16, 2015 11:05 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin 
> <shumin@intel.com>; Samer El-Haj-Mahmoud  mahm...@hp.com>
> Subject: [edk2] [PATCH 1/1] ShellPkg: Added SMBIOS 3.0 support in dmem
> Importance: High
> 
> Added SMBIOS 3.0 support in dmdem Shell command since SMBIOS 3.0 uses 
> a different GUID in the System Configuration Table.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@hpe.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 7 ++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> index 05dc0d5..7693835 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> @@ -1,8 +1,9 @@
>  /** @file
>Main file for Dmem shell Debug1 function.
> 
> -  (C) Copyright 2015 Hewlett-Packard Development Company, L.P.
>Copyright (c) 2010 - 2011, Intel Corporation. All rights 
> reserved.
> +  (C) Copyright 2015 Hewlett-Packard Development Company, L.P.
> +  (C) Copyright 2015 Hewlett Packard Enterprise Development LP
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of 
> the BSD License
>which accompanies this distribution.  The full text of the license 
> may be found at @@ -193,6 +194,10 @@ ShellCommandRunDmem (
>SmbiosTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
>continue;
>  }
> +if (CompareGuid (
> >ConfigurationTable[TableWalker].VendorGuid, )) {
> +  SmbiosTableAddress = (UINT64) (UINTN) gST-
> >ConfigurationTable[TableWalker].VendorTable;
> +  continue;
> +}
>  if (CompareGuid(
> >ConfigurationTable[TableWalker].VendorGuid, )) {
>MpsTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
>continue;
> --
> 1.9.5.msysgit.1
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 1/1] ShellPkg: Added SMBIOS 3.0 support in dmem

2015-09-16 Thread Samer El-Haj-Mahmoud 
Added SMBIOS 3.0 support in dmdem Shell command since SMBIOS 3.0 uses a 
different GUID in the System Configuration Table.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud 
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c 
b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
index 05dc0d5..7693835 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
@@ -1,8 +1,9 @@
 /** @file
   Main file for Dmem shell Debug1 function.
 
-  (C) Copyright 2015 Hewlett-Packard Development Company, L.P.
   Copyright (c) 2010 - 2011, Intel Corporation. All rights reserved.
+  (C) Copyright 2015 Hewlett-Packard Development Company, L.P.  
+  (C) Copyright 2015 Hewlett Packard Enterprise Development LP  
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
   which accompanies this distribution.  The full text of the license may be 
found at
@@ -193,6 +194,10 @@ ShellCommandRunDmem (
   SmbiosTableAddress = 
(UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
   continue;
 }
+if (CompareGuid (>ConfigurationTable[TableWalker].VendorGuid, 
)) {
+  SmbiosTableAddress = (UINT64) (UINTN) 
gST->ConfigurationTable[TableWalker].VendorTable;
+  continue;
+}
 if (CompareGuid(>ConfigurationTable[TableWalker].VendorGuid, 
)) {
   MpsTableAddress = 
(UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
   continue;
-- 
1.9.5.msysgit.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel