Re: [edk2] [PATCH 1/2] MMC : Recieve response was missing after CMD12

2017-09-01 Thread Meenakshi Aggarwal 
Hi Leif,

Sorry I forgot to add the contribution agreement.
Will make sure to add this in next patch.

Yes, I agree to this.

Regards,
Meenakshi

> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Friday, September 01, 2017 4:15 PM
> To: Meenakshi Aggarwal 
> Cc: edk2-devel@lists.01.org; Haojian Zhuang ;
> Jun Nie 
> Subject: Re: [edk2] [PATCH 1/2] MMC : Recieve response was missing after
> CMD12
> 
> On Thu, Aug 31, 2017 at 09:33:08PM +0800, Jun Nie wrote:
> > On 2017年08月31日 19:22, Leif Lindholm wrote:
> > > On Wed, Aug 30, 2017 at 07:50:58PM +0530, Meenakshi Aggarwal wrote:
> > > > We are not recieving the response from memory card after sending
> > > > CMD 12. It was not resulting in any failure but we should recieve
> > > > response after sending a command.
> >
> > Per spec, there is response data for CMD12. It is reasonable to read it.
> >
> > Reviewed-by: Jun Nie 
> 
> Thanks Jun for the review!
> Since this patch is valid on its own, I have pushed it as 1cc0f69bbe.
> No need to include in a v2 submission.
> 
> However, I noticed after pushing (Doh! and for some reason my pre-push
> hook didn't catch this), that your submission was missing the required
> Contributed-under tag, as described by Contributions.txt.
> 
> Can you confirm that you consider your contribution to be under this
> agreement, as well as ensure to include this in any further submissions?
> 
> /
> Leif
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 1/2] MMC : Recieve response was missing after CMD12

2017-09-01 Thread Leif Lindholm 
On Thu, Aug 31, 2017 at 09:33:08PM +0800, Jun Nie wrote:
> On 2017年08月31日 19:22, Leif Lindholm wrote:
> > On Wed, Aug 30, 2017 at 07:50:58PM +0530, Meenakshi Aggarwal wrote:
> > > We are not recieving the response from memory card after
> > > sending CMD 12. It was not resulting in any failure but
> > > we should recieve response after sending a command.
> 
> Per spec, there is response data for CMD12. It is reasonable to read it.
> 
> Reviewed-by: Jun Nie 

Thanks Jun for the review!
Since this patch is valid on its own, I have pushed it as 1cc0f69bbe.
No need to include in a v2 submission.

However, I noticed after pushing (Doh! and for some reason my pre-push
hook didn't catch this), that your submission was missing the required
Contributed-under tag, as described by Contributions.txt.

Can you confirm that you consider your contribution to be under this
agreement, as well as ensure to include this in any further
submissions?

/
Leif
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 1/2] MMC : Recieve response was missing after CMD12

2017-08-31 Thread Meenakshi Aggarwal 
Hi Leif and Jun,

Thanks for the review.

-Original Message-
From: Jun Nie [mailto:jun@linaro.org] 
Sent: Thursday, August 31, 2017 7:03 PM
To: Leif Lindholm ; Meenakshi Aggarwal 

Cc: edk2-devel@lists.01.org; Haojian Zhuang 
Subject: Re: [edk2] [PATCH 1/2] MMC : Recieve response was missing after CMD12

On 2017年08月31日 19:22, Leif Lindholm wrote:
> On Wed, Aug 30, 2017 at 07:50:58PM +0530, Meenakshi Aggarwal wrote:
>> We are not recieving the response from memory card after sending CMD 
>> 12. It was not resulting in any failure but we should recieve 
>> response after sending a command.

Per spec, there is response data for CMD12. It is reasonable to read it.

Reviewed-by: Jun Nie 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 1/2] MMC : Recieve response was missing after CMD12

2017-08-31 Thread Jun Nie 

On 2017年08月31日 19:22, Leif Lindholm wrote:

On Wed, Aug 30, 2017 at 07:50:58PM +0530, Meenakshi Aggarwal wrote:

We are not recieving the response from memory card after
sending CMD 12. It was not resulting in any failure but
we should recieve response after sending a command.


Per spec, there is response data for CMD12. It is reasonable to read it.

Reviewed-by: Jun Nie 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 1/2] MMC : Recieve response was missing after CMD12

2017-08-31 Thread Leif Lindholm 
On Wed, Aug 30, 2017 at 07:50:58PM +0530, Meenakshi Aggarwal wrote:
> We are not recieving the response from memory card after
> sending CMD 12. It was not resulting in any failure but
> we should recieve response after sending a command.

This looks sensible to me, but I'm not very familiar with MMC.

Jun, Haojian - could you comment on this?

/
Leif

> Signed-off-by: Meenakshi Aggarwal 
> ---
>  EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c 
> b/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
> index 403db96..a2b9232 100644
> --- a/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
> +++ b/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
> @@ -206,6 +206,7 @@ MmcTransferBlock (
>  if (EFI_ERROR (Status)) {
>DEBUG ((EFI_D_BLKIO, "%a(): Error and Status:%r\n", __func__, Status));
>  }
> +MmcHost->ReceiveResponse (MmcHost, MMC_RESPONSE_TYPE_R1b, Response);
>}
>  
>Status = MmcNotifyState (MmcHostInstance, MmcTransferState);
> -- 
> 1.9.1
> 
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 1/2] MMC : Recieve response was missing after CMD12

2017-08-30 Thread Meenakshi Aggarwal 
Hi,

Please review this patch.


Thanks & Regards,
Meenakshi

-Original Message-
From: Meenakshi Aggarwal [mailto:meenakshi.aggar...@nxp.com] 
Sent: Wednesday, August 30, 2017 7:51 PM
To: edk2-devel@lists.01.org
Cc: Meenakshi Aggarwal 
Subject: [PATCH 1/2] MMC : Recieve response was missing after CMD12

We are not recieving the response from memory card after sending CMD 12. It was 
not resulting in any failure but we should recieve response after sending a 
command.

Signed-off-by: Meenakshi Aggarwal 
---
 EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c 
b/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
index 403db96..a2b9232 100644
--- a/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
+++ b/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
@@ -206,6 +206,7 @@ MmcTransferBlock (
 if (EFI_ERROR (Status)) {
   DEBUG ((EFI_D_BLKIO, "%a(): Error and Status:%r\n", __func__, Status));
 }
+MmcHost->ReceiveResponse (MmcHost, MMC_RESPONSE_TYPE_R1b, 
+ Response);
   }
 
   Status = MmcNotifyState (MmcHostInstance, MmcTransferState);
--
1.9.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 1/2] MMC : Recieve response was missing after CMD12

2017-08-30 Thread Meenakshi Aggarwal 
We are not recieving the response from memory card after
sending CMD 12. It was not resulting in any failure but
we should recieve response after sending a command.

Signed-off-by: Meenakshi Aggarwal 
---
 EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c 
b/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
index 403db96..a2b9232 100644
--- a/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
+++ b/EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c
@@ -206,6 +206,7 @@ MmcTransferBlock (
 if (EFI_ERROR (Status)) {
   DEBUG ((EFI_D_BLKIO, "%a(): Error and Status:%r\n", __func__, Status));
 }
+MmcHost->ReceiveResponse (MmcHost, MMC_RESPONSE_TYPE_R1b, Response);
   }
 
   Status = MmcNotifyState (MmcHostInstance, MmcTransferState);
-- 
1.9.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel