Re: [edk2] [PATCH 1/2] PcAtChipsetPkg: Define FixePCD's for RTC register values
Are we OK with pushing this patch-set? If so, is that something you can do, Ray? Thanks, Leo. > -Original Message- > From: Ni, Ruiyu [mailto:ruiyu...@intel.com] > Sent: Wednesday, November 08, 2017 12:30 AM > To: Duran, Leo; edk2-devel@lists.01.org > Subject: RE: [PATCH 1/2] PcAtChipsetPkg: Define FixePCD's for RTC register > values > > Reviewed-by: Ruiyu Ni > > Thanks/Ray > > > -Original Message- > > From: Leo Duran [mailto:leo.du...@amd.com] > > Sent: Wednesday, November 1, 2017 1:55 AM > > To: edk2-devel@lists.01.org > > Cc: Leo Duran ; Ni, Ruiyu > > Subject: [PATCH 1/2] PcAtChipsetPkg: Define FixePCD's for RTC register > > values > > > > Define FixedPCD's to replace macros in RTC driver, to allow for > > platform- specific configurations. > > > > Cc: Ruiyu Ni > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leo Duran > > --- > > PcAtChipsetPkg/PcAtChipsetPkg.dec | 13 + > > 1 file changed, 13 insertions(+) > > > > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec > > b/PcAtChipsetPkg/PcAtChipsetPkg.dec > > index b0b2b62..f11d204 100644 > > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec > > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec > > @@ -5,6 +5,7 @@ > > # PcAt defacto standard. > > # > > # Copyright (c) 2009 - 2015, Intel Corporation. All rights > > reserved. > > +# Copyright (c) 2017, AMD Inc. All rights reserved. > > # > > # This program and the accompanying materials # are licensed and > > made available under the terms and conditions of the BSD License @@ > > -181,5 > > +182,17 @@ > ># @Prompt Reset Control Register value for cold reset > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdResetControlValueColdReset|0xFE|UI > > NT8|0x001A > > > > + ## Specifies the initial value for Register_A in RTC. > > + # @Prompt Initial value for Register_A in RTC. > > + > > + > > > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterA|0x26|UINT8| > > 0 > > + x001B > > + > > + ## Specifies the initial value for Register_B in RTC. > > + # @Prompt Initial value for Register_B in RTC. > > + > > + > > > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterB|0x02|UINT8| > > 0 > > + x001C > > + > > + ## Specifies the initial value for Register_D in RTC. > > + # @Prompt Initial value for Register_D in RTC. > > + > > + > > > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8| > > 0 > > + x001D > > + > > [UserExtensions.TianoCore."ExtraFiles"] > >PcAtChipsetPkgExtra.uni > > -- > > 2.7.4 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 1/2] PcAtChipsetPkg: Define FixePCD's for RTC register values
Reviewed-by: Ruiyu NiThanks/Ray > -Original Message- > From: Leo Duran [mailto:leo.du...@amd.com] > Sent: Wednesday, November 1, 2017 1:55 AM > To: edk2-devel@lists.01.org > Cc: Leo Duran ; Ni, Ruiyu > Subject: [PATCH 1/2] PcAtChipsetPkg: Define FixePCD's for RTC register > values > > Define FixedPCD's to replace macros in RTC driver, to allow for platform- > specific configurations. > > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leo Duran > --- > PcAtChipsetPkg/PcAtChipsetPkg.dec | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec > b/PcAtChipsetPkg/PcAtChipsetPkg.dec > index b0b2b62..f11d204 100644 > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec > @@ -5,6 +5,7 @@ > # PcAt defacto standard. > # > # Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved. > +# Copyright (c) 2017, AMD Inc. All rights reserved. > # > # This program and the accompanying materials # are licensed and made > available under the terms and conditions of the BSD License @@ -181,5 > +182,17 @@ ># @Prompt Reset Control Register value for cold reset > > gPcAtChipsetPkgTokenSpaceGuid.PcdResetControlValueColdReset|0xFE|UI > NT8|0x001A > > + ## Specifies the initial value for Register_A in RTC. > + # @Prompt Initial value for Register_A in RTC. > + > + > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterA|0x26|UINT8| > 0 > + x001B > + > + ## Specifies the initial value for Register_B in RTC. > + # @Prompt Initial value for Register_B in RTC. > + > + > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterB|0x02|UINT8| > 0 > + x001C > + > + ## Specifies the initial value for Register_D in RTC. > + # @Prompt Initial value for Register_D in RTC. > + > + > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8| > 0 > + x001D > + > [UserExtensions.TianoCore."ExtraFiles"] >PcAtChipsetPkgExtra.uni > -- > 2.7.4 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH 1/2] PcAtChipsetPkg: Define FixePCD's for RTC register values
Define FixedPCD's to replace macros in RTC driver, to allow for platform-specific configurations. Cc: Ruiyu NiContributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leo Duran --- PcAtChipsetPkg/PcAtChipsetPkg.dec | 13 + 1 file changed, 13 insertions(+) diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec b/PcAtChipsetPkg/PcAtChipsetPkg.dec index b0b2b62..f11d204 100644 --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec @@ -5,6 +5,7 @@ # PcAt defacto standard. # # Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved. +# Copyright (c) 2017, AMD Inc. All rights reserved. # # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License @@ -181,5 +182,17 @@ # @Prompt Reset Control Register value for cold reset gPcAtChipsetPkgTokenSpaceGuid.PcdResetControlValueColdReset|0xFE|UINT8|0x001A + ## Specifies the initial value for Register_A in RTC. + # @Prompt Initial value for Register_A in RTC. + gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterA|0x26|UINT8|0x001B + + ## Specifies the initial value for Register_B in RTC. + # @Prompt Initial value for Register_B in RTC. + gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterB|0x02|UINT8|0x001C + + ## Specifies the initial value for Register_D in RTC. + # @Prompt Initial value for Register_D in RTC. + gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0x001D + [UserExtensions.TianoCore."ExtraFiles"] PcAtChipsetPkgExtra.uni -- 2.7.4 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel