Re: [edk2] [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change function parameter types

2019-02-13 Thread Gao, Liming 
Reviewed-by: Liming Gao 

>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Shenglei Zhang
>Sent: Wednesday, February 13, 2019 2:52 PM
>To: edk2-devel@lists.01.org
>Cc: Wu, Hao A ; Zeng, Star 
>Subject: [edk2] [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change
>function parameter types
>
>Change parameter Opcode from UINT16 to UINTN in
>BootScriptWrite and BootScriptInsert.
>https://bugzilla.tianocore.org/show_bug.cgi?id=1517
>
>Cc: Jian J Wang 
>Cc: Hao Wu 
>Cc: Ray Ni 
>Cc: Star Zeng 
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Shenglei Zhang 
>---
> .../Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h   | 4 ++--
> MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c  | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git
>a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
>b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
>index 19600085f1..b710919881 100644
>--- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
>+++
>b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
>@@ -75,7 +75,7 @@ EFI_STATUS
> EFIAPI
> BootScriptWrite (
>   IN CONST EFI_S3_SAVE_STATE_PROTOCOL  *This,
>-  IN   UINT16   OpCode,
>+  IN   UINTNOpCode,
>   ...
>   );
> /**
>@@ -112,7 +112,7 @@ BootScriptInsert (
>   IN CONST EFI_S3_SAVE_STATE_PROTOCOL*This,
>   IN   BOOLEAN  BeforeOrAfter,
>   IN OUT   EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
>-  IN   UINT16   OpCode,
>+  IN   UINTNOpCode,
>   ...
>   );
> /**
>diff --git a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
>b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
>index 274f3be12c..5913078d69 100644
>--- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
>+++ b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
>@@ -542,7 +542,7 @@ EFI_STATUS
> EFIAPI
> BootScriptWrite (
>   IN CONST EFI_S3_SAVE_STATE_PROTOCOL  *This,
>-  IN   UINT16   OpCode,
>+  IN   UINTNOpCode,
>   ...
>   )
> {
>@@ -697,7 +697,7 @@ BootScriptInsert (
>   IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
>   IN   BOOLEANBeforeOrAfter,
>   IN OUT   EFI_S3_BOOT_SCRIPT_POSITION*Position OPTIONAL,
>-  IN   UINT16 OpCode,
>+  IN   UINTN  OpCode,
>   ...
>   )
> {
>--
>2.18.0.windows.1
>
>___
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 2/3] MdeModulePkg/S3SaveStateDxe: Change function parameter types

2019-02-12 Thread Shenglei Zhang 
Change parameter Opcode from UINT16 to UINTN in
BootScriptWrite and BootScriptInsert.
https://bugzilla.tianocore.org/show_bug.cgi?id=1517

Cc: Jian J Wang 
Cc: Hao Wu 
Cc: Ray Ni 
Cc: Star Zeng 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang 
---
 .../Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h   | 4 ++--
 MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h 
b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
index 19600085f1..b710919881 100644
--- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
+++ b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/InternalS3SaveState.h
@@ -75,7 +75,7 @@ EFI_STATUS
 EFIAPI
 BootScriptWrite (
   IN CONST EFI_S3_SAVE_STATE_PROTOCOL  *This,
-  IN   UINT16   OpCode,
+  IN   UINTNOpCode,
   ...
   );
 /**
@@ -112,7 +112,7 @@ BootScriptInsert (
   IN CONST EFI_S3_SAVE_STATE_PROTOCOL*This,
   IN   BOOLEAN  BeforeOrAfter,
   IN OUT   EFI_S3_BOOT_SCRIPT_POSITION *Position OPTIONAL,
-  IN   UINT16   OpCode,
+  IN   UINTNOpCode,
   ...
   );
 /**
diff --git a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c 
b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
index 274f3be12c..5913078d69 100644
--- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
+++ b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c
@@ -542,7 +542,7 @@ EFI_STATUS
 EFIAPI
 BootScriptWrite (
   IN CONST EFI_S3_SAVE_STATE_PROTOCOL  *This,
-  IN   UINT16   OpCode,
+  IN   UINTNOpCode,
   ...
   )
 {
@@ -697,7 +697,7 @@ BootScriptInsert (
   IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This,
   IN   BOOLEANBeforeOrAfter,
   IN OUT   EFI_S3_BOOT_SCRIPT_POSITION*Position OPTIONAL,
-  IN   UINT16 OpCode,
+  IN   UINTN  OpCode,
   ...
   )
 {
-- 
2.18.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel