subject:"\[edk2\] \[PATCH 3\/4\] ShellPkg\/UefiHandleParsingLib\: Remove some unused Guids"

Re: [edk2] [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids

2019-03-28 Thread Carsey, Jaben

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Ni, Ray
> Sent: Thursday, March 28, 2019 6:50 PM
> To: Zhang, Shenglei ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben 
> Subject: RE: [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some
> unused Guids
> Importance: High
> 
> Reviewed-by: Ray Ni 
> 
> > -Original Message-
> > From: Zhang, Shenglei
> > Sent: Friday, March 29, 2019 9:41 AM
> > To: edk2-devel@lists.01.org
> > Cc: Carsey, Jaben ; Ni, Ray 
> > Subject: [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused
> > Guids
> >
> > ExtendedSalBootService.h, ExtendedSalServiceClasses.h and McaInitPmi.h
> > will be deleted. So remove the Guids defined in these Protocols. And
> > also remove strings in uni file.
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1560
> >
> > Cc: Jaben Carsey 
> > Cc: Ray Ni 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Shenglei Zhang 
> > ---
> >  .../UefiHandleParsingLib/UefiHandleParsingLib.c | 17 -
> >  .../UefiHandleParsingLib.inf| 17 -
> >  .../UefiHandleParsingLib.uni| 17 -
> >  3 files changed, 51 deletions(-)
> >
> > diff --git
> > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> > index 2d94a52108..a106c0906c 100644
> > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> > @@ -2321,23 +2321,6 @@ STATIC CONST GUID_INFO_BLOCK
> mGuidStringList[]
> > = {
> >{STRING_TOKEN(STR_FVB2),
> > &gEfiFirmwareVolumeBlock2ProtocolGuid,NULL},
> >{STRING_TOKEN(STR_CPUIO2),&gEfiCpuIo2ProtocolGuid,
> > NULL},
> >{STRING_TOKEN(STR_LEGACY_R2),
> &gEfiLegacyRegion2ProtocolGuid,
> > NULL},
> > -  {STRING_TOKEN(STR_SAL_MIP),   &gEfiSalMcaInitPmiProtocolGuid,
> > NULL},
> > -  {STRING_TOKEN(STR_ES_BS),
> > &gEfiExtendedSalBootServiceProtocolGuid,  NULL},
> > -  {STRING_TOKEN(STR_ES_BIO),
> > &gEfiExtendedSalBaseIoServicesProtocolGuid,   NULL},
> > -  {STRING_TOKEN(STR_ES_STALL),
> > &gEfiExtendedSalStallServicesProtocolGuid,NULL},
> > -  {STRING_TOKEN(STR_ES_RTC),
> > &gEfiExtendedSalRtcServicesProtocolGuid,  NULL},
> > -  {STRING_TOKEN(STR_ES_VS),
> > &gEfiExtendedSalVariableServicesProtocolGuid, NULL},
> > -  {STRING_TOKEN(STR_ES_MTC),
> > &gEfiExtendedSalMtcServicesProtocolGuid,  NULL},
> > -  {STRING_TOKEN(STR_ES_RESET),
> > &gEfiExtendedSalResetServicesProtocolGuid,NULL},
> > -  {STRING_TOKEN(STR_ES_SC),
> > &gEfiExtendedSalStatusCodeServicesProtocolGuid,   NULL},
> > -  {STRING_TOKEN(STR_ES_FBS),
> > &gEfiExtendedSalFvBlockServicesProtocolGuid,  NULL},
> > -  {STRING_TOKEN(STR_ES_MP),
> > &gEfiExtendedSalMpServicesProtocolGuid,   NULL},
> > -  {STRING_TOKEN(STR_ES_PAL),
> > &gEfiExtendedSalPalServicesProtocolGuid,  NULL},
> > -  {STRING_TOKEN(STR_ES_BASE),
> > &gEfiExtendedSalBaseServicesProtocolGuid, NULL},
> > -  {STRING_TOKEN(STR_ES_MCA),
> > &gEfiExtendedSalMcaServicesProtocolGuid,  NULL},
> > -  {STRING_TOKEN(STR_ES_PCI),
> > &gEfiExtendedSalPciServicesProtocolGuid,  NULL},
> > -  {STRING_TOKEN(STR_ES_CACHE),
> > &gEfiExtendedSalCacheServicesProtocolGuid,NULL},
> > -  {STRING_TOKEN(STR_ES_MCA_LOG),
> > &gEfiExtendedSalMcaLogServicesProtocolGuid,   NULL},
> >{STRING_TOKEN(STR_S2ARCH),&gEfiSecurity2ArchProtocolGuid,
> > NULL},
> >{STRING_TOKEN(STR_EODXE), &gEfiSmmEndOfDxeProtocolGuid,
> > NULL},
> >{STRING_TOKEN(STR_ISAHC), &gEfiIsaHcProtocolGuid,
> > NULL},
> > diff --git
> > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> > index a795fb92de..edab57f892 100644
> > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> > @@ -234,23 +234,6 @@
> >gEfiFirmwareVolumeBlock2ProtocolGuid## UNDEFINED
> >gEfiCpuIo2ProtocolGuid  ## UNDEFINED
> >gEfiLegacyRegion2ProtocolGuid   ## UNDEFINED
> > -  gEfiSalMcaInitPmiProtocolGuid   ## UNDEFINED
> > -  gEfiExtendedSalBootServiceProtocolGuid  ## UNDEFINED
> > -  gEfiExtendedSalBaseIoServicesProtocolGuid   ## UNDEFINED
> > -  gEfiExtendedSalStallServicesProtocolGuid## UNDEFINED
> > -  gEfiExtendedSalRtcServicesProtocolGuid  ## UNDEFINED
> > -  gEfiExtendedSalVariableServicesProtocolGuid ## UNDEFINED
> > -  gEfiExtendedSalMtcServicesProtocolGuid  ## UNDEFINED
> > -  gEfiExtendedSalResetServicesProtocolGuid## UNDEFINED
> > -  gEfiExte

Re: [edk2] [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids

2019-03-28 Thread Ni, Ray

Reviewed-by: Ray Ni 

> -Original Message-
> From: Zhang, Shenglei
> Sent: Friday, March 29, 2019 9:41 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray 
> Subject: [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused
> Guids
> 
> ExtendedSalBootService.h, ExtendedSalServiceClasses.h and McaInitPmi.h will
> be deleted. So remove the Guids defined in these Protocols. And also remove
> strings in uni file.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1560
> 
> Cc: Jaben Carsey 
> Cc: Ray Ni 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang 
> ---
>  .../UefiHandleParsingLib/UefiHandleParsingLib.c | 17 -
>  .../UefiHandleParsingLib.inf| 17 -
>  .../UefiHandleParsingLib.uni| 17 -
>  3 files changed, 51 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> index 2d94a52108..a106c0906c 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> @@ -2321,23 +2321,6 @@ STATIC CONST GUID_INFO_BLOCK mGuidStringList[]
> = {
>{STRING_TOKEN(STR_FVB2),
> &gEfiFirmwareVolumeBlock2ProtocolGuid,NULL},
>{STRING_TOKEN(STR_CPUIO2),&gEfiCpuIo2ProtocolGuid,
> NULL},
>{STRING_TOKEN(STR_LEGACY_R2), &gEfiLegacyRegion2ProtocolGuid,
> NULL},
> -  {STRING_TOKEN(STR_SAL_MIP),   &gEfiSalMcaInitPmiProtocolGuid,
> NULL},
> -  {STRING_TOKEN(STR_ES_BS),
> &gEfiExtendedSalBootServiceProtocolGuid,  NULL},
> -  {STRING_TOKEN(STR_ES_BIO),
> &gEfiExtendedSalBaseIoServicesProtocolGuid,   NULL},
> -  {STRING_TOKEN(STR_ES_STALL),
> &gEfiExtendedSalStallServicesProtocolGuid,NULL},
> -  {STRING_TOKEN(STR_ES_RTC),
> &gEfiExtendedSalRtcServicesProtocolGuid,  NULL},
> -  {STRING_TOKEN(STR_ES_VS),
> &gEfiExtendedSalVariableServicesProtocolGuid, NULL},
> -  {STRING_TOKEN(STR_ES_MTC),
> &gEfiExtendedSalMtcServicesProtocolGuid,  NULL},
> -  {STRING_TOKEN(STR_ES_RESET),
> &gEfiExtendedSalResetServicesProtocolGuid,NULL},
> -  {STRING_TOKEN(STR_ES_SC),
> &gEfiExtendedSalStatusCodeServicesProtocolGuid,   NULL},
> -  {STRING_TOKEN(STR_ES_FBS),
> &gEfiExtendedSalFvBlockServicesProtocolGuid,  NULL},
> -  {STRING_TOKEN(STR_ES_MP),
> &gEfiExtendedSalMpServicesProtocolGuid,   NULL},
> -  {STRING_TOKEN(STR_ES_PAL),
> &gEfiExtendedSalPalServicesProtocolGuid,  NULL},
> -  {STRING_TOKEN(STR_ES_BASE),
> &gEfiExtendedSalBaseServicesProtocolGuid, NULL},
> -  {STRING_TOKEN(STR_ES_MCA),
> &gEfiExtendedSalMcaServicesProtocolGuid,  NULL},
> -  {STRING_TOKEN(STR_ES_PCI),
> &gEfiExtendedSalPciServicesProtocolGuid,  NULL},
> -  {STRING_TOKEN(STR_ES_CACHE),
> &gEfiExtendedSalCacheServicesProtocolGuid,NULL},
> -  {STRING_TOKEN(STR_ES_MCA_LOG),
> &gEfiExtendedSalMcaLogServicesProtocolGuid,   NULL},
>{STRING_TOKEN(STR_S2ARCH),&gEfiSecurity2ArchProtocolGuid,
> NULL},
>{STRING_TOKEN(STR_EODXE), &gEfiSmmEndOfDxeProtocolGuid,
> NULL},
>{STRING_TOKEN(STR_ISAHC), &gEfiIsaHcProtocolGuid,
> NULL},
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> index a795fb92de..edab57f892 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> @@ -234,23 +234,6 @@
>gEfiFirmwareVolumeBlock2ProtocolGuid## UNDEFINED
>gEfiCpuIo2ProtocolGuid  ## UNDEFINED
>gEfiLegacyRegion2ProtocolGuid   ## UNDEFINED
> -  gEfiSalMcaInitPmiProtocolGuid   ## UNDEFINED
> -  gEfiExtendedSalBootServiceProtocolGuid  ## UNDEFINED
> -  gEfiExtendedSalBaseIoServicesProtocolGuid   ## UNDEFINED
> -  gEfiExtendedSalStallServicesProtocolGuid## UNDEFINED
> -  gEfiExtendedSalRtcServicesProtocolGuid  ## UNDEFINED
> -  gEfiExtendedSalVariableServicesProtocolGuid ## UNDEFINED
> -  gEfiExtendedSalMtcServicesProtocolGuid  ## UNDEFINED
> -  gEfiExtendedSalResetServicesProtocolGuid## UNDEFINED
> -  gEfiExtendedSalStatusCodeServicesProtocolGuid   ## UNDEFINED
> -  gEfiExtendedSalFvBlockServicesProtocolGuid  ## UNDEFINED
> -  gEfiExtendedSalMpServicesProtocolGuid   ## UNDEFINED
> -  gEfiExtendedSalPalServicesProtocolGuid  ## UNDEFINED
> -  gEfiExtendedSalBaseServicesProtocolGuid ## UNDEFINED
> -  gEfiExtendedSalMcaServicesProtocolGuid  ## UNDEFINED
> -  gEfiExtendedSalPciServicesProtocolGuid

[edk2] [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids

2019-03-28 Thread Shenglei Zhang

ExtendedSalBootService.h, ExtendedSalServiceClasses.h and
McaInitPmi.h will be deleted. So remove the Guids defined
in these Protocols. And also remove strings in uni file.
https://bugzilla.tianocore.org/show_bug.cgi?id=1560

Cc: Jaben Carsey 
Cc: Ray Ni 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang 
---
 .../UefiHandleParsingLib/UefiHandleParsingLib.c | 17 -
 .../UefiHandleParsingLib.inf| 17 -
 .../UefiHandleParsingLib.uni| 17 -
 3 files changed, 51 deletions(-)

diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c 
b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
index 2d94a52108..a106c0906c 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
@@ -2321,23 +2321,6 @@ STATIC CONST GUID_INFO_BLOCK mGuidStringList[] = {
   {STRING_TOKEN(STR_FVB2),  
&gEfiFirmwareVolumeBlock2ProtocolGuid,NULL},
   {STRING_TOKEN(STR_CPUIO2),&gEfiCpuIo2ProtocolGuid,   
   NULL},
   {STRING_TOKEN(STR_LEGACY_R2), &gEfiLegacyRegion2ProtocolGuid,
   NULL},
-  {STRING_TOKEN(STR_SAL_MIP),   &gEfiSalMcaInitPmiProtocolGuid,
   NULL},
-  {STRING_TOKEN(STR_ES_BS), 
&gEfiExtendedSalBootServiceProtocolGuid,  NULL},
-  {STRING_TOKEN(STR_ES_BIO),
&gEfiExtendedSalBaseIoServicesProtocolGuid,   NULL},
-  {STRING_TOKEN(STR_ES_STALL),  
&gEfiExtendedSalStallServicesProtocolGuid,NULL},
-  {STRING_TOKEN(STR_ES_RTC),
&gEfiExtendedSalRtcServicesProtocolGuid,  NULL},
-  {STRING_TOKEN(STR_ES_VS), 
&gEfiExtendedSalVariableServicesProtocolGuid, NULL},
-  {STRING_TOKEN(STR_ES_MTC),
&gEfiExtendedSalMtcServicesProtocolGuid,  NULL},
-  {STRING_TOKEN(STR_ES_RESET),  
&gEfiExtendedSalResetServicesProtocolGuid,NULL},
-  {STRING_TOKEN(STR_ES_SC), 
&gEfiExtendedSalStatusCodeServicesProtocolGuid,   NULL},
-  {STRING_TOKEN(STR_ES_FBS),
&gEfiExtendedSalFvBlockServicesProtocolGuid,  NULL},
-  {STRING_TOKEN(STR_ES_MP), 
&gEfiExtendedSalMpServicesProtocolGuid,   NULL},
-  {STRING_TOKEN(STR_ES_PAL),
&gEfiExtendedSalPalServicesProtocolGuid,  NULL},
-  {STRING_TOKEN(STR_ES_BASE),   
&gEfiExtendedSalBaseServicesProtocolGuid, NULL},
-  {STRING_TOKEN(STR_ES_MCA),
&gEfiExtendedSalMcaServicesProtocolGuid,  NULL},
-  {STRING_TOKEN(STR_ES_PCI),
&gEfiExtendedSalPciServicesProtocolGuid,  NULL},
-  {STRING_TOKEN(STR_ES_CACHE),  
&gEfiExtendedSalCacheServicesProtocolGuid,NULL},
-  {STRING_TOKEN(STR_ES_MCA_LOG),
&gEfiExtendedSalMcaLogServicesProtocolGuid,   NULL},
   {STRING_TOKEN(STR_S2ARCH),&gEfiSecurity2ArchProtocolGuid,
   NULL},
   {STRING_TOKEN(STR_EODXE), &gEfiSmmEndOfDxeProtocolGuid,  
   NULL},
   {STRING_TOKEN(STR_ISAHC), &gEfiIsaHcProtocolGuid,
   NULL},
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf 
b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
index a795fb92de..edab57f892 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
@@ -234,23 +234,6 @@
   gEfiFirmwareVolumeBlock2ProtocolGuid## UNDEFINED
   gEfiCpuIo2ProtocolGuid  ## UNDEFINED
   gEfiLegacyRegion2ProtocolGuid   ## UNDEFINED
-  gEfiSalMcaInitPmiProtocolGuid   ## UNDEFINED
-  gEfiExtendedSalBootServiceProtocolGuid  ## UNDEFINED
-  gEfiExtendedSalBaseIoServicesProtocolGuid   ## UNDEFINED
-  gEfiExtendedSalStallServicesProtocolGuid## UNDEFINED
-  gEfiExtendedSalRtcServicesProtocolGuid  ## UNDEFINED
-  gEfiExtendedSalVariableServicesProtocolGuid ## UNDEFINED
-  gEfiExtendedSalMtcServicesProtocolGuid  ## UNDEFINED
-  gEfiExtendedSalResetServicesProtocolGuid## UNDEFINED
-  gEfiExtendedSalStatusCodeServicesProtocolGuid   ## UNDEFINED
-  gEfiExtendedSalFvBlockServicesProtocolGuid  ## UNDEFINED
-  gEfiExtendedSalMpServicesProtocolGuid   ## UNDEFINED
-  gEfiExtendedSalPalServicesProtocolGuid  ## UNDEFINED
-  gEfiExtendedSalBaseServicesProtocolGuid ## UNDEFINED
-  gEfiExtendedSalMcaServicesProtocolGuid  ## UNDEFINED
-  gEfiExtendedSalPciServicesProtocolGuid  ## UNDEFINED
-  gEfiExtendedSa

Re: [edk2] [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids

Re: [edk2] [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids

[edk2] [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids

3 matches

Site Navigation

Mail list logo

Footer information