Re: [edk2] [PATCH V2 12/12] EmbeddedPkg: Remove SerialDxe and SerialPortExtLib libraries

[Ard Biesheuvel]

On 17 November 2015 at 12:07, Star Zeng  wrote:
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Leif Lindholm 
> Cc: Ard Biesheuvel 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng 

Reviewed-by: Ard Biesheuvel 

> ---
>  EmbeddedPkg/EmbeddedPkg.dsc|   6 +-
>  EmbeddedPkg/Include/Library/SerialPortExtLib.h | 116 --
>  .../SerialPortExtLibNull/SerialPortExtLibNull.c|  48 ---
>  .../SerialPortExtLibNull/SerialPortExtLibNull.inf  |  30 --
>  .../TemplateSerialPortExtLib.c |  79 -
>  .../TemplateSerialPortExtLib.inf   |  36 --
>  EmbeddedPkg/SerialDxe/SerialDxe.inf|  55 ---
>  EmbeddedPkg/SerialDxe/SerialIo.c   | 391 
> -
>  8 files changed, 1 insertion(+), 760 deletions(-)
>  delete mode 100644 EmbeddedPkg/Include/Library/SerialPortExtLib.h
>  delete mode 100644 
> EmbeddedPkg/Library/SerialPortExtLibNull/SerialPortExtLibNull.c
>  delete mode 100644 
> EmbeddedPkg/Library/SerialPortExtLibNull/SerialPortExtLibNull.inf
>  delete mode 100644 
> EmbeddedPkg/Library/TemplateSerialPortExtLib/TemplateSerialPortExtLib.c
>  delete mode 100644 
> EmbeddedPkg/Library/TemplateSerialPortExtLib/TemplateSerialPortExtLib.inf
>  delete mode 100644 EmbeddedPkg/SerialDxe/SerialDxe.inf
>  delete mode 100644 EmbeddedPkg/SerialDxe/SerialIo.c
>
> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> index 6719eea..a5507ed 100644
> --- a/EmbeddedPkg/EmbeddedPkg.dsc
> +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> @@ -2,7 +2,7 @@
>  # Embedded Package
>  #
>  #
> -# Copyright (c) 2007, Intel Corporation. All rights reserved.
> +# Copyright (c) 2007 - 2015, Intel Corporation. All rights reserved.
>  # Copyright (c) 2012-2015, ARM Ltd. All rights reserved.
>  #
>  #This program and the accompanying materials
> @@ -68,7 +68,6 @@ [LibraryClasses.common]
>PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
>
>
> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
> -  
> SerialPortExtLib|EmbeddedPkg/Library/TemplateSerialPortExtLib/TemplateSerialPortExtLib.inf
>
> RealTimeClockLib|EmbeddedPkg/Library/TemplateRealTimeClockLib/TemplateRealTimeClockLib.inf
>
> EfiResetSystemLib|EmbeddedPkg/Library/TemplateResetSystemLib/TemplateResetSystemLib.inf
>GdbSerialLib|EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.inf
> @@ -249,8 +248,6 @@ [Components.common]
>EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.inf
>
> EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
>EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
> -  MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
> -  EmbeddedPkg/Library/SerialPortExtLibNull/SerialPortExtLibNull.inf
>EmbeddedPkg/Library/TemplateResetSystemLib/TemplateResetSystemLib.inf
>EmbeddedPkg/Library/TemplateRealTimeClockLib/TemplateRealTimeClockLib.inf
>
> EmbeddedPkg/Library/LzmaHobCustomDecompressLib/LzmaHobCustomDecompressLib.inf
> @@ -261,7 +258,6 @@ [Components.common]
>EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.inf
>EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
>EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf
> -  EmbeddedPkg/SerialDxe/SerialDxe.inf
>EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOutSerial.inf
>EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf {
>  
> diff --git a/EmbeddedPkg/Include/Library/SerialPortExtLib.h 
> b/EmbeddedPkg/Include/Library/SerialPortExtLib.h
> deleted file mode 100644
> index 0d0abb3..000
> --- a/EmbeddedPkg/Include/Library/SerialPortExtLib.h
> +++ /dev/null
> @@ -1,116 +0,0 @@
> -/** @file
> -
> -  Serial I/O port control interface extension.
> -
> -  This library provides an extension to the library providing common
> -  serial I/O port functions that is defined in MdePkg. The aim is to
> -  provide more control over the functionalities of a serial port. The
> -  extension covers all the needs of the UEFI Serial I/O Protocol.
> -  Though, its use is not restricted to the UEFI Serial I/O Protocol.
> -  It could for example be used in the PEI phase of the boot sequence
> -  as well.
> -
> -  Copyright (c) 2012 - 2014, ARM Ltd. All rights reserved.
> -
> -  This program and the accompanying materials
> -  are licensed and made available under the terms and conditions of the BSD 
> License
> -  which accompanies this distribution.  The full text of the license may be 
> found at
> -  http://opensource.org/licenses/bsd-license.php
> -
> -  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
> IMPLIED.
> -
> -**/
> -
> -#ifndef __SERIAL_PORT_EXT_LIB_H__
> -#define __SERIAL_PORT_EXT_LIB_H__
> -

[edk2] [PATCH V2 12/12] EmbeddedPkg: Remove SerialDxe and SerialPortExtLib libraries

[Star Zeng]

Cc: Michael D Kinney 
Cc: Liming Gao 
Cc: Leif Lindholm 
Cc: Ard Biesheuvel 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng 
---
 EmbeddedPkg/EmbeddedPkg.dsc|   6 +-
 EmbeddedPkg/Include/Library/SerialPortExtLib.h | 116 --
 .../SerialPortExtLibNull/SerialPortExtLibNull.c|  48 ---
 .../SerialPortExtLibNull/SerialPortExtLibNull.inf  |  30 --
 .../TemplateSerialPortExtLib.c |  79 -
 .../TemplateSerialPortExtLib.inf   |  36 --
 EmbeddedPkg/SerialDxe/SerialDxe.inf|  55 ---
 EmbeddedPkg/SerialDxe/SerialIo.c   | 391 -
 8 files changed, 1 insertion(+), 760 deletions(-)
 delete mode 100644 EmbeddedPkg/Include/Library/SerialPortExtLib.h
 delete mode 100644 
EmbeddedPkg/Library/SerialPortExtLibNull/SerialPortExtLibNull.c
 delete mode 100644 
EmbeddedPkg/Library/SerialPortExtLibNull/SerialPortExtLibNull.inf
 delete mode 100644 
EmbeddedPkg/Library/TemplateSerialPortExtLib/TemplateSerialPortExtLib.c
 delete mode 100644 
EmbeddedPkg/Library/TemplateSerialPortExtLib/TemplateSerialPortExtLib.inf
 delete mode 100644 EmbeddedPkg/SerialDxe/SerialDxe.inf
 delete mode 100644 EmbeddedPkg/SerialDxe/SerialIo.c

diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
index 6719eea..a5507ed 100644
--- a/EmbeddedPkg/EmbeddedPkg.dsc
+++ b/EmbeddedPkg/EmbeddedPkg.dsc
@@ -2,7 +2,7 @@
 # Embedded Package
 #
 #
-# Copyright (c) 2007, Intel Corporation. All rights reserved.
+# Copyright (c) 2007 - 2015, Intel Corporation. All rights reserved.
 # Copyright (c) 2012-2015, ARM Ltd. All rights reserved.
 #
 #This program and the accompanying materials
@@ -68,7 +68,6 @@ [LibraryClasses.common]
   PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
 
   SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
-  
SerialPortExtLib|EmbeddedPkg/Library/TemplateSerialPortExtLib/TemplateSerialPortExtLib.inf
   
RealTimeClockLib|EmbeddedPkg/Library/TemplateRealTimeClockLib/TemplateRealTimeClockLib.inf
   
EfiResetSystemLib|EmbeddedPkg/Library/TemplateResetSystemLib/TemplateResetSystemLib.inf
   GdbSerialLib|EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.inf
@@ -249,8 +248,6 @@ [Components.common]
   EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.inf
   
EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
   EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
-  MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
-  EmbeddedPkg/Library/SerialPortExtLibNull/SerialPortExtLibNull.inf
   EmbeddedPkg/Library/TemplateResetSystemLib/TemplateResetSystemLib.inf
   EmbeddedPkg/Library/TemplateRealTimeClockLib/TemplateRealTimeClockLib.inf
   EmbeddedPkg/Library/LzmaHobCustomDecompressLib/LzmaHobCustomDecompressLib.inf
@@ -261,7 +258,6 @@ [Components.common]
   EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.inf
   EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
   EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf
-  EmbeddedPkg/SerialDxe/SerialDxe.inf
   EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOutSerial.inf
   EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf {
 
diff --git a/EmbeddedPkg/Include/Library/SerialPortExtLib.h 
b/EmbeddedPkg/Include/Library/SerialPortExtLib.h
deleted file mode 100644
index 0d0abb3..000
--- a/EmbeddedPkg/Include/Library/SerialPortExtLib.h
+++ /dev/null
@@ -1,116 +0,0 @@
-/** @file
-
-  Serial I/O port control interface extension.
-
-  This library provides an extension to the library providing common
-  serial I/O port functions that is defined in MdePkg. The aim is to
-  provide more control over the functionalities of a serial port. The
-  extension covers all the needs of the UEFI Serial I/O Protocol.
-  Though, its use is not restricted to the UEFI Serial I/O Protocol.
-  It could for example be used in the PEI phase of the boot sequence
-  as well.
-
-  Copyright (c) 2012 - 2014, ARM Ltd. All rights reserved.
-
-  This program and the accompanying materials
-  are licensed and made available under the terms and conditions of the BSD 
License
-  which accompanies this distribution.  The full text of the license may be 
found at
-  http://opensource.org/licenses/bsd-license.php
-
-  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-
-**/
-
-#ifndef __SERIAL_PORT_EXT_LIB_H__
-#define __SERIAL_PORT_EXT_LIB_H__
-
-#include 
-#include 
-
-/**
-
-  Assert or deassert the control signals on a serial port.
-  The following control signals are set according their bit settings :
-  . Request to Send
-  . Data Terminal Ready
-
-  @param[in]  Control  The following bits are taken into account :
-   . EFI_SERIAL_REQUEST_TO_SEND :